From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <msantana@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id E8B654C8D;
 Mon,  4 Mar 2019 20:07:20 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 4AE183081256;
 Mon,  4 Mar 2019 19:07:20 +0000 (UTC)
Received: from localhost.localdomain.com (unknown [10.18.25.8])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 926615C207;
 Mon,  4 Mar 2019 19:07:19 +0000 (UTC)
From: Michael Santana <msantana@redhat.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Van Haaren Harry <harry.van.haaren@intel.com>, ramirose@gmail.com,
 Thomas Monjalon <thomas@monjalon.net>
Date: Mon,  4 Mar 2019 14:07:16 -0500
Message-Id: <20190304190716.5847-3-msantana@redhat.com>
In-Reply-To: <20190304190716.5847-1-msantana@redhat.com>
References: <20190301170806.3547-1-msantana@redhat.com>
 <20190304190716.5847-1-msantana@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.49]); Mon, 04 Mar 2019 19:07:20 +0000 (UTC)
Subject: [dpdk-dev] [PATCH v4 2/2] devtools: fix result of svg include check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Mar 2019 19:07:21 -0000

Fix trivial bug. In sh shell, 'foo = 1' is not the same as
'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
as a command, rather than a simple variable assignment.

Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
Cc: stable@dpdk.org

Signed-off-by: Michael Santana <msantana@redhat.com>
---
 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 7e862e0a4..521534fce 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -73,7 +73,7 @@ check_forbidden_additions() { # <patch>
 		-v RET_ON_FAIL=1 \
 		-v MESSAGE='Using explicit .svg extension instead of .*' \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-		"$1" || res = 1
+		"$1" || res=1
 
 	return $res
 }
-- 
2.20.1