From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gaetan.rivet@6wind.com> Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id F2C7A4CA9 for <dev@dpdk.org>; Tue, 5 Mar 2019 17:43:29 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id q187so3243432wme.5 for <dev@dpdk.org>; Tue, 05 Mar 2019 08:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=WBFVP6HdKFWIPvw14h6i3D655guZgQOuP4XU3SE6dIY=; b=dOvf9+Rr5U1IOcOanfvU9HcTPihiYAANhkBGMs3KHbYGM2k1Apeh9jWf2PIiALAMsr g4m6Krw587jlc9hAgZw/DRA0ciw/ETtwosSdJOSEfpVzxlQvPWNEXUzHZabUPlIHmZRQ i032Zb1blTQeWJhG4iS230xTOtV6dBWsWMxJOWhKlFo8DkRluQg2iLeF4eABDt6mJwL1 Jl16qPDeFjE5a0ZakThtOpTAeXpZ8M/w7ayLj1K7kzO0r7nYEcb7WYSQyySxLl8LQpfn 4FDmDrl1pmHFaEhEPSgHM4NX3/Zz+/nVtGRx9J/zkQNFpkGqQw+AiPrEjxyp9urSdAxq f/xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=WBFVP6HdKFWIPvw14h6i3D655guZgQOuP4XU3SE6dIY=; b=Gc7CxgB04Ym+TdAekKQXPhUl+hyYB8ZV4ulfD+DWSqPC2thjUFvg+VutQ4JmbTyLvf 9rDB/DkwLlGNT5MkCB/VN9XrQzte9ukhlFTr9NCnfDOjDj1uXcmdyP/FHp3UEbF4JQsZ OrQJipmK/sPkZtGtO1qV3DYAE/v8zoGxFwvws1y77o6O1aAs4iX4Epn3XL+sMjN277nZ JP3pJx+q9FUY6ZRfokIYuVEuebjGNl6PcChBukwdAmsogeBbEqzrphLIlEfBMMxtrJB3 9t2qP7PueiC8z4bBkwtc9TtZ3I8mDDSURLvhXDyVvxjTxJb1AXWjNbLhJ26eyTnAUWQI pz0A== X-Gm-Message-State: APjAAAVXafRJSyQYcN0i5gZGi8atF+iQIwl2f8yosYObQ8VPK2mdT0MM 7aqFaXdWp+vhZR82IkJBh4jqQPrc+8A= X-Google-Smtp-Source: APXvYqz+dDJk4j6qmNSnEtGEDg4zoWtd8W/kxHS6UYE4AHbkX2KzSnVRqYphtR/WdP8ZDHUs9gm0Aw== X-Received: by 2002:a1c:ab88:: with SMTP id u130mr3283713wme.148.1551804209506; Tue, 05 Mar 2019 08:43:29 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id p12sm9888860wrt.4.2019.03.05.08.43.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Mar 2019 08:43:28 -0800 (PST) Date: Tue, 5 Mar 2019 17:43:26 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com> To: Raslan Darawsheh <rasland@mellanox.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, "stephen@networkplumber.org" <stephen@networkplumber.org> Message-ID: <20190305164326.pu4y4srtnnt7zc7k@bidouze.vm.6wind.com> References: <1551779507-10857-1-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1551779507-10857-1-git-send-email-rasland@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 05 Mar 2019 16:43:30 -0000 Hello Raslan, Sorry for the delay. I have had a little trouble reading the patches. I think the 3 first should be squashed into a single one, it would be more coherent. I think I have seen a few points where doing so would have prevented some unnecessary changes for example, simplifying the series. (thinking about at least two PORT_ID() and a few ETH() removal that might have been prevented, I will try to point them all to you.) On Tue, Mar 05, 2019 at 09:52:04AM +0000, Raslan Darawsheh wrote: > In multiprocess context, the private structure is shared between > processes. The back reference from private to generic data was using > a pointer to a per process eth_dev. It's now changed to a reference of > the shared data. > > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > --- > drivers/net/failsafe/failsafe.c | 2 +- > drivers/net/failsafe/failsafe_intr.c | 10 +++++----- > drivers/net/failsafe/failsafe_ops.c | 4 ++-- > drivers/net/failsafe/failsafe_private.h | 6 +++++- > drivers/net/failsafe/failsafe_rxtx.c | 4 ++-- > 5 files changed, 15 insertions(+), 11 deletions(-) > Beside the squashing, this patch seems ok. -- Gaëtan Rivet 6WIND