From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C41DE2BA3 for ; Tue, 5 Mar 2019 18:21:17 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2019 09:21:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,444,1544515200"; d="scan'208";a="162551172" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36]) by orsmga001.jf.intel.com with SMTP; 05 Mar 2019 09:21:13 -0800 Received: by (sSMTP sendmail emulation); Tue, 05 Mar 2019 17:21:12 +0000 Date: Tue, 5 Mar 2019 17:21:12 +0000 From: Bruce Richardson To: Andrius Sirvys Cc: dev@dpdk.org Message-ID: <20190305172111.GA103192@bricha3-MOBL.ger.corp.intel.com> References: <1551803365-79357-1-git-send-email-andrius.sirvys@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1551803365-79357-1-git-send-email-andrius.sirvys@intel.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v2] meson: fix building subdirectories separately X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 17:21:18 -0000 On Tue, Mar 05, 2019 at 04:29:25PM +0000, Andrius Sirvys wrote: > If for debugging we disable the driver directory in the meson.build file, > we get an error because the variable "driver_classes" does not exist. > This is because driver_classes is only defined in the > drivers/meson.build file. Defining driver_classes in dpdk/meson.build file > will make it easier for compiling separate directories. > > In the process, we rename driver_classes to dpdk_driver_classes for > consistency with the other variables. > > Signed-off-by: Andrius Sirvys > --- > v2: Fixed mispellings in commit message > --- This can be useful, and a similar change I saw in the windows RFC since it is incrementally adding things to the windows build, and so would hit this error. Therefore, Acked-by: Bruce Richardson