From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id EE7732C18 for ; Tue, 5 Mar 2019 18:40:04 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id g12so10419261wrm.5 for ; Tue, 05 Mar 2019 09:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=3SwmZ9d/zbuuLijurl5REDLYmwn7JuSCq+TEljUx9C8=; b=WY03lqorITh+ixeDMpmRPwPLQF8GQFINBi92fFSCJKgawpc+QBdAttzVW4abDw96l6 KEeJSQpYmXZBcONn5M3j4yUNkt1wiyPbDUEL1X4ORH0EJDRQKWd/1aHnMPPeIW79CPxC /CMSMUN1yCP4cPdOPEq6zoAT+/37X6TKUAEvWOTQ8UBoC/mh7zhwmV2lyjqvlMFEDJeC iIMZJ97eFv1PruHQDR/USguLssbsB6CjXY0QONV3Dku+LYl5QocUpvDoSZQSJbwYHYkF Wokou3H8h/V5LGO8/8RlEJOEMyWc4x04DnC9Nn5boIll3ExbFCf/ZKjpoPveeGMA9Qcf NJ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=3SwmZ9d/zbuuLijurl5REDLYmwn7JuSCq+TEljUx9C8=; b=gPUjnTJwoB+pTHVdd3CRgbv5/nwKuOVX72UBKlTsuvDZ2eQexN6DrXc1zhbtgNGiUG PZsvogZPM3GxdoBNK2pXQDBESHRpPT30zwKmAkD7VPTd9eUK2SvTh/jhPFLE8Gas8BcC GcTyMlAGufH64UG32wYg1TuHp45fVdgV68Y/nR3kqoJo75C+Kcc+TvG1jPRA/WHNB/M5 B2CfOxSquMf+7uZX4LZEI7dSF1cV7HTNnZUhUDiQHjzZwMfnXcMKCTKhLMdueD8IbVxi 7bAC0J43IoKY6mkV4gOcfWkBZBIyTEQ0OzPPLO6HC83mtz+ZzSp0nWSs4E5D3yyHUmMc M5wA== X-Gm-Message-State: APjAAAWGofJj4LgXAiOCdvQyR/0mbKp9OzbhlTk5vmxG+8X3LVw6DKgE E9zPxEkOz3g4dAU7BHcoCpzR3A== X-Google-Smtp-Source: APXvYqxPviWzkXfTLDsCTIfe701+PswAt3dA4QB/sC1RwmF2dGAOB8RuwkP190wCqBcnciGfN+1ySA== X-Received: by 2002:adf:a49c:: with SMTP id g28mr14642wrb.147.1551807604697; Tue, 05 Mar 2019 09:40:04 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v67sm214178wmb.9.2019.03.05.09.40.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Mar 2019 09:40:04 -0800 (PST) Date: Tue, 5 Mar 2019 18:40:02 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Raslan Darawsheh Cc: "dev@dpdk.org" , Thomas Monjalon , "stephen@networkplumber.org" Message-ID: <20190305174002.b52wokrajmnbbqsh@bidouze.vm.6wind.com> References: <1551779507-10857-1-git-send-email-rasland@mellanox.com> <20190305164326.pu4y4srtnnt7zc7k@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190305164326.pu4y4srtnnt7zc7k@bidouze.vm.6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 17:40:05 -0000 On Tue, Mar 05, 2019 at 05:43:26PM +0100, Gaëtan Rivet wrote: > Hello Raslan, > > Sorry for the delay. > > I have had a little trouble reading the patches. I think the 3 first > should be squashed into a single one, it would be more coherent. > > I think I have seen a few points where doing so would have prevented > some unnecessary changes for example, simplifying the series. (thinking > about at least two PORT_ID() and a few ETH() removal that might have > been prevented, I will try to point them all to you.) > > On Tue, Mar 05, 2019 at 09:52:04AM +0000, Raslan Darawsheh wrote: > > In multiprocess context, the private structure is shared between > > processes. The back reference from private to generic data was using > > a pointer to a per process eth_dev. It's now changed to a reference of > > the shared data. > > > > Signed-off-by: Raslan Darawsheh > > Signed-off-by: Thomas Monjalon > > --- > > drivers/net/failsafe/failsafe.c | 2 +- > > drivers/net/failsafe/failsafe_intr.c | 10 +++++----- > > drivers/net/failsafe/failsafe_ops.c | 4 ++-- > > drivers/net/failsafe/failsafe_private.h | 6 +++++- > > drivers/net/failsafe/failsafe_rxtx.c | 4 ++-- > > 5 files changed, 15 insertions(+), 11 deletions(-) > > > > Beside the squashing, this patch seems ok. Okay after reading a little more closely, it does not seem interesting to squash finaly, and it will be simpler for you to continue with your current series, so forget about that. -- Gaëtan Rivet 6WIND