From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 03D132C17 for <dev@dpdk.org>; Thu, 7 Mar 2019 11:24:56 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2019 02:24:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,451,1544515200"; d="scan'208";a="129587994" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36]) by fmsmga008.fm.intel.com with SMTP; 07 Mar 2019 02:24:53 -0800 Received: by (sSMTP sendmail emulation); Thu, 07 Mar 2019 10:24:52 +0000 Date: Thu, 7 Mar 2019 10:24:51 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Anand Rawat <anand.rawat@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Kadam, Pallavi" <pallavi.kadam@intel.com>, "Menon, Ranjit" <ranjit.menon@intel.com>, "Shaw, Jeffrey B" <jeffrey.b.shaw@intel.com> Message-ID: <20190307102451.GB374484@bricha3-MOBL.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <2585800.7Z22QRaGj1@xps> <97a6242f-6d56-0c12-aba0-5e1f4c609a49@intel.com> <2354479.T0gxW44koM@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2354479.T0gxW44koM@xps> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 07 Mar 2019 10:24:57 -0000 On Thu, Mar 07, 2019 at 09:45:57AM +0100, Thomas Monjalon wrote: > 07/03/2019 04:27, Anand Rawat: > > On 3/6/2019 3:31 AM, Thomas Monjalon wrote: > > > 06/03/2019 05:16, Anand Rawat: > > >> Added header files to support windows on x86 platforms. > > >> Updated rte_config to include rte_windows.h for windows > > >> build. > > > [...] > > >> --- a/config/rte_config.h > > >> +++ b/config/rte_config.h > > >> +/* windows specific*/ > > >> +#ifdef RTE_EXEC_ENV_WINDOWS > > >> +#include <rte_windows.h> > > >> +#endif > > > > > > Include in the config file looks wrong. > > > >> --- /dev/null > > >> +++ b/lib/librte_eal/windows/eal/include/exec-env/rte_windows.h > > > > > > I think we could remove the sub-directory exec-env. > > > Could we include this file from rte_common.h? > > rte_windows.h defines types and substitution macros which are > > needed to support common code on windows. So it should be > > included as a global include for every library on windows. > > rte_common.h is not included in all the source code and headers > > we currently build for windows. > > I think it is not an issue adding some rte_common.h include > here and there. > I'd be hesitant about putting it in rte_common.h without knowing the scope of the changes - "here and there" could end up being "everywhere". Another alternative is to see if most/all the definitions could actually be put in dpdk_conf and thereby go into the standard config.h file generated at build time. Anything that couldn't be done via macros or defines in the config could then look to be put maybe in rte_common.h or other locations, perhaps. /Bruce