DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: olegpoly123 <olegp123@walla.co.il>
Cc: keith.wiles@intel.com, thomas@monjalon.net, dev@dpdk.org,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] net/tap: fix missing _SC_IOV_MAX
Date: Fri, 8 Mar 2019 13:51:53 -0800	[thread overview]
Message-ID: <20190308135140.431772b6@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20190308190658.6313-1-olegp123@walla.co.il>

On Fri,  8 Mar 2019 14:06:58 -0500
olegpoly123 <olegp123@walla.co.il> wrote:

>  	struct rx_queue *rxq = &internals->rxq[rx_queue_id];
>  	struct rte_mbuf **tmp = &rxq->pool;
>  	long iov_max = sysconf(_SC_IOV_MAX);
> +
> +	if (iov_max <= 0) {
> +		TAP_LOG(WARNING,
> +			"_SC_IOV_MAX is not defined. Using %d as default\n", TAP_IOV_DEFAULT_MAX);
> +		iov_max = TAP_IOV_DEFAULT_MAX;
> +	}
>  	uint16_t nb_desc = RTE_MIN(nb_rx_desc, iov_max - 1);
>  	struct iovec (*iovecs)[nb_desc + 1];

Don't mix code and declarations.

      parent reply	other threads:[~2019-03-09  0:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08 19:06 olegpoly123
2019-03-08 19:13 ` Wiles, Keith
2019-03-08 21:51 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190308135140.431772b6@shemminger-XPS-13-9360 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=keith.wiles@intel.com \
    --cc=olegp123@walla.co.il \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).