From: Stephen Hemminger <stephen@networkplumber.org>
To: olegpoly123 <olegp123@walla.co.il>
Cc: keith.wiles@intel.com, thomas@monjalon.net, dev@dpdk.org,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX
Date: Fri, 8 Mar 2019 19:02:46 -0800 [thread overview]
Message-ID: <20190308190246.3c6dc15c@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20190308180016.5522-1-olegp123@walla.co.il>
On Fri, 8 Mar 2019 13:00:16 -0500
olegpoly123 <olegp123@walla.co.il> wrote:
> long iov_max = sysconf(_SC_IOV_MAX);
> +
> + if (iov_max <= 0) {
> + TAP_LOG(WARNING,
> + "_SC_IOV_MAX is not defined. Using %d as default\n", TAP_IOV_DEFAULT_MAX);
> + iov_max = TAP_IOV_DEFAULT_MAX;
> + }
You haven't listened to my comment about mixing declaration and
code. Why?
next prev parent reply other threads:[~2019-03-09 3:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 18:00 olegpoly123
2019-03-08 18:06 ` Wiles, Keith
2019-03-08 18:54 ` Thomas Monjalon
2019-03-09 3:02 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-07 22:25 olegpoly123
2019-03-07 22:31 ` Wiles, Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308190246.3c6dc15c@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=olegp123@walla.co.il \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).