From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com
 [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 5A80E201
 for <dev@dpdk.org>; Sat,  9 Mar 2019 04:02:52 +0100 (CET)
Received: by mail-pg1-f196.google.com with SMTP id q206so15603910pgq.4
 for <dev@dpdk.org>; Fri, 08 Mar 2019 19:02:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Y/jL/fhgQHStNmmjrv9U+09OQf1kVand0KcTwQ1ZYhk=;
 b=1tPEWvZB1reAS7sFC3AEspkv4H9A+Qx6tCNKRJi2W0yD1wv263SGCKkwIRo4fqNOBF
 rtBQX8WK/SZnvLrScw/tJdP8SFWrBng2hm+htRic1z6WGTldoDdLoGX93xGFOQ5BFsjc
 9TJ4trLEYoJWe7XRGjCZhBt7MvhR0Z0VH+ioB6P7bkN7cbFYt101yi1TVZsy/WLnIbT9
 aPFaB9+9u9cM957EkBef3jDhPYbZZfQpFXQ8tZRxTBogpD6iUIe4qi4cj0CSm0bAQLVU
 AKMo0zaRn302SH6fZ+139EiOISVOgnvyGvVwFZSQE6bSLoydOQV/cF3/uPCLq0e+alob
 nszA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Y/jL/fhgQHStNmmjrv9U+09OQf1kVand0KcTwQ1ZYhk=;
 b=PXQP+ayrTcUiO2FPrNDtFNRUmJ/gwB5tyDHREEtqKBoxNUacWbdNgEfLitdr2hD672
 wZL54CfvGPXOIFthK1Z799ByI9UBXoqsOsaOTVv3O+BH2Thay5q7xZAuYQcciVnInnaZ
 Fd/2HXIDUbtdzMxRiulJfftYCVln8a5Fk7OrsD1NJ9ODHiFd+SpUlM1E6hjYWd0OnDGE
 ZLsx16lrYUCwCWJRhApVztlI3k9ticXBzFPZEpCzCCIdO2BfZF7Fjs13qK8KE0aoThg7
 5U0TC6h5OSzzgeCPg+vkK23TY+h8zhpqxMBzSdgosvocre8ZW4wo5Em4JLh7w5m6HDzK
 NBoA==
X-Gm-Message-State: APjAAAVTEOsegWtbYNrjGxmOm6wt2kViQ00VUTcaFfXKUmNAbS9umcIx
 WlwRDS3y41KF5WvY3QPLniU0Og==
X-Google-Smtp-Source: APXvYqwxkO30jIrk5COE6LwwFZrNqfOAyET4o2ZHCoCcTlycE5W3hekvWWp3urRMmdw0xiBgSTkV1A==
X-Received: by 2002:a63:fd03:: with SMTP id d3mr19442130pgh.359.1552100571250; 
 Fri, 08 Mar 2019 19:02:51 -0800 (PST)
Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com.
 [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id l184sm14955947pfc.41.2019.03.08.19.02.50
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Fri, 08 Mar 2019 19:02:51 -0800 (PST)
Date: Fri, 8 Mar 2019 19:02:46 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: olegpoly123 <olegp123@walla.co.il>
Cc: keith.wiles@intel.com, thomas@monjalon.net, dev@dpdk.org, stable@dpdk.org
Message-ID: <20190308190246.3c6dc15c@shemminger-XPS-13-9360>
In-Reply-To: <20190308180016.5522-1-olegp123@walla.co.il>
References: <20190308180016.5522-1-olegp123@walla.co.il>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Mar 2019 03:02:52 -0000

On Fri,  8 Mar 2019 13:00:16 -0500
olegpoly123 <olegp123@walla.co.il> wrote:

>  	long iov_max = sysconf(_SC_IOV_MAX);
> +
> +	if (iov_max <= 0) {
> +		TAP_LOG(WARNING,
> +			"_SC_IOV_MAX is not defined. Using %d as default\n", TAP_IOV_DEFAULT_MAX);
> +		iov_max = TAP_IOV_DEFAULT_MAX;
> +	}

You haven't listened to my comment about mixing declaration and
code. Why?