From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 3D63027D for ; Sat, 9 Mar 2019 16:24:47 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id n74so335584pfi.9 for ; Sat, 09 Mar 2019 07:24:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g+dc8qKw9qkkbve622KMTWWrrM8w2x4XWkHb538M2cs=; b=RdLdSYuPBceFufn2eZZ3nv8sLyQ6WaT2m+hPuCb3VcH+dlaVVaEbTr5/R0FaTkPPTb AounpQXMiUlRfqYnIkGWgJwBWapCubsep2Q+NdHPvPA+AJKu6Iv0Slwy0Tm4tofjivmH rlkhpHLZyMnYoOTe02PB3G/4nTzUg89Nf7n3/PS/e3af4DOhTB77+J7M/wVCnH/CUadi o9jxcwSr5QJCj0MqFRQrJefPGnEDDSlAmuWJTknvsvgfIqxcj22AqKU8YbKPArCyGqpv g+ofd1y7buOuk62kBrIvPIVD159LUUP4xtq3ZN+Fsx7wYwujpNxLUiA/oKKVs0rNNE+W /aVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g+dc8qKw9qkkbve622KMTWWrrM8w2x4XWkHb538M2cs=; b=hJ81+g4SjzrCf/v9IyNuNDRu9C5dbgB4wMY/SuBXgOdyowT5/kmJrWs/Y+XljMk2mm yevK0VmIpPr/4Zr+wVTKEXGxOYJYbW4DJWhqII6xdBaPnwE439W21CArju9LaLlYNram /qcc/ahLC/MDKI5guIlSJmO30Reqj3yD42ho1kVWapRWSsSAR0A5UNGpuqWevLld3bgZ WYR2Bmu9zC9MEGuGOHRRzerkuaGz5TpDODwxXN6hJGUEwleNbIi7hNfBU56LosQqX7Wc 1++CeCmgvsUdDfADtfO0i6bCeDHi0oiMoS39KIYGDSYuYm9xBh73j0sSD/Y8sCEaQjJ/ 6joQ== X-Gm-Message-State: APjAAAUxGy60md6hU0HbBGNREu0jgqxmx+bQOhpgz2+mUoVbREKfdU2z XV5ipAkFKpYI1qIbzOX22Q0vGw== X-Google-Smtp-Source: APXvYqxtJu1rH3PXKthFN/1ReOictWQaffuD2QEOBPP2ZTU94EtCnqLIfTOxP7KXPqGExgVCTDIM5w== X-Received: by 2002:a63:a109:: with SMTP id b9mr21760608pgf.328.1552145086170; Sat, 09 Mar 2019 07:24:46 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c127sm1759716pfg.133.2019.03.09.07.24.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Mar 2019 07:24:45 -0800 (PST) Date: Sat, 9 Mar 2019 07:24:40 -0800 From: Stephen Hemminger To: Igor Russkikh Cc: "dev@dpdk.org" , Pavel Belous , "stable@dpdk.org" Message-ID: <20190309072440.4befa21e@shemminger-XPS-13-9360> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 04/10] net/atlantic: fix buffer overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Mar 2019 15:24:47 -0000 On Sat, 9 Mar 2019 14:03:30 +0000 Igor Russkikh wrote: > From: Pavel Belous > > Found by Coverity scan. This is a real memory corruption. > There is no need in extra RTE_ALIGN macros since the > request/result structures are 4-byte aligned by definition. When fixing bugs found by Coverity it is best to mark these with the Coverity number. The convention (in Linux kernel) is shown by these examples: Addresses-Coverity-ID: 1476095 ("Bad bit shift operation") Detected by CoverityScan, CID#1476031 ("Dereference before null check") Should this go in the style guide somewhere?