* [dpdk-dev] [PATCH] net/i40e: fix time sync for 25G
@ 2019-03-11 7:42 Qi Zhang
2019-03-12 1:21 ` Luo, Michael
0 siblings, 1 reply; 3+ messages in thread
From: Qi Zhang @ 2019-03-11 7:42 UTC (permalink / raw)
To: dev; +Cc: michael.luo, Qi Zhang, stable
Time sync increment value is not configured for 25G device.
The patch fix this issue by setting the same value as 40G, this
aligned with kernel driver's behaviour.
Fixes: 75d133dd3296 ("net/i40e: enable 25G device")
Cc: stable@dpdk.org
Reported-by: Michael Luo <michael.luo@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index dca61f03a..8191a6a73 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -10830,6 +10830,7 @@ i40e_start_timecounters(struct rte_eth_dev *dev)
switch (link.link_speed) {
case ETH_SPEED_NUM_40G:
+ case ETH_SPEED_NUM_25G:
tsync_inc_l = I40E_PTP_40GB_INCVAL & 0xFFFFFFFF;
tsync_inc_h = I40E_PTP_40GB_INCVAL >> 32;
break;
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: fix time sync for 25G
2019-03-11 7:42 [dpdk-dev] [PATCH] net/i40e: fix time sync for 25G Qi Zhang
@ 2019-03-12 1:21 ` Luo, Michael
2019-03-12 3:11 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Luo, Michael @ 2019-03-12 1:21 UTC (permalink / raw)
To: Zhang, Qi Z, dev; +Cc: stable
Verified the patch on DPDK 18.11.
Best regards,
Michael
-----Original Message-----
From: Zhang, Qi Z
Sent: Monday, March 11, 2019 3:42 PM
To: dev@dpdk.org
Cc: Luo, Michael <michael.luo@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
Subject: [PATCH] net/i40e: fix time sync for 25G
Time sync increment value is not configured for 25G device.
The patch fix this issue by setting the same value as 40G, this aligned with kernel driver's behaviour.
Fixes: 75d133dd3296 ("net/i40e: enable 25G device")
Cc: stable@dpdk.org
Reported-by: Michael Luo <michael.luo@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index dca61f03a..8191a6a73 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -10830,6 +10830,7 @@ i40e_start_timecounters(struct rte_eth_dev *dev)
switch (link.link_speed) {
case ETH_SPEED_NUM_40G:
+ case ETH_SPEED_NUM_25G:
tsync_inc_l = I40E_PTP_40GB_INCVAL & 0xFFFFFFFF;
tsync_inc_h = I40E_PTP_40GB_INCVAL >> 32;
break;
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: fix time sync for 25G
2019-03-12 1:21 ` Luo, Michael
@ 2019-03-12 3:11 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2019-03-12 3:11 UTC (permalink / raw)
To: Luo, Michael, dev; +Cc: stable
> -----Original Message-----
> From: Luo, Michael
> Sent: Tuesday, March 12, 2019 9:21 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] net/i40e: fix time sync for 25G
>
> Verified the patch on DPDK 18.11.
>
> Best regards,
> Michael
>
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Monday, March 11, 2019 3:42 PM
> To: dev@dpdk.org
> Cc: Luo, Michael <michael.luo@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] net/i40e: fix time sync for 25G
>
> Time sync increment value is not configured for 25G device.
>
> The patch fix this issue by setting the same value as 40G, this aligned with kernel
> driver's behaviour.
>
> Fixes: 75d133dd3296 ("net/i40e: enable 25G device")
> Cc: stable@dpdk.org
>
> Reported-by: Michael Luo <michael.luo@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-12 3:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 7:42 [dpdk-dev] [PATCH] net/i40e: fix time sync for 25G Qi Zhang
2019-03-12 1:21 ` Luo, Michael
2019-03-12 3:11 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).