From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 670974C93 for ; Tue, 12 Mar 2019 18:42:43 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id m2so2368503pgl.5 for ; Tue, 12 Mar 2019 10:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dRybNXI81ovP4t/Df4RUwV7BiNGbhBVnR/OvnE1H/eo=; b=oT26RI7cSzuxnrKcOH2RxDen030z9gwv3gBi1wTa7/Sp+0g6Pi9HpLtOd3gXvaEig/ BnrnZqJTUs+QoKdm17sapcP1XWOXcJ8JqrTEYSz/22y8L0itwhqy+iM7tyZGFQAFAorg ldvdrh57qntZ557lO/SzsIoXYMboFC+aIzxmDJGBBCd7bcoPRBATDfRtTpChzLO6ihGi 4eAmcmjcptgrRhkrKM1g1Aqpco4Je3eDzbuWAybfLyQb26rferW6sqXig6j4g1On1cl3 a7l8n0Fnck2hES772DVSAf459RcMTobTLV1YR8mPsihMuL/O8MT4cRBXUmXJnua9FpO5 bS4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dRybNXI81ovP4t/Df4RUwV7BiNGbhBVnR/OvnE1H/eo=; b=LC4yxekV7si5pbOFcrlFrLtxlkdpVt55XrLhtPNFlAH4NclnXFSwAdMf5dh456jk20 edam2iF3kw+IPa+4ny4cgv3DmXXkzrL4VKlFgLvJs5XMsmhEdTR8LOobOSygWroWWeEz 3ix+3vqWflChM6JVa6+BdGqdCwvhmSIWFkUNS7AMNpZga4pOukZe48YYM+TBqCs1I1I7 VIekwxJz7ja5rmhHChtItweIVJEYZcf+H13P/3xMyeAr8hfXdQy5M/Rgftn8hFHdailz 5GGx2JJw6RRoCT9V4IQmdkEqjgGMZNwqGVxEvKSjskyP0SUai/AHl86KKgZwFUikDbZF adFw== X-Gm-Message-State: APjAAAXOkHADaQSjvpIw3TfJBhJ0zpCW4ykk76sWb25tLIEH6m0DDw5h WNay8ULv0woqCQ7uZx2AhMBFGA== X-Google-Smtp-Source: APXvYqxGvAOp8L+/XeveLo/lPLoHKhZdBCqAA8lWx7nRDLKFylaQsUGMDvMEtUM97ZmSmdswMUEZwQ== X-Received: by 2002:a65:63c1:: with SMTP id n1mr35763958pgv.339.1552412562419; Tue, 12 Mar 2019 10:42:42 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a1sm13875039pfn.26.2019.03.12.10.42.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 10:42:42 -0700 (PDT) Date: Tue, 12 Mar 2019 10:42:39 -0700 From: Stephen Hemminger To: Tiwei Bie Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org Message-ID: <20190312104239.02f87774@shemminger-XPS-13-9360> In-Reply-To: <20190312071307.19393-1-tiwei.bie@intel.com> References: <20190312071307.19393-1-tiwei.bie@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix multiqueue support with vhost kernel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2019 17:42:43 -0000 On Tue, 12 Mar 2019 15:13:07 +0800 Tiwei Bie wrote: > The multiqueue support in virtio-user with vhost kernel backend > is broken when tap name isn't specified by users explicitly, > because the tap name returned by ioctl(TUNSETIFF) isn't saved > properly, and multiple tap interfaces will be created in this > case. Fix this by saving the dynamically allocated tap name > first before reusing the ifr structure. Besides, also make it > possible to support the format string in tap name (e.g. foo%d) > specified by users explicitly. > > Fixes: 791b43e08842 ("net/virtio-user: specify MAC of the tap") > Cc: stable@dpdk.org > > Reported-by: Stephen Hemminger > Signed-off-by: Tiwei Bie Reviewed-by: Stephen Hemminger Does this have any impact on primary/secondary support?