* [dpdk-dev] [PATCH] net/octeontx: fix vdev name
@ 2019-03-12 19:27 Stephen Hemminger
2019-03-13 19:35 ` Rami Rosen
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2019-03-12 19:27 UTC (permalink / raw)
To: jerinj; +Cc: dev, Stephen Hemminger
The octeontx driver is creating vdev with name "OCTEONTX_PMD"
which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
work.
Change to use the same convention as all the other network
driverse ("net_octeontx").
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/octeontx/octeontx_ethdev.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/octeontx/octeontx_ethdev.h b/drivers/net/octeontx/octeontx_ethdev.h
index 920f6f89b882..f21652c9a6c8 100644
--- a/drivers/net/octeontx/octeontx_ethdev.h
+++ b/drivers/net/octeontx/octeontx_ethdev.h
@@ -21,6 +21,7 @@
#include "base/octeontx_pkovf.h"
#include "base/octeontx_io.h"
+#define OCTEONTX_PMD net_octeon
#define OCTEONTX_VDEV_DEFAULT_MAX_NR_PORT 12
#define OCTEONTX_VDEV_NR_PORT_ARG ("nr_port")
#define OCTEONTX_MAX_NAME_LEN 32
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/octeontx: fix vdev name
2019-03-12 19:27 [dpdk-dev] [PATCH] net/octeontx: fix vdev name Stephen Hemminger
@ 2019-03-13 19:35 ` Rami Rosen
2019-03-13 19:35 ` Rami Rosen
0 siblings, 1 reply; 3+ messages in thread
From: Rami Rosen @ 2019-03-13 19:35 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: jerinj, dev
> The octeontx driver is creating vdev with name "OCTEONTX_PMD"
> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
> work.
>
> Change to use the same convention as all the other network
> driverse ("net_octeontx").
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>
1. Actuaully in the patch itself it is:
+#define OCTEONTX_PMD net_octeon
Shouldn't it be "net_octeontx" as in the commit log ?
2. Typo in commit log: driverse->drivers
Reviewed-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/octeontx: fix vdev name
2019-03-13 19:35 ` Rami Rosen
@ 2019-03-13 19:35 ` Rami Rosen
0 siblings, 0 replies; 3+ messages in thread
From: Rami Rosen @ 2019-03-13 19:35 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: jerinj, dev
> The octeontx driver is creating vdev with name "OCTEONTX_PMD"
> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
> work.
>
> Change to use the same convention as all the other network
> driverse ("net_octeontx").
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>
1. Actuaully in the patch itself it is:
+#define OCTEONTX_PMD net_octeon
Shouldn't it be "net_octeontx" as in the commit log ?
2. Typo in commit log: driverse->drivers
Reviewed-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-13 19:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-12 19:27 [dpdk-dev] [PATCH] net/octeontx: fix vdev name Stephen Hemminger
2019-03-13 19:35 ` Rami Rosen
2019-03-13 19:35 ` Rami Rosen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).