From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3631F3572; Wed, 13 Mar 2019 07:15:03 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2019 23:15:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,473,1544515200"; d="scan'208";a="154532892" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by fmsmga001.fm.intel.com with ESMTP; 12 Mar 2019 23:15:01 -0700 Date: Wed, 13 Mar 2019 14:14:51 +0800 From: Tiwei Bie To: Stephen Hemminger Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org Message-ID: <20190313061451.GA8654@dpdk-tbie.sh.intel.com> References: <20190312071307.19393-1-tiwei.bie@intel.com> <20190312104239.02f87774@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190312104239.02f87774@shemminger-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix multiqueue support with vhost kernel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 06:15:04 -0000 On Tue, Mar 12, 2019 at 10:42:39AM -0700, Stephen Hemminger wrote: > On Tue, 12 Mar 2019 15:13:07 +0800 > Tiwei Bie wrote: > > > The multiqueue support in virtio-user with vhost kernel backend > > is broken when tap name isn't specified by users explicitly, > > because the tap name returned by ioctl(TUNSETIFF) isn't saved > > properly, and multiple tap interfaces will be created in this > > case. Fix this by saving the dynamically allocated tap name > > first before reusing the ifr structure. Besides, also make it > > possible to support the format string in tap name (e.g. foo%d) > > specified by users explicitly. > > > > Fixes: 791b43e08842 ("net/virtio-user: specify MAC of the tap") > > Cc: stable@dpdk.org > > > > Reported-by: Stephen Hemminger > > Signed-off-by: Tiwei Bie > > Reviewed-by: Stephen Hemminger > > Does this have any impact on primary/secondary support? No. But I think there are some other issues with virtio-user on primary/secondary support currently. I plan to send some fixes for it later. Thanks, Tiwei