From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] examples/ethtool: allocate only one mempool
Date: Wed, 13 Mar 2019 10:34:52 +0000 [thread overview]
Message-ID: <20190313103452.GB1118972@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190313100910.31260-3-thomas@monjalon.net>
On Wed, Mar 13, 2019 at 11:09:10AM +0100, Thomas Monjalon wrote:
> No need to allocate one mempool per port.
> The number of mbufs is fixed for simplicity.
>
While it's simpler to use a fixed number of mbufs, having a fixed number
of mbufs multiplied by the number of ports is safer IMHO, and not really that
much more complicated.
Otherwise, fully agree with the principle of the change.
/Bruce
prev parent reply other threads:[~2019-03-13 10:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 10:09 [dpdk-dev] [PATCH 0/2] examples/ethtool: remove useless device info query Thomas Monjalon
2019-03-13 10:09 ` [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config Thomas Monjalon
2019-03-13 10:32 ` Bruce Richardson
2019-03-13 17:41 ` Rami Rosen
2019-03-20 13:46 ` Ferruh Yigit
2019-03-20 13:46 ` Ferruh Yigit
2019-03-20 13:51 ` Thomas Monjalon
2019-03-20 13:51 ` Thomas Monjalon
2019-03-20 13:56 ` Ferruh Yigit
2019-03-20 13:56 ` Ferruh Yigit
2019-03-20 14:05 ` Thomas Monjalon
2019-03-20 14:05 ` Thomas Monjalon
2019-03-13 10:09 ` [dpdk-dev] [PATCH 2/2] examples/ethtool: allocate only one mempool Thomas Monjalon
2019-03-13 10:34 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313103452.GB1118972@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).