From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/4] build: use version number from config file
Date: Wed, 13 Mar 2019 11:20:34 +0000 [thread overview]
Message-ID: <20190313112034.GD1118972@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <2333456.BDb5ShVbCQ@xps>
On Wed, Mar 13, 2019 at 12:13:52PM +0100, Thomas Monjalon wrote:
> 07/03/2019 14:35, Bruce Richardson:
> > +#
> > +# Version information completed when this file is processed for a build
> > +#
> > +CONFIG_RTE_VER_YEAR=__YEAR
> > +CONFIG_RTE_VER_MONTH=__MONTH
> > +CONFIG_RTE_VER_MINOR=__MINOR
> > +CONFIG_RTE_VER_SUFFIX=__SUFFIX
> > +CONFIG_RTE_VER_RELEASE=__RELEASE
> [...]
> > -/**
> > - * Patch release number
> > - * 0-15 = release candidates
> > - * 16 = release
> > - */
> > -#define RTE_VER_RELEASE 0
>
> So you are removing the special value 16.
> Is it replaced by an empty value?
>
> I think it is an issue for version comparison with RTE_VERSION_NUM() macro.
> The -rc3 must be lower than the final release (which had number 16
> for this reason).
>
Aha, that explains the reason for the 16 value. I did wonder why we
bothered with it when it wasn't actually used in printing etc. Let me go
back and look into this set again, armed with this new info. [We also need
to document this reason in the code comments for future information]
next prev parent reply other threads:[~2019-03-13 11:20 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 11:54 [dpdk-dev] [RFC PATCH 0/4] One versionfile to rule them all Bruce Richardson
2019-03-07 11:54 ` [dpdk-dev] [PATCH 1/4] build: add single source of DPDK version number Bruce Richardson
2019-03-07 12:33 ` David Marchand
2019-03-07 11:54 ` [dpdk-dev] [PATCH 2/4] build: use version number from config file Bruce Richardson
2019-03-07 12:37 ` David Marchand
2019-03-07 12:42 ` David Marchand
2019-03-07 13:12 ` Bruce Richardson
2019-03-07 13:01 ` Bruce Richardson
2019-03-07 11:54 ` [dpdk-dev] [PATCH 3/4] build: move meson version handling to config directory Bruce Richardson
2019-03-07 11:54 ` [dpdk-dev] [PATCH 4/4] eal: remove unneeded version logic Bruce Richardson
2019-03-07 12:09 ` [dpdk-dev] [RFC PATCH 0/4] One versionfile to rule them all Luca Boccassi
2019-03-07 12:14 ` Bruce Richardson
2019-03-07 13:34 ` [dpdk-dev] [PATCH v2 " Bruce Richardson
2019-03-07 13:34 ` [dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number Bruce Richardson
2019-03-13 11:06 ` Thomas Monjalon
2019-03-13 11:17 ` Bruce Richardson
2019-03-13 11:23 ` Thomas Monjalon
2019-03-13 11:27 ` Bruce Richardson
2019-03-07 13:35 ` [dpdk-dev] [PATCH v2 2/4] build: use version number from config file Bruce Richardson
2019-03-13 11:13 ` Thomas Monjalon
2019-03-13 11:20 ` Bruce Richardson [this message]
2019-03-13 11:24 ` Thomas Monjalon
2019-03-07 13:35 ` [dpdk-dev] [PATCH v2 3/4] build: move meson version handling to config directory Bruce Richardson
2019-03-07 13:35 ` [dpdk-dev] [PATCH v2 4/4] eal: remove unneeded version logic Bruce Richardson
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 0/4] One versionfile to rule them all Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 1/4] build: add single source of DPDK version number Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-16 18:01 ` Rami Rosen
2019-03-16 18:01 ` Rami Rosen
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 2/4] build: move meson version handling to config directory Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 3/4] build: use version number from config file Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-27 0:27 ` Thomas Monjalon
2019-03-27 0:27 ` Thomas Monjalon
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 4/4] eal: remove unneeded version logic Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-27 0:34 ` [dpdk-dev] [PATCH v3 0/4] One versionfile to rule them all Thomas Monjalon
2019-03-27 0:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313112034.GD1118972@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).