From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id ACCDA568A for ; Wed, 13 Mar 2019 12:20:38 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2019 04:20:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,474,1544515200"; d="scan'208";a="151290385" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36]) by fmsmga002.fm.intel.com with SMTP; 13 Mar 2019 04:20:35 -0700 Received: by (sSMTP sendmail emulation); Wed, 13 Mar 2019 11:20:35 +0000 Date: Wed, 13 Mar 2019 11:20:34 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, David Marchand , Luca Boccassi Message-ID: <20190313112034.GD1118972@bricha3-MOBL.ger.corp.intel.com> References: <20190307115448.54041-1-bruce.richardson@intel.com> <20190307133502.55321-1-bruce.richardson@intel.com> <20190307133502.55321-3-bruce.richardson@intel.com> <2333456.BDb5ShVbCQ@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2333456.BDb5ShVbCQ@xps> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v2 2/4] build: use version number from config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 11:20:39 -0000 On Wed, Mar 13, 2019 at 12:13:52PM +0100, Thomas Monjalon wrote: > 07/03/2019 14:35, Bruce Richardson: > > +# > > +# Version information completed when this file is processed for a build > > +# > > +CONFIG_RTE_VER_YEAR=__YEAR > > +CONFIG_RTE_VER_MONTH=__MONTH > > +CONFIG_RTE_VER_MINOR=__MINOR > > +CONFIG_RTE_VER_SUFFIX=__SUFFIX > > +CONFIG_RTE_VER_RELEASE=__RELEASE > [...] > > -/** > > - * Patch release number > > - * 0-15 = release candidates > > - * 16 = release > > - */ > > -#define RTE_VER_RELEASE 0 > > So you are removing the special value 16. > Is it replaced by an empty value? > > I think it is an issue for version comparison with RTE_VERSION_NUM() macro. > The -rc3 must be lower than the final release (which had number 16 > for this reason). > Aha, that explains the reason for the 16 value. I did wonder why we bothered with it when it wasn't actually used in printing etc. Let me go back and look into this set again, armed with this new info. [We also need to document this reason in the code comments for future information]