From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 5D6DA37B0 for ; Wed, 13 Mar 2019 12:27:54 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2019 04:27:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,474,1544515200"; d="scan'208";a="151292127" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36]) by fmsmga002.fm.intel.com with SMTP; 13 Mar 2019 04:27:51 -0700 Received: by (sSMTP sendmail emulation); Wed, 13 Mar 2019 11:27:50 +0000 Date: Wed, 13 Mar 2019 11:27:49 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, David Marchand , Luca Boccassi Message-ID: <20190313112749.GE1118972@bricha3-MOBL.ger.corp.intel.com> References: <20190307115448.54041-1-bruce.richardson@intel.com> <6766221.dD9Uvtf5Qj@xps> <20190313111759.GC1118972@bricha3-MOBL.ger.corp.intel.com> <3536683.yvjcJTvx62@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3536683.yvjcJTvx62@xps> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 11:27:54 -0000 On Wed, Mar 13, 2019 at 12:23:16PM +0100, Thomas Monjalon wrote: > 13/03/2019 12:17, Bruce Richardson: > > On Wed, Mar 13, 2019 at 12:06:38PM +0100, Thomas Monjalon wrote: > > > 07/03/2019 14:34, Bruce Richardson: > > > > Add a new file DPDK_VERSION to hold the current DPDK version number. > > > > Have meson use this file for it's project version, and have make use > > > > it for reporting out "showversion" and "showversionum". > > > > > > > > Signed-off-by: Bruce Richardson > > > > Acked-by: Luca Boccassi > > > [...] > > > > --- /dev/null > > > > +++ b/DPDK_VERSION > > > > > > Why not VERSION ? > > > > > > > No particular reason. I just picked a name I thought reasonable, but I'm > > fine with just VERSION on its own. > > > > The one advantage of having DPDK in the title is that if one has a clone to > > a directory called e.g. "temp", a quick "ls" will show the forgetful what > > product it was that they cloned to a directory with such an unhelpful name. > > Good try of justification :) > Worth a shot! :-) > I think I prefer just VERSION. > Ok, will change in V2. > > > [...] > > > > --- a/mk/rte.sdkconfig.mk > > > > +++ b/mk/rte.sdkconfig.mk > > > > showversion: > > > > - @set -- \ > > > > - $$(sed -rne 's,^#define RTE_VER_[A-Z_]*[[:space:]]+([0-9]+).*,\1,p' \ > > > > - -e 's,^#define RTE_VER_SUFFIX[[:space:]]+"(.*)",\1,p' \ > > > > - $(RTE_SRCDIR)/lib/librte_eal/common/include/rte_version.h) ;\ > > > > - printf '%d.%02d.%d' "$$1" "$$2" "$$3"; \ > > > > - if [ -z "$$5" ]; then echo; \ > > > > - else printf '%s' "$$4"; \ > > > > - if [ $$5 -lt 16 ] ; then echo $$5; \ > > > > - else echo $$(($$5 - 16)); fi; \ > > > > - fi > > > > + @cat $(RTE_SRCDIR)/DPDK_VERSION > > > > > > I'm a bit sad about removing this complex command ;) > > > > > Yes, but don't worry, I'm proposing a bit of an addition of sed and awk > > to other makefile commands to compensate, though sadly not quite as > > unintelligable to the masses as this. :-) > > I can teach you :) > Thanks, but I think I'll pass on that opportunity! :-)