From: Bruce Richardson <bruce.richardson@intel.com>
To: thomas@monjalon.net, ferruh.yigit@intel.com,
jerin.jacob@caviumnetworks.com
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH] devtools: fix invalid config check when building tags
Date: Wed, 13 Mar 2019 15:09:58 +0000 [thread overview]
Message-ID: <20190313150958.22581-1-bruce.richardson@intel.com> (raw)
The check for a valid configuration in build-tags.sh relied on the output
of "make showconfig" rather than checking directly for a config file of
that name. This broke when as part of the rename of the linuxapp/bsdapp
configs to just linux/freebsd, as we stopped advertising the old names
even if they worked. Changing the code to just look for the config
file by name fixes this issue while shortening the code too.
Fixes: 218c4e68c1d9 ("mk: use linux and freebsd in config names")
Fixes: aafaea3d3b70 ("devtools: add tags and cscope index generation")
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
devtools/build-tags.sh | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
index 753e4c23c..d395da47e 100755
--- a/devtools/build-tags.sh
+++ b/devtools/build-tags.sh
@@ -129,14 +129,7 @@ ppc_64_sources()
check_valid_target()
{
- cfgfound=false
- allconfigs=$(make showconfigs)
- for cfg in $allconfigs ; do
- if [ "$cfg" = "$1" ] ; then
- cfgfound=true
- fi
- done
- if ! $cfgfound ; then
+ if [ ! -f "config/defconfig_$1" ] ; then
echo "Invalid config: $1"
print_usage
exit 0
--
2.20.1
next reply other threads:[~2019-03-13 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 15:09 Bruce Richardson [this message]
2019-03-13 15:16 ` Ferruh Yigit
2019-03-14 20:40 ` Jerin Jacob Kollanukkaran
2019-03-14 20:40 ` Jerin Jacob Kollanukkaran
2019-03-26 23:57 ` Thomas Monjalon
2019-03-26 23:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313150958.22581-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).