From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 97835374E for ; Wed, 13 Mar 2019 16:10:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2019 08:10:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,474,1544515200"; d="scan'208";a="306876162" Received: from silpixa00399126.ir.intel.com (HELO silpixa00399126.ger.corp.intel.com) ([10.237.222.236]) by orsmga005.jf.intel.com with ESMTP; 13 Mar 2019 08:10:07 -0700 From: Bruce Richardson To: thomas@monjalon.net, ferruh.yigit@intel.com, jerin.jacob@caviumnetworks.com Cc: dev@dpdk.org, Bruce Richardson Date: Wed, 13 Mar 2019 15:09:58 +0000 Message-Id: <20190313150958.22581-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] devtools: fix invalid config check when building tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 15:10:14 -0000 The check for a valid configuration in build-tags.sh relied on the output of "make showconfig" rather than checking directly for a config file of that name. This broke when as part of the rename of the linuxapp/bsdapp configs to just linux/freebsd, as we stopped advertising the old names even if they worked. Changing the code to just look for the config file by name fixes this issue while shortening the code too. Fixes: 218c4e68c1d9 ("mk: use linux and freebsd in config names") Fixes: aafaea3d3b70 ("devtools: add tags and cscope index generation") Signed-off-by: Bruce Richardson --- devtools/build-tags.sh | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh index 753e4c23c..d395da47e 100755 --- a/devtools/build-tags.sh +++ b/devtools/build-tags.sh @@ -129,14 +129,7 @@ ppc_64_sources() check_valid_target() { - cfgfound=false - allconfigs=$(make showconfigs) - for cfg in $allconfigs ; do - if [ "$cfg" = "$1" ] ; then - cfgfound=true - fi - done - if ! $cfgfound ; then + if [ ! -f "config/defconfig_$1" ] ; then echo "Invalid config: $1" print_usage exit 0 -- 2.20.1