From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 5ABA74C95 for <dev@dpdk.org>; Wed, 13 Mar 2019 16:11:10 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2019 08:11:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,474,1544515200"; d="scan'208";a="154663834" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36]) by fmsmga001.fm.intel.com with SMTP; 13 Mar 2019 08:11:07 -0700 Received: by (sSMTP sendmail emulation); Wed, 13 Mar 2019 15:11:06 +0000 Date: Wed, 13 Mar 2019 15:11:06 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org Message-ID: <20190313151105.GB1175472@bricha3-MOBL.ger.corp.intel.com> References: <20190306162242.65375-1-bruce.richardson@intel.com> <19421689.NtES9yoMkj@xps> <af1c590b-fed6-be0e-c8c7-b2169fee3d18@intel.com> <2347388.E9kf87BXsl@xps> <851ec589-621b-c31e-7198-cd3b9e5ddd68@intel.com> <20190313150257.GA1175472@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190313150257.GA1175472@bricha3-MOBL.ger.corp.intel.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 13 Mar 2019 15:11:12 -0000 On Wed, Mar 13, 2019 at 03:02:57PM +0000, Bruce Richardson wrote: > On Wed, Mar 13, 2019 at 02:21:31PM +0000, Ferruh Yigit wrote: > > On 3/13/2019 1:59 PM, Thomas Monjalon wrote: > > > 13/03/2019 14:41, Ferruh Yigit: > > >> On 3/12/2019 10:13 PM, Thomas Monjalon wrote: > > >>>> Bruce Richardson (6): > > >>>> eal/bsdapp: rename to freebsd > > >>>> eal/linuxapp: rename to linux > > >>>> build/linux: rename macro from LINUXAPP to LINUX > > >>>> build/freebsd: rename macro from BSDPAPP to FREEBSD > > >>>> build/meson: change linuxapp to linux in meson cross files > > >>>> build: allow linux and freebsd in build configs > > >>> > > >>> Applied, thanks > > >> > > >> This has potential to break some automation/scripts since changes the names of > > >> the config files: > > >> 'make T=x86_64-native-linuxapp-gcc config' becomes > > >> 'make T=x86_64-native-linux-gcc config' etc... > > >> > > >> I suggest highlighting this change in release notes! > > > > > > No, the old names should still work. > > > Otherwise, it would be an API breakage, which is very bad! > > > > > > > Ah, right config is working, how I hit this is: > > > > $ make T=x86_64-native-linuxapp-gcc cscope > > Invalid config: x86_64-native-linuxapp-gcc > > > > 'cscope' (and friends) also should be covered ... > > Ok, the root cause of this is that even though the build-tags function does > not use the config, it checks if the config parameter passed in is a valid > one by running "make showconfig". This I changed to filter out the old > configs so they are not advertised any more - though they still work - > which causes build-tags to assume that the config is invalid. > > I therefore suggest we fix this by changing the check for a valid config to > check if there is a defconfig_ file with the same name rather than asking > showconfig. > http://patches.dpdk.org/patch/51155/ Please review. Thanks, /Bruce