From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names
Date: Wed, 13 Mar 2019 15:20:39 +0000 [thread overview]
Message-ID: <20190313152039.GA1200752@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <aaa4cc0b-4431-87d8-8add-2ac7ae986f92@intel.com>
On Wed, Mar 13, 2019 at 03:14:27PM +0000, Ferruh Yigit wrote:
> On 3/13/2019 2:43 PM, Bruce Richardson wrote:
> > On Wed, Mar 13, 2019 at 02:21:31PM +0000, Ferruh Yigit wrote:
> >> On 3/13/2019 1:59 PM, Thomas Monjalon wrote:
> >>> 13/03/2019 14:41, Ferruh Yigit:
> >>>> On 3/12/2019 10:13 PM, Thomas Monjalon wrote:
> >>>>>> Bruce Richardson (6):
> >>>>>> eal/bsdapp: rename to freebsd
> >>>>>> eal/linuxapp: rename to linux
> >>>>>> build/linux: rename macro from LINUXAPP to LINUX
> >>>>>> build/freebsd: rename macro from BSDPAPP to FREEBSD
> >>>>>> build/meson: change linuxapp to linux in meson cross files
> >>>>>> build: allow linux and freebsd in build configs
> >>>>>
> >>>>> Applied, thanks
> >>>>
> >>>> This has potential to break some automation/scripts since changes the names of
> >>>> the config files:
> >>>> 'make T=x86_64-native-linuxapp-gcc config' becomes
> >>>> 'make T=x86_64-native-linux-gcc config' etc...
> >>>>
> >>>> I suggest highlighting this change in release notes!
> >>>
> >>> No, the old names should still work.
> >>> Otherwise, it would be an API breakage, which is very bad!
> >>>
> >>
> >> Ah, right config is working, how I hit this is:
> >>
> >> $ make T=x86_64-native-linuxapp-gcc cscope
> >> Invalid config: x86_64-native-linuxapp-gcc
> >>
> >> 'cscope' (and friends) also should be covered ...
> >
> > Strange, because the new configs are just symlinks to the old. I'll need to
> > investigate how cscope and friends use the config.
>
> Are we allowed to use symlinks J Will they play nice on windows?
They'll work well enough. Plus it's only for the old build system, so will
go away in the future.
next prev parent reply other threads:[~2019-03-13 15:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 16:22 Bruce Richardson
2019-03-06 16:22 ` [dpdk-dev] [PATCH 1/6] eal/bsdapp: rename to freebsd Bruce Richardson
2019-03-06 16:22 ` [dpdk-dev] [PATCH 2/6] eal/linuxapp: rename to linux Bruce Richardson
2019-03-06 16:22 ` [dpdk-dev] [PATCH 3/6] build/linux: rename macro from LINUXAPP to LINUX Bruce Richardson
2019-03-06 16:22 ` [dpdk-dev] [PATCH 4/6] build/freebsd: rename macro from BSDPAPP to FREEBSD Bruce Richardson
2019-03-06 16:22 ` [dpdk-dev] [PATCH 5/6] build/meson: change linuxapp to linux in meson cross files Bruce Richardson
2019-03-06 16:22 ` [dpdk-dev] [PATCH 6/6] build: allow linux and freebsd in build configs Bruce Richardson
2019-03-09 0:57 ` [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names Thomas Monjalon
2019-03-12 22:13 ` Thomas Monjalon
2019-03-13 13:41 ` Ferruh Yigit
2019-03-13 13:59 ` Thomas Monjalon
2019-03-13 14:21 ` Ferruh Yigit
2019-03-13 14:43 ` Bruce Richardson
2019-03-13 15:14 ` Ferruh Yigit
2019-03-13 15:20 ` Bruce Richardson [this message]
2019-03-13 15:02 ` Bruce Richardson
2019-03-13 15:11 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313152039.GA1200752@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).