From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BBC45374E for ; Wed, 13 Mar 2019 16:20:45 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2019 08:20:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,474,1544515200"; d="scan'208";a="328262630" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36]) by fmsmga005.fm.intel.com with SMTP; 13 Mar 2019 08:20:43 -0700 Received: by (sSMTP sendmail emulation); Wed, 13 Mar 2019 15:20:40 +0000 Date: Wed, 13 Mar 2019 15:20:39 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org Message-ID: <20190313152039.GA1200752@bricha3-MOBL.ger.corp.intel.com> References: <20190306162242.65375-1-bruce.richardson@intel.com> <19421689.NtES9yoMkj@xps> <2347388.E9kf87BXsl@xps> <851ec589-621b-c31e-7198-cd3b9e5ddd68@intel.com> <20190313144310.GA1169924@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 15:20:46 -0000 On Wed, Mar 13, 2019 at 03:14:27PM +0000, Ferruh Yigit wrote: > On 3/13/2019 2:43 PM, Bruce Richardson wrote: > > On Wed, Mar 13, 2019 at 02:21:31PM +0000, Ferruh Yigit wrote: > >> On 3/13/2019 1:59 PM, Thomas Monjalon wrote: > >>> 13/03/2019 14:41, Ferruh Yigit: > >>>> On 3/12/2019 10:13 PM, Thomas Monjalon wrote: > >>>>>> Bruce Richardson (6): > >>>>>> eal/bsdapp: rename to freebsd > >>>>>> eal/linuxapp: rename to linux > >>>>>> build/linux: rename macro from LINUXAPP to LINUX > >>>>>> build/freebsd: rename macro from BSDPAPP to FREEBSD > >>>>>> build/meson: change linuxapp to linux in meson cross files > >>>>>> build: allow linux and freebsd in build configs > >>>>> > >>>>> Applied, thanks > >>>> > >>>> This has potential to break some automation/scripts since changes the names of > >>>> the config files: > >>>> 'make T=x86_64-native-linuxapp-gcc config' becomes > >>>> 'make T=x86_64-native-linux-gcc config' etc... > >>>> > >>>> I suggest highlighting this change in release notes! > >>> > >>> No, the old names should still work. > >>> Otherwise, it would be an API breakage, which is very bad! > >>> > >> > >> Ah, right config is working, how I hit this is: > >> > >> $ make T=x86_64-native-linuxapp-gcc cscope > >> Invalid config: x86_64-native-linuxapp-gcc > >> > >> 'cscope' (and friends) also should be covered ... > > > > Strange, because the new configs are just symlinks to the old. I'll need to > > investigate how cscope and friends use the config. > > Are we allowed to use symlinks J Will they play nice on windows? They'll work well enough. Plus it's only for the old build system, so will go away in the future.