From: Rami Rosen <ramirose@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: jerinj@marvell.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/octeontx: fix vdev name
Date: Wed, 13 Mar 2019 21:35:41 +0200 [thread overview]
Message-ID: <CAHLOa7RQHKbUrgcg7vtjd90XUKh+_tR+03gD4Y4TU2gZw94nHg@mail.gmail.com> (raw)
Message-ID: <20190313193541.r6CA4T3qx3Pm04mrbovadI2vTz2O1w4ZAeIe-rC6mJs@z> (raw)
In-Reply-To: <20190312192703.18554-1-stephen@networkplumber.org>
> The octeontx driver is creating vdev with name "OCTEONTX_PMD"
> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
> work.
>
> Change to use the same convention as all the other network
> driverse ("net_octeontx").
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>
1. Actuaully in the patch itself it is:
+#define OCTEONTX_PMD net_octeon
Shouldn't it be "net_octeontx" as in the commit log ?
2. Typo in commit log: driverse->drivers
Reviewed-by: Rami Rosen <ramirose@gmail.com>
next prev parent reply other threads:[~2019-03-13 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 19:27 Stephen Hemminger
2019-03-13 19:35 ` Rami Rosen [this message]
2019-03-13 19:35 ` Rami Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLOa7RQHKbUrgcg7vtjd90XUKh+_tR+03gD4Y4TU2gZw94nHg@mail.gmail.com \
--to=ramirose@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).