DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix packet inline on Tx queue wraparound
Date: Thu, 14 Mar 2019 09:08:57 +0000	[thread overview]
Message-ID: <AM0PR0502MB3795764322B88A4905542DC4C34B0@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
Message-ID: <20190314090857.H_xC4xrjdaitOVkD37l8EDQOS46hN_2t7PDrsrxOLlM@z> (raw)
In-Reply-To: <44AC735D-DF85-4883-A612-979D6D6DD59C@mellanox.com>

Monday, March 11, 2019 9:58 PM, Yongseok Koh:
> Subject: Re: [PATCH] net/mlx5: fix packet inline on Tx queue wraparound
> 
> 
> > On Mar 10, 2019, at 12:14 AM, Shahaf Shuler <shahafs@mellanox.com>
> wrote:
> >
> > Inlining a packet to WQE that cross the WQ wraparound, i.e. the WQE
> > starts on the end of the ring and ends on the beginning, is not
> > supported and blocked by the data path logic.
> >
> > However, in case of TSO, an extra inline header is required before
> > inlining. This inline header is not taken into account when checking
> > if there is enough room left for the required inline size.
> > On some corner cases were
> > (ring_tailroom - inline header) < inline size < ring_tailroom , this
> > can lead to WQE being written outsize of the ring buffer.
> >
> > Fixing it by always assuming the worse case that inline of packet will
> > require the inline header.
> >
> > Fixes: 3f13f8c23a7c ("net/mlx5: support hardware TSO")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> > ---
> 
> Acked-by: Yongseok Koh <yskoh@mellanox.com>

Applied to next-net-mlx, thanks. 

  reply	other threads:[~2019-03-14  9:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-10  8:14 Shahaf Shuler
2019-03-11 19:58 ` Yongseok Koh
2019-03-14  9:08   ` Shahaf Shuler [this message]
2019-03-14  9:08     ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR0502MB3795764322B88A4905542DC4C34B0@AM0PR0502MB3795.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).