From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4B144A0096 for ; Thu, 14 Mar 2019 10:09:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 94BA63572; Thu, 14 Mar 2019 10:09:00 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70055.outbound.protection.outlook.com [40.107.7.55]) by dpdk.org (Postfix) with ESMTP id 53EBC324D; Thu, 14 Mar 2019 10:08:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=si+bX58AInroUF2/E0h0ADF460j4b55SO3KaF4Uc+ZQ=; b=um4kKyAYvIS/aGudiXVa38qvZaemjcaCmOhcII2KkI1PROQZGielT9lEN9SWWQtlPSArrMIWQjvRJVpkiG4Yp3pkBGeuQXpBm/Kd/aDk3gJbv3ocyKnWqpFjPzzBGoR8hwe9GkVZNRI1v+QIu0b3MAzvbc6Ba3hQ7nL2C2XNUu8= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB4034.eurprd05.prod.outlook.com (52.133.41.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.19; Thu, 14 Mar 2019 09:08:58 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003%2]) with mapi id 15.20.1709.011; Thu, 14 Mar 2019 09:08:58 +0000 From: Shahaf Shuler To: Yongseok Koh CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix packet inline on Tx queue wraparound Thread-Index: AQHU2ES8n5L9A+A3NkCjvCi4rZBsEqYK2nEQ Date: Thu, 14 Mar 2019 09:08:57 +0000 Message-ID: References: <20190310081410.94830-1-shahafs@mellanox.com> <44AC735D-DF85-4883-A612-979D6D6DD59C@mellanox.com> In-Reply-To: <44AC735D-DF85-4883-A612-979D6D6DD59C@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1a652a2a-9b95-47f3-8a01-08d6a85cb11b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR0502MB4034; x-ms-traffictypediagnostic: AM0PR0502MB4034: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; AM0PR0502MB4034; 23:HYR76sFVGrSmqT17pPmeM1JaeRwifcA7K27jK+N?= =?us-ascii?Q?hTYLvBohGT9VqBT+oIh5cMpSHvBt2ibvbQFh6LxsAQ1xkgMQmeD6Zpq+cqQo?= =?us-ascii?Q?veBIyMmLl5Cccp1XdekkxVkUYlGaEC3Rk1QaPNqrRlo5GlnwRZoSrzXbMEs9?= =?us-ascii?Q?tvQ/DXFjzCUwhX+8OXlAhPqppUjqwKYzYapccUum6PiNe/EHGStmCi7GgHWA?= =?us-ascii?Q?334QTiQCBQD8UIQgLuYdNa0iNgq28LQTaO5kZvUyVXMSErggst2RM2DZEo5d?= =?us-ascii?Q?kpSfkxPX26TxanJ4VktvQHY5va81gGvmInfW0N7rilwC3psnG1TNlj6vFa28?= =?us-ascii?Q?2I9KvW7NKDZ/WZADL0FnFmW63Lk4dF+WmZcNeNx5yn5aRhOVH7fKmJ8EhEbn?= =?us-ascii?Q?qpu/udwY6cysYAxBHHCvlimwE3s+R11oq56wfvY6YLg+WezOSvLpnpIXXdIe?= =?us-ascii?Q?aFVN7clKgk6z6WX5OgWE4448y3hdLrmpbC+sXNWnPuTzXp9rFa0B4W5eCMRQ?= =?us-ascii?Q?qES+vSh+twuPcuymOXCHLwhDMqRerivGBo1ciaN2fR6n5s+ItBYfa0eCjxTg?= =?us-ascii?Q?eh49TEcKPFyroBOf8JteX4ioFypoV5WJ+ims4LKntCV6zLQSxYkgmQH4US7u?= =?us-ascii?Q?2ETRecHrY25ru3JL3joKCK46D9qLOxvGR3MrDydNV+0DOAXGeoAuZvHT1FlX?= =?us-ascii?Q?woJhn4Bi2YzjDRzdeSBQU0tWVCvdXNkmMLmx66NqrU1Tcb+GmYq1Ox2PCK8B?= =?us-ascii?Q?EAOTEFZojdMbXL+n8psW0Qw7+GtCM5/CAvyGHZRriFWUBsfPZcy0Dn1l/oyq?= =?us-ascii?Q?0OAAiZzyGMOEGmZn9T5YQoo44INuAEDABn2GCEt8z/IDLNAsLBik3YC48x6p?= =?us-ascii?Q?VsA483AIwXFwSK3Sj3XNNlpl28OdJH7KoKYRPcMVkigs5zSvq7TFZ1S0v9CN?= =?us-ascii?Q?deELjPORJ9Q6YTCWAoiFRVJ8N+Z0RsCaYrmFKLDUJlH90ootPEDRd+JskvBJ?= =?us-ascii?Q?tZablipD1AsaGsjHrU46kqWHVDUb4JLoN7R753h3ScpaiuebnFflSj5Q+tPj?= =?us-ascii?Q?rCJ6wTI4KaLarcI51yodx0YwGOe8q776Owpjklks4Imd+xizamWzgaKIE5MT?= =?us-ascii?Q?5ZyCN5tpxLUMbws8ETUPdMvYecethuh/O4tbTfv2PxiOuRtWHe+3HFomSDsS?= =?us-ascii?Q?INj9Mt6Lk5WQGTiMzw35quyWAK0WvwN7U3E+IfFExIncu7HIhPBoTOlMKX+b?= =?us-ascii?Q?2bQe4DEl1m1QpaODG83NJtV0dKuiB+VRgIOkpW8eXq69u8AkpJOirzg0X2fC?= =?us-ascii?Q?h8Q=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09760A0505 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(396003)(136003)(39860400002)(199004)(189003)(25786009)(450100002)(105586002)(4326008)(478600001)(81156014)(2906002)(81166006)(6246003)(6116002)(3846002)(99286004)(26005)(8936002)(14454004)(106356001)(97736004)(6506007)(6636002)(52536014)(53546011)(66066001)(186003)(33656002)(102836004)(486006)(7736002)(68736007)(71190400001)(11346002)(71200400001)(476003)(256004)(316002)(305945005)(446003)(54906003)(7696005)(6436002)(5660300002)(76176011)(8676002)(55016002)(14444005)(6862004)(86362001)(229853002)(74316002)(53936002)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4034; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: K9JBaGxGMwUc7H3FdYUicsJKSPoKdbljDlQAK74/iWoxBoG9gmrKKS1g7anae+KLv5wVXw7BdxGxzKeY+wv6jMYOwvj81fev2XGaT/SAIgIs651mFQK66ZTu5QS7H4thX5Yl+0v7x6lMYm0/LZe9BZWKfgNUQHxPtjJLjtJoPYAkFD8qMtVzC1GVEAYxepw4pFDeZWHKErD1KF0V8NrhUPSK/a9m5zFANNg48cbVvWhgYFWGDtL33QlWtiO8MDpNbu0ucUtLw/lUOrYXgWzLmozxQfN/P9PdIzcz3mPOthK8Z0A9uRMB/kc5cxG4p9aaYh6buVcT/dNQFJTxHSg+GPOJxJbtkyFjFvKxg13//zCrw0JWovv55Ue78rY+jnQLI1RFFdrXYJo8KYk8Fca3voYW0YLvCqE1bz+WN+XnpUA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a652a2a-9b95-47f3-8a01-08d6a85cb11b X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2019 09:08:57.8371 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4034 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix packet inline on Tx queue wraparound X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190314090857.H_xC4xrjdaitOVkD37l8EDQOS46hN_2t7PDrsrxOLlM@z> Monday, March 11, 2019 9:58 PM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: fix packet inline on Tx queue wraparound >=20 >=20 > > On Mar 10, 2019, at 12:14 AM, Shahaf Shuler > wrote: > > > > Inlining a packet to WQE that cross the WQ wraparound, i.e. the WQE > > starts on the end of the ring and ends on the beginning, is not > > supported and blocked by the data path logic. > > > > However, in case of TSO, an extra inline header is required before > > inlining. This inline header is not taken into account when checking > > if there is enough room left for the required inline size. > > On some corner cases were > > (ring_tailroom - inline header) < inline size < ring_tailroom , this > > can lead to WQE being written outsize of the ring buffer. > > > > Fixing it by always assuming the worse case that inline of packet will > > require the inline header. > > > > Fixes: 3f13f8c23a7c ("net/mlx5: support hardware TSO") > > Cc: stable@dpdk.org > > > > Signed-off-by: Shahaf Shuler > > --- >=20 > Acked-by: Yongseok Koh Applied to next-net-mlx, thanks.=20