DPDK patches and discussions
 help / color / mirror / Atom feed
From: Liang Zhang <zhangliang@bigo.sg>
To: dev@dpdk.org
Cc: Liang Zhang <zhangliang@bigo.sg>
Subject: [dpdk-dev] [PATCH v2] bonding: change mac_addr filled position
Date: Thu, 14 Mar 2019 20:27:21 +0800	[thread overview]
Message-ID: <1552566441-14658-1-git-send-email-zhangliang@bigo.sg> (raw)
Message-ID: <20190314122721.wWsMhkkPHmzUwkYkyHhihBTMLmhICE5EdM8gzI0Q0ZE@z> (raw)
In-Reply-To: <b5f940be-1db3-fb86-b102-a24877e22d7c@gmail.com>

When mac_address update in bond_mode_8023ad_mac_address_update,
bonding port's mac_addr should update also.

Signed-off-by: Liang Zhang <zhangliang@bigo.sg>
---
 drivers/net/bonding/rte_eth_bond_8023ad.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index e518956..dac23ac 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -791,8 +791,11 @@ rx_machine_update(struct bond_dev_private *internals, uint8_t slave_id,
 		RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP);
 
 		partner = &lacp->lacpdu.partner;
-		if (is_same_ether_addr(&partner->port_params.system, &internals->mode4.mac_addr)) {
-			/* This is LACP frame to the bonding port so pass it to rx_machine */
+		if (is_same_ether_addr(&partner->port_params.system,
+			&internals->mode4.mac_addr)) {
+			/* This LACP frame is sending to the bonding port
+			 * so pass it to rx_machine.
+			 */
 			rx_machine(internals, slave_id, &lacp->lacpdu);
 		}
 		rte_pktmbuf_free(lacp_pkt);
@@ -1144,7 +1147,6 @@ bond_mode_8023ad_setup(struct rte_eth_dev *dev,
 	bond_mode_8023ad_conf_assign(mode4, conf);
 	mode4->slowrx_cb = conf->slowrx_cb;
 	mode4->agg_selection = AGG_STABLE;
-	rte_eth_macaddr_get(internals->port_id, &mode4->mac_addr);
 
 	if (dev->data->dev_started)
 		bond_mode_8023ad_start(dev);
@@ -1170,6 +1172,7 @@ bond_mode_8023ad_start(struct rte_eth_dev *bond_dev)
 	struct mode8023ad_private *mode4 = &internals->mode4;
 	static const uint64_t us = BOND_MODE_8023AX_UPDATE_TIMEOUT_MS * 1000;
 
+	rte_eth_macaddr_get(internals->port_id, &mode4->mac_addr);
 	if (mode4->slowrx_cb)
 		return rte_eal_alarm_set(us, &bond_mode_8023ad_ext_periodic_cb,
 					 bond_dev);
-- 
2.7.4


  reply	other threads:[~2019-03-14 12:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 13:23 [dpdk-dev] [PATCH] bonding: fix lacp negotiation failed Liang Zhang
2019-03-13 18:02 ` Chas Williams
2019-03-14 12:27   ` Liang Zhang [this message]
2019-03-14 12:27     ` [dpdk-dev] [PATCH v2] bonding: change mac_addr filled position Liang Zhang
2019-03-15  8:53     ` [dpdk-dev] [PATCH v3 1/2] bonding: fix lacp negotiation failed Liang Zhang
2019-03-15  8:53       ` Liang Zhang
2019-03-15  8:53       ` [dpdk-dev] [PATCH v3 2/2] bonding: change mac_addr filled position Liang Zhang
2019-03-15  8:53         ` Liang Zhang
2019-03-14 12:09 ` [dpdk-dev] [PATCH v2] " Liang Zhang
2019-03-14 12:09   ` Liang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1552566441-14658-1-git-send-email-zhangliang@bigo.sg \
    --to=zhangliang@bigo.sg \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).