* [dpdk-dev] [PATCH 0/2] net/bnxt: supress warnings
2019-03-14 21:32 [dpdk-dev] [PATCH 0/2] net/bnxt: supress warnings Stephen Hemminger
@ 2019-03-14 21:32 ` Stephen Hemminger
2019-03-14 21:32 ` [dpdk-dev] [PATCH 1/2] net/bnxt: silence iova warnings Stephen Hemminger
` (2 subsequent siblings)
3 siblings, 0 replies; 14+ messages in thread
From: Stephen Hemminger @ 2019-03-14 21:32 UTC (permalink / raw)
To: ajit.khaparde, somnath.kotur; +Cc: dev, Stephen Hemminger
Silence messages that are not errors.
Stephen Hemminger (2):
net/bnxt: silence iova warnings
net/bnxt: suppress supprious error log
drivers/net/bnxt/bnxt_ethdev.c | 6 ++----
drivers/net/bnxt/bnxt_rxq.c | 3 ++-
2 files changed, 4 insertions(+), 5 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [dpdk-dev] [PATCH 1/2] net/bnxt: silence iova warnings
2019-03-14 21:32 [dpdk-dev] [PATCH 0/2] net/bnxt: supress warnings Stephen Hemminger
2019-03-14 21:32 ` Stephen Hemminger
@ 2019-03-14 21:32 ` Stephen Hemminger
2019-03-14 21:32 ` Stephen Hemminger
2019-03-15 13:03 ` Rami Rosen
2019-03-14 21:32 ` [dpdk-dev] [PATCH 2/2] net/bnxt: suppress supprious error log Stephen Hemminger
2019-03-15 19:02 ` [dpdk-dev] [PATCH 0/2] net/bnxt: supress warnings Ferruh Yigit
3 siblings, 2 replies; 14+ messages in thread
From: Stephen Hemminger @ 2019-03-14 21:32 UTC (permalink / raw)
To: ajit.khaparde, somnath.kotur; +Cc: dev, Stephen Hemminger
When using bnxt on bare-metal with vfio-pci, the driver logs an
unnecessary warning. Hardware works fine, message is not urgent.
Change it to INFO level.
Fixes: 62196f4e0941 ("mem: rename address mapping function to IOVA")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/bnxt/bnxt_ethdev.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 189527207f9a..bdc6a1267a52 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3242,10 +3242,8 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
memset(mz->addr, 0, mz->len);
mz_phys_addr = mz->iova;
if ((unsigned long)mz->addr == mz_phys_addr) {
- PMD_DRV_LOG(WARNING,
- "Memzone physical address same as virtual.\n");
- PMD_DRV_LOG(WARNING,
- "Using rte_mem_virt2iova()\n");
+ PMD_DRV_LOG(INFO,
+ "Memzone physical address same as virtual using rte_mem_virt2iova()\n");
mz_phys_addr = rte_mem_virt2iova(mz->addr);
if (mz_phys_addr == 0) {
PMD_DRV_LOG(ERR,
--
2.17.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [dpdk-dev] [PATCH 1/2] net/bnxt: silence iova warnings
2019-03-14 21:32 ` [dpdk-dev] [PATCH 1/2] net/bnxt: silence iova warnings Stephen Hemminger
@ 2019-03-14 21:32 ` Stephen Hemminger
2019-03-15 13:03 ` Rami Rosen
1 sibling, 0 replies; 14+ messages in thread
From: Stephen Hemminger @ 2019-03-14 21:32 UTC (permalink / raw)
To: ajit.khaparde, somnath.kotur; +Cc: dev, Stephen Hemminger
When using bnxt on bare-metal with vfio-pci, the driver logs an
unnecessary warning. Hardware works fine, message is not urgent.
Change it to INFO level.
Fixes: 62196f4e0941 ("mem: rename address mapping function to IOVA")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/bnxt/bnxt_ethdev.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 189527207f9a..bdc6a1267a52 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3242,10 +3242,8 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
memset(mz->addr, 0, mz->len);
mz_phys_addr = mz->iova;
if ((unsigned long)mz->addr == mz_phys_addr) {
- PMD_DRV_LOG(WARNING,
- "Memzone physical address same as virtual.\n");
- PMD_DRV_LOG(WARNING,
- "Using rte_mem_virt2iova()\n");
+ PMD_DRV_LOG(INFO,
+ "Memzone physical address same as virtual using rte_mem_virt2iova()\n");
mz_phys_addr = rte_mem_virt2iova(mz->addr);
if (mz_phys_addr == 0) {
PMD_DRV_LOG(ERR,
--
2.17.1
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/bnxt: silence iova warnings
2019-03-14 21:32 ` [dpdk-dev] [PATCH 1/2] net/bnxt: silence iova warnings Stephen Hemminger
2019-03-14 21:32 ` Stephen Hemminger
@ 2019-03-15 13:03 ` Rami Rosen
2019-03-15 13:03 ` Rami Rosen
2019-03-15 18:44 ` Ajit Khaparde
1 sibling, 2 replies; 14+ messages in thread
From: Rami Rosen @ 2019-03-15 13:03 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: ajit.khaparde, somnath.kotur, dev
Stephen Hemminger <stephen@networkplumber.org>:
> When using bnxt on bare-metal with vfio-pci, the driver logs an
> unnecessary warning. Hardware works fine, message is not urgent.
> Change it to INFO level.
>
> Fixes: 62196f4e0941 ("mem: rename address mapping function to IOVA")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> Reviewd-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/bnxt: silence iova warnings
2019-03-15 13:03 ` Rami Rosen
@ 2019-03-15 13:03 ` Rami Rosen
2019-03-15 18:44 ` Ajit Khaparde
1 sibling, 0 replies; 14+ messages in thread
From: Rami Rosen @ 2019-03-15 13:03 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: ajit.khaparde, somnath.kotur, dev
Stephen Hemminger <stephen@networkplumber.org>:
> When using bnxt on bare-metal with vfio-pci, the driver logs an
> unnecessary warning. Hardware works fine, message is not urgent.
> Change it to INFO level.
>
> Fixes: 62196f4e0941 ("mem: rename address mapping function to IOVA")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> Reviewd-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/bnxt: silence iova warnings
2019-03-15 13:03 ` Rami Rosen
2019-03-15 13:03 ` Rami Rosen
@ 2019-03-15 18:44 ` Ajit Khaparde
2019-03-15 18:44 ` Ajit Khaparde
1 sibling, 1 reply; 14+ messages in thread
From: Ajit Khaparde @ 2019-03-15 18:44 UTC (permalink / raw)
To: Rami Rosen; +Cc: Stephen Hemminger, Somnath Kotur, dev
On Fri, Mar 15, 2019 at 6:03 AM Rami Rosen <ramirose@gmail.com> wrote:
>
> Stephen Hemminger <stephen@networkplumber.org>:
>
>> When using bnxt on bare-metal with vfio-pci, the driver logs an
>> unnecessary warning. Hardware works fine, message is not urgent.
>> Change it to INFO level.
>>
>> Fixes: 62196f4e0941 ("mem: rename address mapping function to IOVA")
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> ---
>> Reviewd-by: Rami Rosen <ramirose@gmail.com>
>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/bnxt: silence iova warnings
2019-03-15 18:44 ` Ajit Khaparde
@ 2019-03-15 18:44 ` Ajit Khaparde
0 siblings, 0 replies; 14+ messages in thread
From: Ajit Khaparde @ 2019-03-15 18:44 UTC (permalink / raw)
To: Rami Rosen; +Cc: Stephen Hemminger, Somnath Kotur, dev
On Fri, Mar 15, 2019 at 6:03 AM Rami Rosen <ramirose@gmail.com> wrote:
>
> Stephen Hemminger <stephen@networkplumber.org>:
>
>> When using bnxt on bare-metal with vfio-pci, the driver logs an
>> unnecessary warning. Hardware works fine, message is not urgent.
>> Change it to INFO level.
>>
>> Fixes: 62196f4e0941 ("mem: rename address mapping function to IOVA")
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> ---
>> Reviewd-by: Rami Rosen <ramirose@gmail.com>
>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [dpdk-dev] [PATCH 2/2] net/bnxt: suppress supprious error log
2019-03-14 21:32 [dpdk-dev] [PATCH 0/2] net/bnxt: supress warnings Stephen Hemminger
2019-03-14 21:32 ` Stephen Hemminger
2019-03-14 21:32 ` [dpdk-dev] [PATCH 1/2] net/bnxt: silence iova warnings Stephen Hemminger
@ 2019-03-14 21:32 ` Stephen Hemminger
2019-03-14 21:32 ` Stephen Hemminger
2019-03-15 0:04 ` Somnath Kotur
2019-03-15 19:02 ` [dpdk-dev] [PATCH 0/2] net/bnxt: supress warnings Ferruh Yigit
3 siblings, 2 replies; 14+ messages in thread
From: Stephen Hemminger @ 2019-03-14 21:32 UTC (permalink / raw)
To: ajit.khaparde, somnath.kotur; +Cc: dev, Stephen Hemminger
The driver multiple rxq allocation logs a message at error level
but it really is a debug message.
Fixes: 51fafb89a9a0 ("net/bnxt: get rid of ff pools and use VNIC info array")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/bnxt/bnxt_rxq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index 5345d3938311..17e2909a7e5c 100644
--- a/drivers/net/bnxt/bnxt_rxq.c
+++ b/drivers/net/bnxt/bnxt_rxq.c
@@ -100,7 +100,8 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
}
}
nb_q_per_grp = bp->rx_cp_nr_rings / pools;
- PMD_DRV_LOG(ERR, "pools = %u nb_q_per_grp = %u\n", pools, nb_q_per_grp);
+ PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n",
+ pools, nb_q_per_grp);
start_grp_id = 0;
end_grp_id = nb_q_per_grp;
--
2.17.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [dpdk-dev] [PATCH 2/2] net/bnxt: suppress supprious error log
2019-03-14 21:32 ` [dpdk-dev] [PATCH 2/2] net/bnxt: suppress supprious error log Stephen Hemminger
@ 2019-03-14 21:32 ` Stephen Hemminger
2019-03-15 0:04 ` Somnath Kotur
1 sibling, 0 replies; 14+ messages in thread
From: Stephen Hemminger @ 2019-03-14 21:32 UTC (permalink / raw)
To: ajit.khaparde, somnath.kotur; +Cc: dev, Stephen Hemminger
The driver multiple rxq allocation logs a message at error level
but it really is a debug message.
Fixes: 51fafb89a9a0 ("net/bnxt: get rid of ff pools and use VNIC info array")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/bnxt/bnxt_rxq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index 5345d3938311..17e2909a7e5c 100644
--- a/drivers/net/bnxt/bnxt_rxq.c
+++ b/drivers/net/bnxt/bnxt_rxq.c
@@ -100,7 +100,8 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
}
}
nb_q_per_grp = bp->rx_cp_nr_rings / pools;
- PMD_DRV_LOG(ERR, "pools = %u nb_q_per_grp = %u\n", pools, nb_q_per_grp);
+ PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n",
+ pools, nb_q_per_grp);
start_grp_id = 0;
end_grp_id = nb_q_per_grp;
--
2.17.1
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] net/bnxt: suppress supprious error log
2019-03-14 21:32 ` [dpdk-dev] [PATCH 2/2] net/bnxt: suppress supprious error log Stephen Hemminger
2019-03-14 21:32 ` Stephen Hemminger
@ 2019-03-15 0:04 ` Somnath Kotur
2019-03-15 0:04 ` Somnath Kotur
1 sibling, 1 reply; 14+ messages in thread
From: Somnath Kotur @ 2019-03-15 0:04 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Ajit Kumar Khaparde, dev
On Fri, Mar 15, 2019 at 3:02 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The driver multiple rxq allocation logs a message at error level
> but it really is a debug message.
>
> Fixes: 51fafb89a9a0 ("net/bnxt: get rid of ff pools and use VNIC info array")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/bnxt/bnxt_rxq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
> index 5345d3938311..17e2909a7e5c 100644
> --- a/drivers/net/bnxt/bnxt_rxq.c
> +++ b/drivers/net/bnxt/bnxt_rxq.c
> @@ -100,7 +100,8 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
> }
> }
> nb_q_per_grp = bp->rx_cp_nr_rings / pools;
> - PMD_DRV_LOG(ERR, "pools = %u nb_q_per_grp = %u\n", pools, nb_q_per_grp);
> + PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n",
> + pools, nb_q_per_grp);
> start_grp_id = 0;
> end_grp_id = nb_q_per_grp;
>
> --
> 2.17.1
>
Acked-by: Somnath Kotur (somnath.kotur@broadcom.com
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] net/bnxt: suppress supprious error log
2019-03-15 0:04 ` Somnath Kotur
@ 2019-03-15 0:04 ` Somnath Kotur
0 siblings, 0 replies; 14+ messages in thread
From: Somnath Kotur @ 2019-03-15 0:04 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Ajit Kumar Khaparde, dev
On Fri, Mar 15, 2019 at 3:02 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The driver multiple rxq allocation logs a message at error level
> but it really is a debug message.
>
> Fixes: 51fafb89a9a0 ("net/bnxt: get rid of ff pools and use VNIC info array")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/bnxt/bnxt_rxq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
> index 5345d3938311..17e2909a7e5c 100644
> --- a/drivers/net/bnxt/bnxt_rxq.c
> +++ b/drivers/net/bnxt/bnxt_rxq.c
> @@ -100,7 +100,8 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
> }
> }
> nb_q_per_grp = bp->rx_cp_nr_rings / pools;
> - PMD_DRV_LOG(ERR, "pools = %u nb_q_per_grp = %u\n", pools, nb_q_per_grp);
> + PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n",
> + pools, nb_q_per_grp);
> start_grp_id = 0;
> end_grp_id = nb_q_per_grp;
>
> --
> 2.17.1
>
Acked-by: Somnath Kotur (somnath.kotur@broadcom.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [dpdk-dev] [PATCH 0/2] net/bnxt: supress warnings
2019-03-14 21:32 [dpdk-dev] [PATCH 0/2] net/bnxt: supress warnings Stephen Hemminger
` (2 preceding siblings ...)
2019-03-14 21:32 ` [dpdk-dev] [PATCH 2/2] net/bnxt: suppress supprious error log Stephen Hemminger
@ 2019-03-15 19:02 ` Ferruh Yigit
2019-03-15 19:02 ` Ferruh Yigit
3 siblings, 1 reply; 14+ messages in thread
From: Ferruh Yigit @ 2019-03-15 19:02 UTC (permalink / raw)
To: Stephen Hemminger, ajit.khaparde, somnath.kotur; +Cc: dev
On 3/14/2019 9:32 PM, Stephen Hemminger wrote:
> Silence messages that are not errors.
>
> Stephen Hemminger (2):
> net/bnxt: silence iova warnings
> net/bnxt: suppress supprious error log
Series applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread