From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2C0EDA0096 for ; Fri, 15 Mar 2019 02:50:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1DF362C28; Fri, 15 Mar 2019 02:50:36 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 69B552C17 for ; Fri, 15 Mar 2019 02:50:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 18:50:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,480,1544515200"; d="scan'208";a="214327957" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 14 Mar 2019 18:50:33 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 18:50:32 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.163]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.223]) with mapi id 14.03.0415.000; Fri, 15 Mar 2019 09:50:30 +0800 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 3/8] net/ice: support vector SSE in RX Thread-Index: AQHU0lZNqWH4k5zuQUeZJ3kb2sj9ZKYFSbkAgAa0JcA= Date: Fri, 15 Mar 2019 01:50:30 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909407ECF58@shsmsx102.ccr.corp.intel.com> References: <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com> <1551682408-107569-1-git-send-email-wenzhuo.lu@intel.com> <1551682408-107569-4-git-send-email-wenzhuo.lu@intel.com> <039ED4275CED7440929022BC67E706115334A3D6@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115334A3D6@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/8] net/ice: support vector SSE in RX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190315015030.LkL8VTpela1ZKP09x928Kxqv3Tzl2AwU-QkRHNIzDms@z> Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, March 11, 2019 11:27 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v2 3/8] net/ice: support vector SSE in RX >=20 > Hi: >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Monday, March 4, 2019 2:53 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo > > Subject: [dpdk-dev] [PATCH v2 3/8] net/ice: support vector SSE in RX > > > > Signed-off-by: Wenzhuo Lu > > --- >=20 > ..... >=20 > > + > > + if (!ice_rx_vec_dev_check(dev)) { > > + for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > > + rxq =3D dev->data->rx_queues[i]; > > + (void)ice_rxq_vec_setup(rxq); > > + } > > + PMD_DRV_LOG(DEBUG, "Using Vector Rx (port %d).", > > + dev->data->port_id); > > + dev->rx_pkt_burst =3D ice_recv_pkts_vec; > > + > > + return; > > + } > > +#endif > > >=20 > Since vPMD is only implemented on x86, I think the logic to setup vector = path > could be wrapped by compile option #ifdef ARCH_X86, otherwise I guess > there will be some compile error on other platform, for example the > function ice_rx_vec_dev_check is only defined in ice_rxtx_vec_sse.c Thanks for the comments. There should be compile errors if x86 not supporte= d. Will send a V3.