From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 463EDA0096 for ; Fri, 15 Mar 2019 05:14:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59FD82C17; Fri, 15 Mar 2019 05:14:00 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id DD4DB11A4 for ; Fri, 15 Mar 2019 05:13:58 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 21:13:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,480,1544515200"; d="scan'208";a="152526743" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by fmsmga004.fm.intel.com with ESMTP; 14 Mar 2019 21:13:56 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.210]) by PGSMSX108.gar.corp.intel.com ([169.254.8.195]) with mapi id 14.03.0415.000; Fri, 15 Mar 2019 12:13:56 +0800 From: "Zhao1, Wei" To: "Zhang, Qi Z" , "David Harton (dharton)" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf Thread-Index: AQHU2s06vBxK09J24UensknAoenAjqYMFNUQ Date: Fri, 15 Mar 2019 04:13:55 +0000 Message-ID: References: <20190306152355.1697-1-dharton@cisco.com> <20190308203430.31742-1-dharton@cisco.com> <039ED4275CED7440929022BC67E706115334CA1F@SHSMSX103.ccr.corp.intel.com> <039ED4275CED7440929022BC67E706115334CD63@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115334CD63@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190315041355.OLcnh0LczClGh6rDLV7yNODoj0b9q4rXLJo4nHyxrEo@z> > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, March 15, 2019 9:20 AM > To: David Harton (dharton) > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; dev@dpdk.org; Zhao1, Wei > > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf >=20 >=20 >=20 > > -----Original Message----- > > From: David Harton (dharton) [mailto:dharton@cisco.com] > > Sent: Thursday, March 14, 2019 11:51 PM > > To: Zhang, Qi Z > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > ; dev@dpdk.org > > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for > > ixgbevf > > > > Hi Qi, > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Thursday, March 14, 2019 11:14 AM > > > To: David Harton (dharton) > > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > > ; dev@dpdk.org > > > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for > > > ixgbevf > > > > > > > > > > > > > -----Original Message----- > > > > From: David Harton (dharton) [mailto:dharton@cisco.com] > > > > Sent: Thursday, March 14, 2019 9:38 PM > > > > To: David Harton (dharton) ; Zhang, Qi Z > > > > > > > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > > > ; dev@dpdk.org > > > > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for > > > > ixgbevf > > > > > > > > Hi Qi, > > > > > > > > This patch was rejected with no feedback. > > > > > > > > Can you share why? > > > > > > Because as Zhao Wei explained in v1 thread, in > > > ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and > > > DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like > VLAN_FILTER > > AND > > > VLAN_EXTEND offload is not supported and I didn't see you reply for > > > that, so I > > assume you agree with that. > > > > > > > > > > > > > > Without this patch users are not able to call the > > > > rte_eth_dev_vlan_filter() API for ixgbevf based ports because > > > > VLAN_FILTER cannot be enabled when calling rte_eth_dev_configure(). > > > > > > OK, seems vlan filter is able to be configured for ixgbevf, but I > > > don't know how this will work because vlan filter table needs to be > > > enabled first (ixgbe_vlan_hw_filter_enable) So at least when it work > > > with a DPDK PF, vlan filter will not work, maybe kernel PF driver > > > will enable it by default? Could you share more insight? > > > > I can't answer that but ixgbevf_vlan_filter_set() has been implemented > > for quite some time and it can no longer be called since the new > > offload flags are being enforced now. > > > > I can share that rte_eth_dev_vlan_filter()/ixgbevf_vlan_filter_set() > > works properly with the propose change (VLAN traffic flows) where it > > doesn't without it. >=20 > Ok, if it is proved to work well with kernel PF, I think we should have t= his > offload It seems kernel pf enable vlan filter by default? This vf fuction is depend on kernel pf. > > > > > > > > And same question to VLAN_EXTEND > > > > I actually don't care about extend but simply changed it because it > > seems to be in the same situation. I'm happy to leave it out of the > > patch if that grants acceptance. >=20 > Seems VLAN Extend is only supported by DPDK PF driver, I didn't see any > related configuration in kernel driver. > Properly we need to remove it. >=20 > @Wei, would you help to confirm on that? I will check that later. >=20 > Thanks > Qi >=20 > > > > Thanks, > > Dave > > > > > > > > > > > > > > > > Or, am I missing something? > > > > > > > > Thanks, > > > > Dave > > > > > > > > > -----Original Message----- > > > > > From: David Harton > > > > > Sent: Friday, March 08, 2019 3:35 PM > > > > > To: dev@dpdk.org > > > > > Cc: wenzhuo.lu@intel.com; konstantin.ananyev@intel.com; > > > > > qi.z.zhang@intel.com; David Harton (dharton) > > > > > Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for > > > > > ixgbevf > > > > > > > > > > ixgbevf vlan strip and extend capabilities were removed when > > > > > migrating to the bit flags implementation. > > > > > > > > > > Restoring the capbility to enable these offloads at > > > > > configuration > > > time. > > > > > > > > > > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads > > > > > API\") > > > > > Signed-off-by: David Harton > > > > > --- > > > > > > > > > > v2: removed unused function ixgbe_is_vf() > > > > > > > > > > drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++--------------------- > > > > > 1 file changed, 2 insertions(+), 21 deletions(-) > > > > > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > > > > > b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e > > > > > 100644 > > > > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > > > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > > > > @@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct > ixgbe_adapter > > > > > *adapter, struct ixgbe_rx_queue *rxq) #endif } > > > > > > > > > > -static int > > > > > -ixgbe_is_vf(struct rte_eth_dev *dev) -{ > > > > > - struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev- > >data- > > > > > >dev_private); > > > > > - > > > > > - switch (hw->mac.type) { > > > > > - case ixgbe_mac_82599_vf: > > > > > - case ixgbe_mac_X540_vf: > > > > > - case ixgbe_mac_X550_vf: > > > > > - case ixgbe_mac_X550EM_x_vf: > > > > > - case ixgbe_mac_X550EM_a_vf: > > > > > - return 1; > > > > > - default: > > > > > - return 0; > > > > > - } > > > > > -} > > > > > - > > > > > uint64_t > > > > > ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev) { @@ > > > > > -2853,15 > > > > > +2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev) > > > > > DEV_RX_OFFLOAD_TCP_CKSUM | > > > > > DEV_RX_OFFLOAD_KEEP_CRC | > > > > > DEV_RX_OFFLOAD_JUMBO_FRAME | > > > > > + DEV_RX_OFFLOAD_VLAN_FILTER | > > > > > + DEV_RX_OFFLOAD_VLAN_EXTEND | > > > > > DEV_RX_OFFLOAD_SCATTER; > > > > > > > > > > if (hw->mac.type =3D=3D ixgbe_mac_82598EB) > > > > > offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; > > > > > > > > > > - if (ixgbe_is_vf(dev) =3D=3D 0) > > > > > - offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER | > > > > > - DEV_RX_OFFLOAD_VLAN_EXTEND); > > > > > - > > > > > /* > > > > > * RSC is only supported by 82599 and x540 PF devices in a > > > > > non-SR- IOV > > > > > * mode. > > > > > -- > > > > > 2.19.1