From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) by dpdk.org (Postfix) with ESMTP id 964E82BD3 for ; Fri, 15 Mar 2019 17:08:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1333; q=dns/txt; s=iport; t=1552666119; x=1553875719; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7Ae/dIynr13OqGfHkhX816fOwjoRrKK3z9aj36II8hg=; b=LdsS3Cr6aEMZYlJBXW3tzY8pVpiMHxeJy9AWXFY05vDiuW+Zb+TsLXFw xbp0PxDi15GdjnycPNGNWjRcfRuhtUosAY6QUAdVNjLtlTcpRo1lUbOGh iR+rhUuAk4F6qmhDsd8BXJML0vT13fMbZMoxl5JaYP2uGLwoy2jOGewEg E=; X-IronPort-AV: E=Sophos;i="5.58,482,1544486400"; d="scan'208";a="535947468" Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 15 Mar 2019 16:08:38 +0000 Received: from cpp-rtpbld-31.cisco.com (cpp-rtpbld-31.cisco.com [172.18.5.114]) by rcdn-core-4.cisco.com (8.15.2/8.15.2) with ESMTP id x2FG8cFF013294; Fri, 15 Mar 2019 16:08:38 GMT Received: by cpp-rtpbld-31.cisco.com (Postfix, from userid 140087) id 3C541A38; Fri, 15 Mar 2019 12:08:38 -0400 (EDT) From: David Harton To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, qi.z.zhang@intel.com, David Harton Date: Fri, 15 Mar 2019 12:08:32 -0400 Message-Id: <20190315160832.34127-1-dharton@cisco.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190315122650.11660-1-dharton@cisco.com> References: <20190315122650.11660-1-dharton@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Outbound-SMTP-Client: 172.18.5.114, cpp-rtpbld-31.cisco.com X-Outbound-Node: rcdn-core-4.cisco.com Subject: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 16:08:39 -0000 ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation. Restoring the capbility to enable the vlan strip offload at configuration time. Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") Signed-off-by: David Harton --- v4: fixed commit headline/log v3: restored ixgbe_is_vf() and only restore VLAN_FILTER v2: removed unused function ixgbe_is_vf() drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..e71d3c188 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2853,14 +2853,14 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev) DEV_RX_OFFLOAD_TCP_CKSUM | DEV_RX_OFFLOAD_KEEP_CRC | DEV_RX_OFFLOAD_JUMBO_FRAME | + DEV_RX_OFFLOAD_VLAN_FILTER | DEV_RX_OFFLOAD_SCATTER; if (hw->mac.type == ixgbe_mac_82598EB) offloads |= DEV_RX_OFFLOAD_VLAN_STRIP; if (ixgbe_is_vf(dev) == 0) - offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER | - DEV_RX_OFFLOAD_VLAN_EXTEND); + offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND; /* * RSC is only supported by 82599 and x540 PF devices in a non-SR-IOV -- 2.19.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id ACBD2A0096 for ; Fri, 15 Mar 2019 17:08:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 93B392C17; Fri, 15 Mar 2019 17:08:40 +0100 (CET) Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) by dpdk.org (Postfix) with ESMTP id 964E82BD3 for ; Fri, 15 Mar 2019 17:08:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1333; q=dns/txt; s=iport; t=1552666119; x=1553875719; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7Ae/dIynr13OqGfHkhX816fOwjoRrKK3z9aj36II8hg=; b=LdsS3Cr6aEMZYlJBXW3tzY8pVpiMHxeJy9AWXFY05vDiuW+Zb+TsLXFw xbp0PxDi15GdjnycPNGNWjRcfRuhtUosAY6QUAdVNjLtlTcpRo1lUbOGh iR+rhUuAk4F6qmhDsd8BXJML0vT13fMbZMoxl5JaYP2uGLwoy2jOGewEg E=; X-IronPort-AV: E=Sophos;i="5.58,482,1544486400"; d="scan'208";a="535947468" Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 15 Mar 2019 16:08:38 +0000 Received: from cpp-rtpbld-31.cisco.com (cpp-rtpbld-31.cisco.com [172.18.5.114]) by rcdn-core-4.cisco.com (8.15.2/8.15.2) with ESMTP id x2FG8cFF013294; Fri, 15 Mar 2019 16:08:38 GMT Received: by cpp-rtpbld-31.cisco.com (Postfix, from userid 140087) id 3C541A38; Fri, 15 Mar 2019 12:08:38 -0400 (EDT) From: David Harton To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, qi.z.zhang@intel.com, David Harton Date: Fri, 15 Mar 2019 12:08:32 -0400 Message-Id: <20190315160832.34127-1-dharton@cisco.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190315122650.11660-1-dharton@cisco.com> References: <20190315122650.11660-1-dharton@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Outbound-SMTP-Client: 172.18.5.114, cpp-rtpbld-31.cisco.com X-Outbound-Node: rcdn-core-4.cisco.com Subject: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190315160832.ZN_MD02Ssh1HqA_0xur_Hcpqz8p04oa_Q00DC-bs6ZI@z> ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation. Restoring the capbility to enable the vlan strip offload at configuration time. Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") Signed-off-by: David Harton --- v4: fixed commit headline/log v3: restored ixgbe_is_vf() and only restore VLAN_FILTER v2: removed unused function ixgbe_is_vf() drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..e71d3c188 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2853,14 +2853,14 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev) DEV_RX_OFFLOAD_TCP_CKSUM | DEV_RX_OFFLOAD_KEEP_CRC | DEV_RX_OFFLOAD_JUMBO_FRAME | + DEV_RX_OFFLOAD_VLAN_FILTER | DEV_RX_OFFLOAD_SCATTER; if (hw->mac.type == ixgbe_mac_82598EB) offloads |= DEV_RX_OFFLOAD_VLAN_STRIP; if (ixgbe_is_vf(dev) == 0) - offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER | - DEV_RX_OFFLOAD_VLAN_EXTEND); + offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND; /* * RSC is only supported by 82599 and x540 PF devices in a non-SR-IOV -- 2.19.1