From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>,
Luca Boccassi <bluca@debian.org>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH v3 4/4] eal: remove unneeded version logic
Date: Fri, 15 Mar 2019 18:20:22 +0000 [thread overview]
Message-ID: <20190315182022.39976-5-bruce.richardson@intel.com> (raw)
Message-ID: <20190315182022.OEn0EeLPUNTF9xtHZEHT7O6g9Riu1rBIv-QVZK5HBJY@z> (raw)
In-Reply-To: <20190315182022.39976-1-bruce.richardson@intel.com>
The version number in the DPDK_VERSION file will never have an offset
that needs to be subtracted, so remove that logic from the version
string generation.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Luca Boccassi <bluca@debian.org>
---
V2,V3: No changes, added Luca's ack
lib/librte_eal/common/include/rte_version.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/librte_eal/common/include/rte_version.h b/lib/librte_eal/common/include/rte_version.h
index 50867ea81..f7a3a1ebc 100644
--- a/lib/librte_eal/common/include/rte_version.h
+++ b/lib/librte_eal/common/include/rte_version.h
@@ -57,9 +57,7 @@ rte_version(void)
RTE_VER_MONTH,
RTE_VER_MINOR,
RTE_VER_SUFFIX,
- RTE_VER_RELEASE < 16 ?
- RTE_VER_RELEASE :
- RTE_VER_RELEASE - 16);
+ RTE_VER_RELEASE);
return version;
}
--
2.20.1
next prev parent reply other threads:[~2019-03-15 18:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 11:54 [dpdk-dev] [RFC PATCH 0/4] One versionfile to rule them all Bruce Richardson
2019-03-07 11:54 ` [dpdk-dev] [PATCH 1/4] build: add single source of DPDK version number Bruce Richardson
2019-03-07 12:33 ` David Marchand
2019-03-07 11:54 ` [dpdk-dev] [PATCH 2/4] build: use version number from config file Bruce Richardson
2019-03-07 12:37 ` David Marchand
2019-03-07 12:42 ` David Marchand
2019-03-07 13:12 ` Bruce Richardson
2019-03-07 13:01 ` Bruce Richardson
2019-03-07 11:54 ` [dpdk-dev] [PATCH 3/4] build: move meson version handling to config directory Bruce Richardson
2019-03-07 11:54 ` [dpdk-dev] [PATCH 4/4] eal: remove unneeded version logic Bruce Richardson
2019-03-07 12:09 ` [dpdk-dev] [RFC PATCH 0/4] One versionfile to rule them all Luca Boccassi
2019-03-07 12:14 ` Bruce Richardson
2019-03-07 13:34 ` [dpdk-dev] [PATCH v2 " Bruce Richardson
2019-03-07 13:34 ` [dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number Bruce Richardson
2019-03-13 11:06 ` Thomas Monjalon
2019-03-13 11:17 ` Bruce Richardson
2019-03-13 11:23 ` Thomas Monjalon
2019-03-13 11:27 ` Bruce Richardson
2019-03-07 13:35 ` [dpdk-dev] [PATCH v2 2/4] build: use version number from config file Bruce Richardson
2019-03-13 11:13 ` Thomas Monjalon
2019-03-13 11:20 ` Bruce Richardson
2019-03-13 11:24 ` Thomas Monjalon
2019-03-07 13:35 ` [dpdk-dev] [PATCH v2 3/4] build: move meson version handling to config directory Bruce Richardson
2019-03-07 13:35 ` [dpdk-dev] [PATCH v2 4/4] eal: remove unneeded version logic Bruce Richardson
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 0/4] One versionfile to rule them all Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 1/4] build: add single source of DPDK version number Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-16 18:01 ` Rami Rosen
2019-03-16 18:01 ` Rami Rosen
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 2/4] build: move meson version handling to config directory Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 3/4] build: use version number from config file Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-27 0:27 ` Thomas Monjalon
2019-03-27 0:27 ` Thomas Monjalon
2019-03-15 18:20 ` Bruce Richardson [this message]
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 4/4] eal: remove unneeded version logic Bruce Richardson
2019-03-27 0:34 ` [dpdk-dev] [PATCH v3 0/4] One versionfile to rule them all Thomas Monjalon
2019-03-27 0:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315182022.39976-5-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).