[dpdk-dev] [PATCH 0/3] bnxt: logging cleanups

[dpdk-dev] [PATCH 0/3] bnxt: logging cleanups

[Stephen Hemminger]

This reduces the logging in this driver and makes it
work like others.

Stephen Hemminger (3):
  net/bnxt: change PTP message to DEBUG level
  net/bnxt: do not double space version message
  net/bnxt: use NOTICE as default log level

 drivers/net/bnxt/bnxt_ethdev.c | 4 ++--
 drivers/net/bnxt/bnxt_hwrm.c   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.17.1

[dpdk-dev] [PATCH 1/3] net/bnxt: change PTP message to DEBUG level

[Stephen Hemminger]

This message doesn't need to be at INFO level, it is a normal
situation and only useful for debugging.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 999976054d41..eb5c41ebb0ba 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -591,7 +591,7 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp)
 		bp->pf.total_vnics = rte_le_to_cpu_16(resp->max_vnics);
 		if (flags & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_PTP_SUPPORTED) {
 			bp->flags |= BNXT_FLAG_PTP_SUPPORTED;
-			PMD_DRV_LOG(INFO, "PTP SUPPORTED\n");
+			PMD_DRV_LOG(DEBUG, "PTP SUPPORTED\n");
 			HWRM_UNLOCK();
 			bnxt_hwrm_ptp_qcfg(bp);
 		}
-- 
2.17.1

[dpdk-dev] [PATCH 2/3] net/bnxt: do not double space version message

[Stephen Hemminger]

The version message is double spaced in the log.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 189527207f9a..c5f7cf9cb9ec 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -30,7 +30,7 @@
 
 #define DRV_MODULE_NAME		"bnxt"
 static const char bnxt_version[] =
-	"Broadcom NetXtreme driver " DRV_MODULE_NAME "\n";
+	"Broadcom NetXtreme driver " DRV_MODULE_NAME;
 int bnxt_logtype_driver;
 
 #define PCI_VENDOR_ID_BROADCOM 0x14E4
-- 
2.17.1

[dpdk-dev] [PATCH 3/3] net/bnxt: use NOTICE as default log level

[Stephen Hemminger]

Make bnxt driver consistent with all other network drivers
by setting default to NOTICE for log level.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index c5f7cf9cb9ec..b5d8128cf3ed 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3571,7 +3571,7 @@ RTE_INIT(bnxt_init_log)
 {
 	bnxt_logtype_driver = rte_log_register("pmd.net.bnxt.driver");
 	if (bnxt_logtype_driver >= 0)
-		rte_log_set_level(bnxt_logtype_driver, RTE_LOG_INFO);
+		rte_log_set_level(bnxt_logtype_driver, RTE_LOG_NOTICE);
 }
 
 RTE_PMD_REGISTER_PCI(net_bnxt, bnxt_rte_pmd);
-- 
2.17.1

Re: [dpdk-dev] [PATCH 0/3] bnxt: logging cleanups

[Ajit Khaparde]

On Mon, Mar 11, 2019 at 11:11 AM Stephen Hemminger <
stephen@networkplumber.org> wrote:

> This reduces the logging in this driver and makes it
> work like others.
>
> Stephen Hemminger (3):
>   net/bnxt: change PTP message to DEBUG level
>   net/bnxt: do not double space version message
>   net/bnxt: use NOTICE as default log level
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>


>
>  drivers/net/bnxt/bnxt_ethdev.c | 4 ++--
>  drivers/net/bnxt/bnxt_hwrm.c   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> --
> 2.17.1
>
>

Re: [dpdk-dev] [PATCH 0/3] bnxt: logging cleanups

[Ferruh Yigit]

On 3/11/2019 6:19 PM, Ajit Khaparde wrote:
> On Mon, Mar 11, 2019 at 11:11 AM Stephen Hemminger <
> stephen@networkplumber.org> wrote:
> 
>> This reduces the logging in this driver and makes it
>> work like others.
>>
>> Stephen Hemminger (3):
>>   net/bnxt: change PTP message to DEBUG level
>>   net/bnxt: do not double space version message
>>   net/bnxt: use NOTICE as default log level
>>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 0/3] bnxt: logging cleanups

[Ferruh Yigit]

On 3/11/2019 6:19 PM, Ajit Khaparde wrote:
> On Mon, Mar 11, 2019 at 11:11 AM Stephen Hemminger <
> stephen@networkplumber.org> wrote:
> 
>> This reduces the logging in this driver and makes it
>> work like others.
>>
>> Stephen Hemminger (3):
>>   net/bnxt: change PTP message to DEBUG level
>>   net/bnxt: do not double space version message
>>   net/bnxt: use NOTICE as default log level
>>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Series applied to dpdk-next-net/master, thanks.