Re: [dpdk-dev] [PATCH v3 8/8] net/ice: support vector AVX2 in TX

["Lu, Wenzhuo" <wenzhuo.lu@intel.com>]

Hi Ferruh,


> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Saturday, March 16, 2019 1:55 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3 8/8] net/ice: support vector AVX2 in TX
> 
> On 3/15/2019 6:22 AM, Wenzhuo Lu wrote:
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > ---
> >  doc/guides/rel_notes/release_19_05.rst |   4 +
> >  drivers/net/ice/ice_rxtx.c             |  13 ++-
> >  drivers/net/ice/ice_rxtx.h             |   2 +
> >  drivers/net/ice/ice_rxtx_vec_avx2.c    | 158
> +++++++++++++++++++++++++++++++++
> >  4 files changed, 175 insertions(+), 2 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/release_19_05.rst
> > b/doc/guides/rel_notes/release_19_05.rst
> > index 61a2c73..610c4cd 100644
> > --- a/doc/guides/rel_notes/release_19_05.rst
> > +++ b/doc/guides/rel_notes/release_19_05.rst
> > @@ -91,6 +91,10 @@ New Features
> >
> >    * Added promiscuous mode support.
> >
> > +* **Added support of vector instructions on ICE.**
> > +
> > +   Added support of SSE and AVX2 instructions in ICE RX and TX path.
> > +
> 
> ice documentation doesn't have any information about vector path, can you
> please update it?
> 
> I think it can be good to document when vector path is used? How to decide
> scalar, sse or avx to use? What will prevent using vector path, like any
> offload or any specific config?
Thanks for the comments. Will add more info here. 
> 
> Thanks,
> ferruh