From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 86B35A00E6 for ; Mon, 18 Mar 2019 04:05:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96574152A; Mon, 18 Mar 2019 04:05:13 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D572F11A4 for ; Mon, 18 Mar 2019 04:05:11 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Mar 2019 20:05:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,491,1544515200"; d="scan'208";a="123500058" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by orsmga007.jf.intel.com with ESMTP; 17 Mar 2019 20:05:09 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.210]) by PGSMSX104.gar.corp.intel.com ([169.254.3.40]) with mapi id 14.03.0415.000; Mon, 18 Mar 2019 11:05:08 +0800 From: "Zhao1, Wei" To: David Harton , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf Thread-Index: AQHU20loEjSk2iAIqkmsulCvYcui5KYQt9cg Date: Mon, 18 Mar 2019 03:05:08 +0000 Message-ID: References: <20190315122650.11660-1-dharton@cisco.com> <20190315160832.34127-1-dharton@cisco.com> In-Reply-To: <20190315160832.34127-1-dharton@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190318030508.WODG3uOIQv0L0sVvYRJHDmyNqmvbu5HGfeZzLA521zQ@z> Acked-by: Wei Zhao > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Harton > Sent: Saturday, March 16, 2019 12:09 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Qi Z ; > David Harton > Subject: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf >=20 > ixgbevf vlan strip and extend capabilities were removed when migrating to > the bit flags implementation. >=20 > Restoring the capbility to enable the vlan strip offload at configuration= time. >=20 > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") > Signed-off-by: David Harton > --- >=20 > v4: fixed commit headline/log > v3: restored ixgbe_is_vf() and only restore VLAN_FILTER > v2: removed unused function ixgbe_is_vf() >=20 > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxt= x.c > index e92a70fb3..e71d3c188 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -2853,14 +2853,14 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev > *dev) > DEV_RX_OFFLOAD_TCP_CKSUM | > DEV_RX_OFFLOAD_KEEP_CRC | > DEV_RX_OFFLOAD_JUMBO_FRAME | > + DEV_RX_OFFLOAD_VLAN_FILTER | > DEV_RX_OFFLOAD_SCATTER; >=20 > if (hw->mac.type =3D=3D ixgbe_mac_82598EB) > offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; >=20 > if (ixgbe_is_vf(dev) =3D=3D 0) > - offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER | > - DEV_RX_OFFLOAD_VLAN_EXTEND); > + offloads |=3D DEV_RX_OFFLOAD_VLAN_EXTEND; >=20 > /* > * RSC is only supported by 82599 and x540 PF devices in a non-SR- > IOV > -- > 2.19.1