From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 74773A00E6 for ; Mon, 18 Mar 2019 05:59:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2821B1DBD; Mon, 18 Mar 2019 05:59:40 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id EF3A7239 for ; Mon, 18 Mar 2019 05:59:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Mar 2019 21:59:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,492,1544515200"; d="scan'208";a="283544028" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 17 Mar 2019 21:59:36 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 17 Mar 2019 21:59:36 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.74]) with mapi id 14.03.0415.000; Mon, 18 Mar 2019 12:59:34 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , David Harton , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf Thread-Index: AQHU20lkjxlJiBS/6k2UtHRw1oCzyqYQMhkAgACl++A= Date: Mon, 18 Mar 2019 04:59:34 +0000 Message-ID: <039ED4275CED7440929022BC67E706115334E21B@SHSMSX103.ccr.corp.intel.com> References: <20190315122650.11660-1-dharton@cisco.com> <20190315160832.34127-1-dharton@cisco.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTA0ZjgzZjktOTgwMC00ODc0LWI4NzEtNjU2ZjY1OGY4ZWNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTFMyRlNaSjlYMFNxYlN0Vlo2NFNJUTFCWU92RDViU3hlNUFsUHAyOERzaHJmRzZ2aVFQaU9VaHFjXC8xMGNaRHUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190318045934.7VVDU0s8C_0wkIRReG4IgiDHEaodWTy0DRSfrNXp-Cs@z> > -----Original Message----- > From: Zhao1, Wei > Sent: Monday, March 18, 2019 11:05 AM > To: David Harton ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixg= bevf >=20 > Acked-by: Wei Zhao Applied to dpdk-next-net-intel. Thanks Qi >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Harton > > Sent: Saturday, March 16, 2019 12:09 AM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > ; Zhang, Qi Z ; > > David Harton > > Subject: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for > > ixgbevf > > > > ixgbevf vlan strip and extend capabilities were removed when migrating > > to the bit flags implementation. > > > > Restoring the capbility to enable the vlan strip offload at configurati= on time. > > > > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") > > Signed-off-by: David Harton > > --- > > > > v4: fixed commit headline/log > > v3: restored ixgbe_is_vf() and only restore VLAN_FILTER > > v2: removed unused function ixgbe_is_vf() > > > > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > > b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..e71d3c188 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -2853,14 +2853,14 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev > > *dev) > > DEV_RX_OFFLOAD_TCP_CKSUM | > > DEV_RX_OFFLOAD_KEEP_CRC | > > DEV_RX_OFFLOAD_JUMBO_FRAME | > > + DEV_RX_OFFLOAD_VLAN_FILTER | > > DEV_RX_OFFLOAD_SCATTER; > > > > if (hw->mac.type =3D=3D ixgbe_mac_82598EB) > > offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; > > > > if (ixgbe_is_vf(dev) =3D=3D 0) > > - offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER | > > - DEV_RX_OFFLOAD_VLAN_EXTEND); > > + offloads |=3D DEV_RX_OFFLOAD_VLAN_EXTEND; > > > > /* > > * RSC is only supported by 82599 and x540 PF devices in a non-SR- > > IOV > > -- > > 2.19.1