From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id DCEF62C60 for ; Mon, 18 Mar 2019 16:01:55 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id v21so11429183pfm.12 for ; Mon, 18 Mar 2019 08:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v1detqFCDgFcW96juKnIBemEjEMncSe+hkwud8UnVX0=; b=Z3VTFYoX9qMlW1W6PE7zQARjoD/rIY+lZzedrHwRSZ67/8BiLdLTgsVUJM4vSjrAbb rMEeZ/Wc+CCSuiSDi2xT0UCzxkBndeo8r5d6W8SaMD0zjTVPqqoHgzqvCTNJrBE/WTBV YKjHbTEzjvhAokdyIgF5vbrN2W1tPRYxMtir3EuJFW8OV1VLxDtfCJeie+jIWNq2LC+r 4jlx+rRsYpVrSjMP8lWgfWMbppXDUDZWfZ5BjK52eoQhdyVDYstA+tlDlreLKHE9GJiI gqy/OkIIqMoObaZZXNqKDFlSWu7U3EI+gijIIoMzSSJD3Mw0f7V60DNr6egee9FkYLrr dWwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v1detqFCDgFcW96juKnIBemEjEMncSe+hkwud8UnVX0=; b=E/F3ki5v7/WgxSw+jB7nCiCWOL39Nj6Yjd5Qid19NtveXbU5SxpHVeJCLErU63JOWr SZksEscSmFug44Pt7HhmRrr6CUcxT0knjgR07+lnpzUZKkRItkOW6H5kYLCf484kI5hV 3ilT+MxKmAfEard0nGKhbJgjlRhIkzgFM8L4ZxMjFVzTM2XO8GTe3FEbuWES1uONMgpn 2wOYs7OseOqo5XMlqT7DII+ILpGZ92z3/2eCsUvG6+jmvSxGEHiBODnrVRdZPwYxctik oYFsVmpXVgRLu/vtzf13rdKQgYeTX6uGYQ4+LSpJlOBxGSV859CSMjOXEUfPqNZ2wEUs Sw+w== X-Gm-Message-State: APjAAAU+2JLXv3UYOVKQMZyyILxykEqon60k79r0GgzBbnhYsczYPOCi /LaP0JmahTpTgyRz0zT8acm/gg== X-Google-Smtp-Source: APXvYqyqZ+dFGLhzoyBBd7OXb5FWMg2KJ9h+FGd3dtQHzN9kQ6NUstr0HvJl06V4IiiYtf/j1GBgZA== X-Received: by 2002:a17:902:681:: with SMTP id 1mr13502752plh.31.1552921314913; Mon, 18 Mar 2019 08:01:54 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id g2sm25414490pfm.144.2019.03.18.08.01.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Mar 2019 08:01:54 -0700 (PDT) Date: Mon, 18 Mar 2019 08:01:50 -0700 From: Stephen Hemminger To: Hajkowski Cc: david.hunt@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20190318080150.62154337@shemminger-XPS-13-9360> In-Reply-To: <20190318115647.14784-1-marcinx.hajkowski@intel.com> References: <20190318115647.14784-1-marcinx.hajkowski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/4] power: fix non thread-safe power env modification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Mar 2019 15:01:56 -0000 On Mon, 18 Mar 2019 12:56:44 +0100 Hajkowski wrote: > From: Marcin Hajkowski > > Due to lack of thread safety in exisiting solution > use spinlock mechanism for atomic > modification of power environment related data. > > Fixes: 445c6528b5 ("power: common interface for guest and host") > Cc: stable@dpdk.org > > Signed-off-by: Marcin Hajkowski Thanks for making this library better. When I did the dpdk-metrics investigation at the US DPDK summit, the power library was one of the DPDK libraries that no upstream open source project uses. You might want to consider: * why is no project using it? what is wrong? * does it not fit any use case in any project should it continue? * if it is for a non-open source customer, then why is it part of DPDK? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9838DA05FE for ; Mon, 18 Mar 2019 16:01:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 917FD324D; Mon, 18 Mar 2019 16:01:57 +0100 (CET) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id DCEF62C60 for ; Mon, 18 Mar 2019 16:01:55 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id v21so11429183pfm.12 for ; Mon, 18 Mar 2019 08:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v1detqFCDgFcW96juKnIBemEjEMncSe+hkwud8UnVX0=; b=Z3VTFYoX9qMlW1W6PE7zQARjoD/rIY+lZzedrHwRSZ67/8BiLdLTgsVUJM4vSjrAbb rMEeZ/Wc+CCSuiSDi2xT0UCzxkBndeo8r5d6W8SaMD0zjTVPqqoHgzqvCTNJrBE/WTBV YKjHbTEzjvhAokdyIgF5vbrN2W1tPRYxMtir3EuJFW8OV1VLxDtfCJeie+jIWNq2LC+r 4jlx+rRsYpVrSjMP8lWgfWMbppXDUDZWfZ5BjK52eoQhdyVDYstA+tlDlreLKHE9GJiI gqy/OkIIqMoObaZZXNqKDFlSWu7U3EI+gijIIoMzSSJD3Mw0f7V60DNr6egee9FkYLrr dWwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v1detqFCDgFcW96juKnIBemEjEMncSe+hkwud8UnVX0=; b=E/F3ki5v7/WgxSw+jB7nCiCWOL39Nj6Yjd5Qid19NtveXbU5SxpHVeJCLErU63JOWr SZksEscSmFug44Pt7HhmRrr6CUcxT0knjgR07+lnpzUZKkRItkOW6H5kYLCf484kI5hV 3ilT+MxKmAfEard0nGKhbJgjlRhIkzgFM8L4ZxMjFVzTM2XO8GTe3FEbuWES1uONMgpn 2wOYs7OseOqo5XMlqT7DII+ILpGZ92z3/2eCsUvG6+jmvSxGEHiBODnrVRdZPwYxctik oYFsVmpXVgRLu/vtzf13rdKQgYeTX6uGYQ4+LSpJlOBxGSV859CSMjOXEUfPqNZ2wEUs Sw+w== X-Gm-Message-State: APjAAAU+2JLXv3UYOVKQMZyyILxykEqon60k79r0GgzBbnhYsczYPOCi /LaP0JmahTpTgyRz0zT8acm/gg== X-Google-Smtp-Source: APXvYqyqZ+dFGLhzoyBBd7OXb5FWMg2KJ9h+FGd3dtQHzN9kQ6NUstr0HvJl06V4IiiYtf/j1GBgZA== X-Received: by 2002:a17:902:681:: with SMTP id 1mr13502752plh.31.1552921314913; Mon, 18 Mar 2019 08:01:54 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id g2sm25414490pfm.144.2019.03.18.08.01.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Mar 2019 08:01:54 -0700 (PDT) Date: Mon, 18 Mar 2019 08:01:50 -0700 From: Stephen Hemminger To: Hajkowski Cc: david.hunt@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20190318080150.62154337@shemminger-XPS-13-9360> In-Reply-To: <20190318115647.14784-1-marcinx.hajkowski@intel.com> References: <20190318115647.14784-1-marcinx.hajkowski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/4] power: fix non thread-safe power env modification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190318150150.LQwfr_PfOBHVaAWiMHg2ZkE4CRW7oGH3zhlr4JvJbgA@z> On Mon, 18 Mar 2019 12:56:44 +0100 Hajkowski wrote: > From: Marcin Hajkowski > > Due to lack of thread safety in exisiting solution > use spinlock mechanism for atomic > modification of power environment related data. > > Fixes: 445c6528b5 ("power: common interface for guest and host") > Cc: stable@dpdk.org > > Signed-off-by: Marcin Hajkowski Thanks for making this library better. When I did the dpdk-metrics investigation at the US DPDK summit, the power library was one of the DPDK libraries that no upstream open source project uses. You might want to consider: * why is no project using it? what is wrong? * does it not fit any use case in any project should it continue? * if it is for a non-open source customer, then why is it part of DPDK?