From: Stephen Hemminger <stephen@networkplumber.org>
To: olegpoly123 <olegp123@walla.co.il>
Cc: keith.wiles@intel.com, thomas@monjalon.net, dev@dpdk.org,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6] net/tap: fix missing _SC_IOV_MAX
Date: Mon, 18 Mar 2019 10:56:36 -0700 [thread overview]
Message-ID: <20190318105636.2a96f3ab@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20190318165523.4086-1-olegp123@walla.co.il>
On Mon, 18 Mar 2019 12:55:23 -0400
olegpoly123 <olegp123@walla.co.il> wrote:
> long iov_max = sysconf(_SC_IOV_MAX);
> +
> + if (iov_max <= 0) {
> + TAP_LOG(WARNING,
> + "_SC_IOV_MAX is not defined. Using %d as default\n",
> + TAP_IOV_DEFAULT_MAX);
> + iov_max = TAP_IOV_DEFAULT_MAX;
> + }
> uint16_t nb_desc = RTE_MIN(nb_rx_desc, iov_max - 1);
Looking at this a little more carefully.
1. Trivial: TAP_LOG() already adds a newline.
2. TAP device should not be silently reducing the number of receive descriptors.
3. TAP device be using IOV_MAX to set rx_descriptor limit. (in dev_info)
The ethdev would rx_queue_setup with any request for too large a value.
next prev parent reply other threads:[~2019-03-18 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 16:55 olegpoly123
2019-03-18 16:55 ` olegpoly123
2019-03-18 17:56 ` Stephen Hemminger [this message]
2019-03-18 17:56 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318105636.2a96f3ab@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=olegp123@walla.co.il \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).