DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
To: dev@dpdk.org
Cc: reshma.pattan@intel.com, jananeex.m.parthasarathy@intel.com,
	rmody@marvell.com, shshaikh@marvell.com, beilei.xing@intel.com,
	qi.z.zhang@intel.com,
	Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>,
	stable@dpdk.org
Subject: [dpdk-dev] [PATCH v7] drivers/net: fix possible overflow using strlcat
Date: Mon, 18 Mar 2019 12:41:10 +0000	[thread overview]
Message-ID: <1552912870-3526-1-git-send-email-tallurix.chaitanya.babu@intel.com> (raw)
Message-ID: <20190318124110.LIMnv8VAw6H6Y02n2TfG1Boe3CmtF2f6OXAtQA9UfV0@z> (raw)
In-Reply-To: <1552570471-32372-1-git-send-email-tallurix.chaitanya.babu@intel.com>

strcat does not check the destination length and there might be
chances of string overflow so instead of strcat, strlcat is used.

Fixes: 540a211084 ("bnx2x: driver core")
Fixes: e163c18a15 ("net/i40e: update ptype and pctype info")
Cc: stable@dpdk.org

Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
---
v7: Corrected title.
v6: Updated title.
v5: Removed strcat.
v4: Corrected usage of strlcat.
v3: Instead of strncat, used strlcat.
v2: Instead of strncat, used snprintf.
---
 drivers/net/bnx2x/bnx2x.c      | 5 +++--
 drivers/net/i40e/i40e_ethdev.c | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 26b3828e8..fe0db021c 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -25,6 +25,7 @@
 #include <sys/stat.h>
 #include <fcntl.h>
 #include <zlib.h>
+#include <rte_string_fns.h>
 
 #define BNX2X_PMD_VER_PREFIX "BNX2X PMD"
 #define BNX2X_PMD_VERSION_MAJOR 1
@@ -11741,13 +11742,13 @@ static const char *get_bnx2x_flags(uint32_t flags)
 
 	for (i = 0; i < 5; i++)
 		if (flags & (1 << i)) {
-			strcat(flag_str, flag[i]);
+			strlcat(flag_str, flag[i], sizeof(flag_str))
 			flags ^= (1 << i);
 		}
 	if (flags) {
 		static char unknown[BNX2X_INFO_STR_MAX];
 		snprintf(unknown, 32, "Unknown flag mask %x", flags);
-		strcat(flag_str, unknown);
+		strlcat(flag_str, unknown, sizeof(flag_str));
 	}
 	return flag_str;
 }
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index dca61f03a..9bc9a4390 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12201,8 +12201,8 @@ i40e_update_customized_pctype(struct rte_eth_dev *dev, uint8_t *pkg,
 			for (n = 0; n < proto_num; n++) {
 				if (proto[n].proto_id != proto_id)
 					continue;
-				strcat(name, proto[n].name);
-				strcat(name, "_");
+				strlcat(name, proto[n].name, sizeof(name));
+				strlcat(name, "_", sizeof(name));
 				break;
 			}
 		}
-- 
2.17.2


  parent reply	other threads:[~2019-03-18 12:42 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  6:04 [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat Chaitanya Babu Talluri
2019-01-14 13:29 ` Ferruh Yigit
2019-01-14 16:24   ` Stephen Hemminger
2019-01-17 16:44     ` Thomas Monjalon
2019-01-14 14:21 ` Bruce Richardson
2019-01-15  1:53   ` Thomas Monjalon
2019-01-18 15:11 ` [dpdk-dev] [PATCH v2] " Chaitanya Babu Talluri
2019-01-18 15:23 ` Chaitanya Babu Talluri
2019-01-21 10:43   ` Parthasarathy, JananeeX M
2019-02-07 11:56     ` Ferruh Yigit
2019-02-07 12:08       ` Thomas Monjalon
2019-02-07 13:27       ` Bruce Richardson
2019-02-13 11:54         ` Ferruh Yigit
2019-02-27  6:02   ` [dpdk-dev] [PATCH v3] drivers: fix to replace strcat with strlcat Chaitanya Babu Talluri
2019-02-27  9:43     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-02-27  9:49     ` [dpdk-dev] " Bruce Richardson
2019-02-27 10:26     ` Pattan, Reshma
2019-03-05 13:14     ` [dpdk-dev] [PATCH v4] drivers: fix possible overflow with strcat Chaitanya Babu Talluri
2019-03-06 18:14       ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-07 12:56       ` [dpdk-dev] [PATCH v5] " Chaitanya Babu Talluri
2019-03-13 18:39         ` Ferruh Yigit
2019-03-14 13:34         ` [dpdk-dev] [PATCH v6] drivers/net: " Chaitanya Babu Talluri
2019-03-14 13:34           ` Chaitanya Babu Talluri
2019-03-14 14:09           ` Pattan, Reshma
2019-03-14 14:09             ` Pattan, Reshma
2019-03-18 12:41           ` Chaitanya Babu Talluri [this message]
2019-03-18 12:41             ` [dpdk-dev] [PATCH v7] drivers/net: fix possible overflow using strlcat Chaitanya Babu Talluri
2019-03-20 20:18             ` Ferruh Yigit
2019-03-20 20:18               ` Ferruh Yigit
2019-03-22  7:51             ` [dpdk-dev] [PATCH v8] " Chaitanya Babu Talluri
2019-03-22  7:51               ` Chaitanya Babu Talluri
2019-03-22  8:02               ` [dpdk-dev] [EXT] " Shahed Shaikh
2019-03-22  8:02                 ` Shahed Shaikh
2019-03-22 10:35                 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-22 10:35                   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1552912870-3526-1-git-send-email-tallurix.chaitanya.babu@intel.com \
    --to=tallurix.chaitanya.babu@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jananeex.m.parthasarathy@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=rmody@marvell.com \
    --cc=shshaikh@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).