From: Stephen Hemminger <stephen@networkplumber.org>
To: Hajkowski <marcinx.hajkowski@intel.com>
Cc: david.hunt@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/4] power: fix non thread-safe power env modification
Date: Mon, 18 Mar 2019 08:01:50 -0700 [thread overview]
Message-ID: <20190318080150.62154337@shemminger-XPS-13-9360> (raw)
Message-ID: <20190318150150.LQwfr_PfOBHVaAWiMHg2ZkE4CRW7oGH3zhlr4JvJbgA@z> (raw)
In-Reply-To: <20190318115647.14784-1-marcinx.hajkowski@intel.com>
On Mon, 18 Mar 2019 12:56:44 +0100
Hajkowski <marcinx.hajkowski@intel.com> wrote:
> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
>
> Due to lack of thread safety in exisiting solution
> use spinlock mechanism for atomic
> modification of power environment related data.
>
> Fixes: 445c6528b5 ("power: common interface for guest and host")
> Cc: stable@dpdk.org
>
> Signed-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
Thanks for making this library better.
When I did the dpdk-metrics investigation at the US DPDK summit, the power
library was one of the DPDK libraries that no upstream open source project
uses.
You might want to consider:
* why is no project using it? what is wrong?
* does it not fit any use case in any project should it continue?
* if it is for a non-open source customer, then why is it part of DPDK?
next prev parent reply other threads:[~2019-03-18 15:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 11:56 Hajkowski
2019-03-18 11:56 ` Hajkowski
2019-03-18 11:56 ` [dpdk-dev] [PATCH v2 2/4] power: return error in set env when power env already set Hajkowski
2019-03-18 11:56 ` Hajkowski
2019-03-19 10:57 ` Burakov, Anatoly
2019-03-19 10:57 ` Burakov, Anatoly
2019-03-18 11:56 ` [dpdk-dev] [PATCH v2 3/4] power: reset function pointers on unset env Hajkowski
2019-03-18 11:56 ` Hajkowski
2019-03-19 10:58 ` Burakov, Anatoly
2019-03-19 10:58 ` Burakov, Anatoly
2019-03-18 11:56 ` [dpdk-dev] [PATCH v2 4/4] power: add UTs for all power env types Hajkowski
2019-03-18 11:56 ` Hajkowski
2019-03-19 11:58 ` Burakov, Anatoly
2019-03-19 11:58 ` Burakov, Anatoly
2019-03-18 15:01 ` Stephen Hemminger [this message]
2019-03-18 15:01 ` [dpdk-dev] [PATCH v2 1/4] power: fix non thread-safe power env modification Stephen Hemminger
2019-03-19 10:57 ` Burakov, Anatoly
2019-03-19 10:57 ` Burakov, Anatoly
2019-03-29 14:14 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-03-29 14:14 ` Thomas Monjalon
2019-03-29 15:09 ` Burakov, Anatoly
2019-03-29 15:09 ` Burakov, Anatoly
2020-10-25 18:22 ` Thomas Monjalon
2020-10-28 13:53 ` David Hunt
2020-10-28 14:16 ` Thomas Monjalon
2019-04-05 14:35 ` [dpdk-dev] [PATCH] " Hajkowski
2019-04-05 14:35 ` Hajkowski
2019-04-22 20:22 ` Thomas Monjalon
2019-04-22 20:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318080150.62154337@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=marcinx.hajkowski@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).