DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ayuj Verma <ayverma@marvell.com>
To: Akhil Goyal <akhil.goyal@nxp.com>,
	"arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>
Cc: "arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>,
	"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
	Shally Verma <shallyv@marvell.com>,
	Sunila Sahu <ssahu@marvell.com>,
	"Kanaka Durga Kotamarthy" <kkotamarthy@marvell.com>,
	Arvind Desai <adesai@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/cryptodev: add rsa priv key feature flag
Date: Mon, 18 Mar 2019 18:05:39 +0000	[thread overview]
Message-ID: <MN2PR18MB2542367430FB41660275C105AD470@MN2PR18MB2542.namprd18.prod.outlook.com> (raw)
Message-ID: <20190318180539.Q_agzqLUHSSQtxqC6IVcqSRoxYoKOY4l4LFVSSir6sQ@z> (raw)
In-Reply-To: <8c957bd1-51f9-e9b6-4114-361a620f7933@nxp.com>

Hi Akhil, Arek,

Sure, I'll rebase the patch and will send v3 along with doc changes.

Thanks and regards
Ayuj Verma

-----Original Message-----
From: Akhil Goyal <akhil.goyal@nxp.com> 
Sent: Sunday, March 17, 2019 11:17 PM
To: Ayuj Verma <ayverma@marvell.com>
Cc: arkadiuszx.kusztal@intel.com; fiona.trahe@intel.com; Shally Verma <shallyv@marvell.com>; Sunila Sahu <ssahu@marvell.com>; Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>; Arvind Desai <adesai@marvell.com>; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/cryptodev: add rsa priv key feature flag

Hi Ayuj,

On 2/27/2019 7:03 PM, Ayuj Verma wrote:
> Add feature flag to reflect RSA private key operation support using 
> quintuple (crt) or exponent type key. if PMD support both, then it 
> should set both.
>
> App should query cryptodev feature flag to check if Sign and Decryt 
> with CRT keys or exponent is supported, thus call operation with 
> relevant key type.
>
> Signed-off-by: Ayuj Verma <ayverma@marvell.com>
> Signed-off-by: Shally Verma <shallyv@marvell.com>
> ---
>   lib/librte_cryptodev/rte_cryptodev.c | 4 ++++
>   lib/librte_cryptodev/rte_cryptodev.h | 4 ++++
>   2 files changed, 8 insertions(+)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.c 
> b/lib/librte_cryptodev/rte_cryptodev.c
> index 700973530..bb90ac939 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.c
> +++ b/lib/librte_cryptodev/rte_cryptodev.c
> @@ -486,6 +486,10 @@ rte_cryptodev_get_feature_name(uint64_t flag)
>   		return "CPU_ARM_CE";
>   	case RTE_CRYPTODEV_FF_SECURITY:
>   		return "SECURITY_PROTOCOL";
> +	case RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP:
> +		return "RSA_PRIV_OP_KEY_EXP";
> +	case RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT:
> +		return "RSA_PRIV_OP_KEY_QT";
>   	default:
>   		return NULL;
>   	}
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h 
> b/lib/librte_cryptodev/rte_cryptodev.h
> index a0bbcf932..298b35217 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -438,6 +438,10 @@ rte_cryptodev_asym_get_xform_enum(enum rte_crypto_asym_xform_type *xform_enum,
>   /**< Utilises ARM CPU Cryptographic Extensions */
>   #define	RTE_CRYPTODEV_FF_SECURITY			(1ULL << 16)
>   /**< Support Security Protocol Processing */
> +#define RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP		(1ULL << 17)
> +/**< Support RSA Private Key OP with exponent */
> +#define RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT		(1ULL << 18)
> +/**< Support RSA Private Key OP with CRT (quintuple) Keys */
I believe these feature flags should be explained a bit in the
documentation(doc/guides/cryptodevs/)
>   
>   
>   /**


  parent reply	other threads:[~2019-03-18 18:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-27 13:33 [dpdk-dev] [PATCH v2 0/3] adding " Ayuj Verma
2019-02-27 13:33 ` [dpdk-dev] [PATCH v2 1/3] lib/cryptodev: add " Ayuj Verma
2019-03-17 17:46   ` Akhil Goyal
2019-03-17 17:46     ` Akhil Goyal
2019-03-18 18:05     ` Ayuj Verma [this message]
2019-03-18 18:05       ` Ayuj Verma
2019-02-27 13:33 ` [dpdk-dev] [PATCH v2 2/3] crypto/openssl: set rsa private op " Ayuj Verma
2019-02-27 13:33 ` [dpdk-dev] [PATCH v2 3/3] test/crypto: check for rsa key type " Ayuj Verma
2019-03-17 17:49   ` Akhil Goyal
2019-03-17 17:49     ` Akhil Goyal
2019-03-05  9:11 ` [dpdk-dev] [PATCH v2 0/3] adding rsa priv key " Ayuj Verma
2019-03-13  7:29   ` Ayuj Verma
2019-03-13 19:02     ` Kusztal, ArkadiuszX
2019-03-13 19:06 ` Kusztal, ArkadiuszX
2019-03-13 19:06   ` Kusztal, ArkadiuszX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR18MB2542367430FB41660275C105AD470@MN2PR18MB2542.namprd18.prod.outlook.com \
    --to=ayverma@marvell.com \
    --cc=adesai@marvell.com \
    --cc=akhil.goyal@nxp.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=kkotamarthy@marvell.com \
    --cc=shallyv@marvell.com \
    --cc=ssahu@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).