From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 3C4B0A00E6
	for <public@inbox.dpdk.org>; Tue, 19 Mar 2019 10:40:52 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id EB6622956;
	Tue, 19 Mar 2019 10:40:50 +0100 (CET)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id C9F0111A4
 for <dev@dpdk.org>; Tue, 19 Mar 2019 10:40:49 +0100 (CET)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 19 Mar 2019 02:40:48 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.58,497,1544515200"; d="scan'208";a="135282220"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35])
 by orsmga003.jf.intel.com with SMTP; 19 Mar 2019 02:40:45 -0700
Received: by  (sSMTP sendmail emulation); Tue, 19 Mar 2019 09:40:44 +0000
Date: Tue, 19 Mar 2019 09:40:43 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>,
 "gavin.hu@arm.com" <gavin.hu@arm.com>,
 Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Message-ID: <20190319094043.GA318652@bricha3-MOBL.ger.corp.intel.com>
References: <20190224181041.27127-1-jerinj@marvell.com>
 <20190318164949.2357-1-jerinj@marvell.com>
 <20190318164949.2357-2-jerinj@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
In-Reply-To: <20190318164949.2357-2-jerinj@marvell.com>
User-Agent: Mutt/1.11.2 (2019-01-07)
Subject: Re: [dpdk-dev] [PATCH v6 2/4] meson: add infra to support machine
 specific flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190319094043.hcSayqURfeWLNwm-o2V0YmIrjxFyKYZWz7VuEv4kF_s@z>

On Mon, Mar 18, 2019 at 04:50:16PM +0000, Jerin Jacob Kollanukkaran wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Currently, RTE_* flags are set based on the implementer ID but there might
> be some micro arch specific differences from the same vendor
> eg. CACHE_LINESIZE. Add support to set micro arch specific flags.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  config/arm/meson.build | 37 ++++++++++++++++++++++++++++++++-----
>  1 file changed, 32 insertions(+), 5 deletions(-)
> 
This looks ok to me, but I think review and ack from another Arm vendor
would be good to have.

/Bruce