From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9B7AF1B19 for ; Tue, 19 Mar 2019 10:50:34 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 02:50:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,497,1544515200"; d="scan'208";a="132822490" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga008.fm.intel.com with SMTP; 19 Mar 2019 02:50:31 -0700 Received: by (sSMTP sendmail emulation); Tue, 19 Mar 2019 09:50:30 +0000 Date: Tue, 19 Mar 2019 09:50:29 +0000 From: Bruce Richardson To: Luca Boccassi Cc: Jerin Jacob Kollanukkaran , Thomas Monjalon , "dev@dpdk.org" Message-ID: <20190319095029.GB318652@bricha3-MOBL.ger.corp.intel.com> References: <20190318162804.28974-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH] meson: remove build warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2019 09:50:35 -0000 On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote: > On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote: > > From: Jerin Jacob > > > > Remove the following meson build warnings > > > > 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1' > > but uses features which were added in newer versions: > > * 0.48.0: {'console arg in custom_target'} > > > > 2) config/arm/meson.build:153: WARNING: Trying to compare values of > > different types (list, str) using ==. > > > > Signed-off-by: Jerin Jacob > > --- > > config/arm/meson.build | 4 ++-- > > meson.build | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > index 8e892fa77..170a4981a 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > @@ -116,8 +116,8 @@ else > > cmd_output = > > cmd.stdout().to_lower().strip().split(' ') > > endif > > # Set to generic if variable is not found > > - machine = get_variable('impl_' + cmd_output[0], > > 'generic') > > - if machine == 'generic' > > + machine = get_variable('impl_' + cmd_output[0], > > ['generic']) > > + if machine[0] == 'generic' > > machine = impl_generic > > cmd_output = cmd_generic > > endif > > diff --git a/meson.build b/meson.build > > index 69833de82..f1abf1e59 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -5,7 +5,7 @@ project('DPDK', 'C', > > version: '19.05.0-rc0', > > license: 'BSD', > > default_options: ['buildtype=release', > > 'default_library=static'], > > - meson_version: '>= 0.47.1' > > + meson_version: '>= 0.48.0' > > ) > > > > # set up some global vars for compiler, platform, configuration, > > etc. > > Bumping minimum dependency requirements needs an approval from the tech > board. Incidentally we just got it, and the bump to 0.47.1 just > happened. > > You can remove this and ignore the warning about the console arg - it's > harmless if ran on a previous version which does not support it. > +1 to this. The first fix is good though - perhaps do a V2 with just that. Sadly meson warnings for versions have too many false positives right now - the devs are aware of it, but don't have any good fixes for it yet, as far as I know. For our case, we will continue to have meson warnings, most of which are false positives like this one. Regards, /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 21E52A00E6 for ; Tue, 19 Mar 2019 10:50:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B8A52BAF; Tue, 19 Mar 2019 10:50:36 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9B7AF1B19 for ; Tue, 19 Mar 2019 10:50:34 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 02:50:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,497,1544515200"; d="scan'208";a="132822490" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga008.fm.intel.com with SMTP; 19 Mar 2019 02:50:31 -0700 Received: by (sSMTP sendmail emulation); Tue, 19 Mar 2019 09:50:30 +0000 Date: Tue, 19 Mar 2019 09:50:29 +0000 From: Bruce Richardson To: Luca Boccassi Cc: Jerin Jacob Kollanukkaran , Thomas Monjalon , "dev@dpdk.org" Message-ID: <20190319095029.GB318652@bricha3-MOBL.ger.corp.intel.com> References: <20190318162804.28974-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH] meson: remove build warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190319095029.FR_KvLluZ-DTKNNPApZ2A3VJR7EwNYBng6FN7uiLfXI@z> On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote: > On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote: > > From: Jerin Jacob > > > > Remove the following meson build warnings > > > > 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1' > > but uses features which were added in newer versions: > > * 0.48.0: {'console arg in custom_target'} > > > > 2) config/arm/meson.build:153: WARNING: Trying to compare values of > > different types (list, str) using ==. > > > > Signed-off-by: Jerin Jacob > > --- > > config/arm/meson.build | 4 ++-- > > meson.build | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > index 8e892fa77..170a4981a 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > @@ -116,8 +116,8 @@ else > > cmd_output = > > cmd.stdout().to_lower().strip().split(' ') > > endif > > # Set to generic if variable is not found > > - machine = get_variable('impl_' + cmd_output[0], > > 'generic') > > - if machine == 'generic' > > + machine = get_variable('impl_' + cmd_output[0], > > ['generic']) > > + if machine[0] == 'generic' > > machine = impl_generic > > cmd_output = cmd_generic > > endif > > diff --git a/meson.build b/meson.build > > index 69833de82..f1abf1e59 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -5,7 +5,7 @@ project('DPDK', 'C', > > version: '19.05.0-rc0', > > license: 'BSD', > > default_options: ['buildtype=release', > > 'default_library=static'], > > - meson_version: '>= 0.47.1' > > + meson_version: '>= 0.48.0' > > ) > > > > # set up some global vars for compiler, platform, configuration, > > etc. > > Bumping minimum dependency requirements needs an approval from the tech > board. Incidentally we just got it, and the bump to 0.47.1 just > happened. > > You can remove this and ignore the warning about the console arg - it's > harmless if ran on a previous version which does not support it. > +1 to this. The first fix is good though - perhaps do a V2 with just that. Sadly meson warnings for versions have too many false positives right now - the devs are aware of it, but don't have any good fixes for it yet, as far as I know. For our case, we will continue to have meson warnings, most of which are false positives like this one. Regards, /Bruce