From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 8331F1B19 for ; Tue, 19 Mar 2019 18:54:06 +0100 (CET) Received: by mail-pf1-f194.google.com with SMTP id r15so11469594pfn.9 for ; Tue, 19 Mar 2019 10:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=llSmWiv1Ws575Fy3sFkhOORwG5sMiFj4tcgaYWqkJnw=; b=L/3o7Vyrt4bpkNBPtryDGDaOOSz9ZQoT0yRdGh+KDPHy9SHyENutfFbXVIFZfLu+BW OE2R1hRHpOi5A53eywqqC15oUdES8F2BKsZaS+ruz6337i5kadFQ07Vd70U6KqaMgWS/ yHJFNpzEU1+cmoSYeRm3L3hzp93TxG4eSFQQewZgbMAWTHl8FWbpYvQCJ1qQAjzK6IWE 69rXr9M/rgA0Ud8KEVqT/oPhbyuGroC5i6KpD9Hd3x3zXh9t9BjM2//NnbhuhVAHpUdO 9DeoVxNOaky6FhKIKrKRWmZ4tYQy/2p2Sq2lwmmGOLy83dj8pj5lwUHf2uJtsQjk+vLo Fnfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=llSmWiv1Ws575Fy3sFkhOORwG5sMiFj4tcgaYWqkJnw=; b=eNT7XaA5LTYxtigVbfJSorgfG35tFYeDhHeM8HqCZ9MAW3A0IGai/g3kyn7pbNKKx9 WN+lEvZlLEV6GrPIEZzMCpiaszS4fgXE/GZKdIdzSCUHNQZqyFftHKQRuJuYHENBMRAD n7AdbyD9hKbNNpqSjDMIjyPW2OaAH+aH9dhRACiUat1mx61W3bXq4TYcwNb+WfNJwaZ6 9ONH6+Ep148m7LOzCDMYV98xmSa6Eyxo+ybsAzx89hl4ZSLrMQ3cPSElIdfg6xZmT9fu zuGPUNDK50heQO9bo2WRXUZ+LosfgHWx8WG0VL7gtqftvKYzjmTFDMyXIJ1hc4ruzqx/ sIjg== X-Gm-Message-State: APjAAAWrjd5LK0WyzCkZvwBPpxu+fK294m6xKHbIfEpQUp6vJoCEGXyr 9A+1gBX9/1ycScp3s2l5ehTKGFF/H6+TiA== X-Google-Smtp-Source: APXvYqwfVi06UnqYIeGPmQhAItKeJU55pFSc2bspeyI1CLQpJ97zsSrAFUzad4u2L/k4fjTgX2LJew== X-Received: by 2002:a63:cd10:: with SMTP id i16mr3263293pgg.90.1553018045437; Tue, 19 Mar 2019 10:54:05 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u14sm21264177pfm.66.2019.03.19.10.54.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Mar 2019 10:54:05 -0700 (PDT) Date: Tue, 19 Mar 2019 10:54:01 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: David Marchand , dev@dpdk.org, thomas@monjalon.net, arybchenko@solarflare.com, "Stokes, Ian" Message-ID: <20190319105401.0974a7ac@shemminger-XPS-13-9360> In-Reply-To: References: <1552576396-19906-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2019 17:54:06 -0000 On Tue, 19 Mar 2019 17:18:08 +0000 Ferruh Yigit wrote: > On 3/14/2019 3:13 PM, David Marchand wrote: > > Introduce a new api to retrieve per queue statistics from the drivers. > > The api objectives: > > - easily add some common per queue statistics and have it exposed > > through the user xstats api while the user stats api is left untouched > > - remove the limitations on the per queue statistics count (inherited > > from ixgbe) and avoid recurrent bugs on stats array overflow > > The patch is adding two new dev_ops 'rxq_stats_get' & 'txq_stats_get', my > concern is if it is overkill to have three dev_ops to get stats > and I am feeling that is making xstat code more complex. > > Would it be simpler to add 'q_ierrors' & 'q_oerrors' to 'struct rte_eth_stats'? > > And perhaps we can do the 'fix rxq q_errors' patchset [1] after this change, so > fix can be done with less changes, although it will push the fix into next > release because of the ABI break. > OR ethdev will be broken this release, because of max_mtu, since ABI is already > broken perhaps we can squeeze this in. > > Overall I would like to get more comment on this, Andrew, Thomas? > > > > > Signed-off-by: David Marchand > > <...> > My preference would be: 1. Make all DPDK drivers consistent in usage of current statistic values. 2. Propose an enhancement to have new ethdev statistics match some pre-existing standard like SNMP or other RFC. 3. Reduce custom (xstats) values by using #2. Leave it for driver specific stuff. I.e: don't modify existing API at all, make a new one. PS: ethdev is one of those structures that needs to get removed/hidden from application headers. It should be possible to add/remove stuff from ethdev internals, device and bus without breaking API/ABI. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 521D6A00E6 for ; Tue, 19 Mar 2019 18:54:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E7051DBD; Tue, 19 Mar 2019 18:54:08 +0100 (CET) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 8331F1B19 for ; Tue, 19 Mar 2019 18:54:06 +0100 (CET) Received: by mail-pf1-f194.google.com with SMTP id r15so11469594pfn.9 for ; Tue, 19 Mar 2019 10:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=llSmWiv1Ws575Fy3sFkhOORwG5sMiFj4tcgaYWqkJnw=; b=L/3o7Vyrt4bpkNBPtryDGDaOOSz9ZQoT0yRdGh+KDPHy9SHyENutfFbXVIFZfLu+BW OE2R1hRHpOi5A53eywqqC15oUdES8F2BKsZaS+ruz6337i5kadFQ07Vd70U6KqaMgWS/ yHJFNpzEU1+cmoSYeRm3L3hzp93TxG4eSFQQewZgbMAWTHl8FWbpYvQCJ1qQAjzK6IWE 69rXr9M/rgA0Ud8KEVqT/oPhbyuGroC5i6KpD9Hd3x3zXh9t9BjM2//NnbhuhVAHpUdO 9DeoVxNOaky6FhKIKrKRWmZ4tYQy/2p2Sq2lwmmGOLy83dj8pj5lwUHf2uJtsQjk+vLo Fnfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=llSmWiv1Ws575Fy3sFkhOORwG5sMiFj4tcgaYWqkJnw=; b=eNT7XaA5LTYxtigVbfJSorgfG35tFYeDhHeM8HqCZ9MAW3A0IGai/g3kyn7pbNKKx9 WN+lEvZlLEV6GrPIEZzMCpiaszS4fgXE/GZKdIdzSCUHNQZqyFftHKQRuJuYHENBMRAD n7AdbyD9hKbNNpqSjDMIjyPW2OaAH+aH9dhRACiUat1mx61W3bXq4TYcwNb+WfNJwaZ6 9ONH6+Ep148m7LOzCDMYV98xmSa6Eyxo+ybsAzx89hl4ZSLrMQ3cPSElIdfg6xZmT9fu zuGPUNDK50heQO9bo2WRXUZ+LosfgHWx8WG0VL7gtqftvKYzjmTFDMyXIJ1hc4ruzqx/ sIjg== X-Gm-Message-State: APjAAAWrjd5LK0WyzCkZvwBPpxu+fK294m6xKHbIfEpQUp6vJoCEGXyr 9A+1gBX9/1ycScp3s2l5ehTKGFF/H6+TiA== X-Google-Smtp-Source: APXvYqwfVi06UnqYIeGPmQhAItKeJU55pFSc2bspeyI1CLQpJ97zsSrAFUzad4u2L/k4fjTgX2LJew== X-Received: by 2002:a63:cd10:: with SMTP id i16mr3263293pgg.90.1553018045437; Tue, 19 Mar 2019 10:54:05 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u14sm21264177pfm.66.2019.03.19.10.54.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Mar 2019 10:54:05 -0700 (PDT) Date: Tue, 19 Mar 2019 10:54:01 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: David Marchand , dev@dpdk.org, thomas@monjalon.net, arybchenko@solarflare.com, "Stokes, Ian" Message-ID: <20190319105401.0974a7ac@shemminger-XPS-13-9360> In-Reply-To: References: <1552576396-19906-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190319175401.xXvpXvCIph4IG61w0utr8Q38oBwscD_YBzJpLzhngJ4@z> On Tue, 19 Mar 2019 17:18:08 +0000 Ferruh Yigit wrote: > On 3/14/2019 3:13 PM, David Marchand wrote: > > Introduce a new api to retrieve per queue statistics from the drivers. > > The api objectives: > > - easily add some common per queue statistics and have it exposed > > through the user xstats api while the user stats api is left untouched > > - remove the limitations on the per queue statistics count (inherited > > from ixgbe) and avoid recurrent bugs on stats array overflow > > The patch is adding two new dev_ops 'rxq_stats_get' & 'txq_stats_get', my > concern is if it is overkill to have three dev_ops to get stats > and I am feeling that is making xstat code more complex. > > Would it be simpler to add 'q_ierrors' & 'q_oerrors' to 'struct rte_eth_stats'? > > And perhaps we can do the 'fix rxq q_errors' patchset [1] after this change, so > fix can be done with less changes, although it will push the fix into next > release because of the ABI break. > OR ethdev will be broken this release, because of max_mtu, since ABI is already > broken perhaps we can squeeze this in. > > Overall I would like to get more comment on this, Andrew, Thomas? > > > > > Signed-off-by: David Marchand > > <...> > My preference would be: 1. Make all DPDK drivers consistent in usage of current statistic values. 2. Propose an enhancement to have new ethdev statistics match some pre-existing standard like SNMP or other RFC. 3. Reduce custom (xstats) values by using #2. Leave it for driver specific stuff. I.e: don't modify existing API at all, make a new one. PS: ethdev is one of those structures that needs to get removed/hidden from application headers. It should be possible to add/remove stuff from ethdev internals, device and bus without breaking API/ABI.