From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140083.outbound.protection.outlook.com [40.107.14.83]) by dpdk.org (Postfix) with ESMTP id E2F89201 for ; Tue, 19 Mar 2019 14:10:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PwKfJhlW87oHPPh+EUyObs6MOEt6CJE7tiYZPhDJCTw=; b=IcvMrCHVfforbXRkFBCyt8PqeIoPgwogIp624JTpK+z4K8Vpvy3KClr39TAaDUjFCr3wdYXF3Dz3aaqNTUirQqExSOoTxy1lrZxffCVhDI4RsPayhNU3E6fXnHsRjbQRZ8v3EXbMShLuTqOwHAGTm4D/L6RXJfvszQ5RSVMQeN4= Received: from VI1PR04MB4688.eurprd04.prod.outlook.com (20.177.56.80) by VI1PR04MB5678.eurprd04.prod.outlook.com (20.178.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.13; Tue, 19 Mar 2019 13:10:55 +0000 Received: from VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::f198:d57:e38d:30]) by VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::f198:d57:e38d:30%4]) with mapi id 15.20.1709.015; Tue, 19 Mar 2019 13:10:55 +0000 From: Shreyansh Jain To: "dev@dpdk.org" CC: Shreyansh Jain Thread-Topic: [PATCH] net/dpaa2: accept packets with checksum error Thread-Index: AQHU3lUvhwWqN2+1EkOKVh9uPSP9bQ== Date: Tue, 19 Mar 2019 13:10:55 +0000 Message-ID: <20190319130947.10302-1-shreyansh.jain@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [92.120.0.8] x-mailer: git-send-email 2.17.1 x-clientproxiedby: BM1PR0101CA0030.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::16) To VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:71::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 40333d23-5620-4ec9-4d4b-08d6ac6c51e9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB5678; x-ms-traffictypediagnostic: VI1PR04MB5678: x-microsoft-antispam-prvs: x-forefront-prvs: 0981815F2F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(39860400002)(366004)(396003)(346002)(189003)(199004)(6486002)(86362001)(81166006)(105586002)(6916009)(2906002)(4744005)(6512007)(1076003)(53936002)(106356001)(8676002)(14454004)(81156014)(1730700003)(478600001)(486006)(44832011)(52116002)(66066001)(2351001)(99286004)(5660300002)(5640700003)(97736004)(2616005)(25786009)(256004)(386003)(7736002)(305945005)(186003)(36756003)(6436002)(4326008)(2501003)(6506007)(316002)(6116002)(71200400001)(26005)(71190400001)(102836004)(476003)(68736007)(50226002)(8936002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5678; H:VI1PR04MB4688.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 1nZq+y1reuodMC/zHNeiXe6rMH6PxqKtPMfFUIKxXAUDYHxiurvto7bDua69Yz/fujZn06y7QKLWzV48CxNSjoDqiSKLF4FHiFjbh/aPc1Ep4vPH+piU5w8d0zAHEJLTkoRYPzEddx/Nc2Wg3DwutMvy6A1z8JnOAppUwtkIAtmQthD53b2B//yllq8esSrQMvPQhopnZ/TYUPwqFM5+0pAP/hmB8GTeFlNy1saG98sF6wwpjmlhW8uuw0hgENxpd8mVr1b+2QwJCOW3qoAstN3dsdQl8JfYiK0MaoJVirQFvXgw6CNBY0RlHngnUqxWPkYZKRfRdgOn4oV7QF0DV5gu5ZibkBxvs/j1vDlBXvS9XMZ96jPqqLrDb4T/n2eMFdsl2dv2coZvjoLOwKYQasH3PyrOYrk+a83YiNMKSWA= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40333d23-5620-4ec9-4d4b-08d6ac6c51e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2019 13:10:55.4896 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5678 Subject: [dpdk-dev] [PATCH] net/dpaa2: accept packets with checksum error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2019 13:10:57 -0000 Until now, DPAA2 driver was configured to drop any packet which was marked as malformed by hardware - which included those with wrong checksum. With this patch, that configuration has been removed - hereafter, all packets arriving on a DPMAC link would be forwarded to a DPNI and further processing would be done as configured for a standard packet path. Signed-off-by: Shreyansh Jain --- drivers/net/dpaa2/dpaa2_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_eth= dev.c index a8f0e3002..c92edecf3 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -879,6 +879,7 @@ dpaa2_dev_start(struct rte_eth_dev *dev) =20 /*checksum errors, send them to normal path and set it in annotation */ err_cfg.errors =3D DPNI_ERROR_L3CE | DPNI_ERROR_L4CE; + err_cfg.errors |=3D DPNI_ERROR_PHE; =20 err_cfg.error_action =3D DPNI_ERROR_ACTION_CONTINUE; err_cfg.set_frame_annotation =3D true; --=20 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 00BB1A00E6 for ; Tue, 19 Mar 2019 14:10:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CA4E11A4; Tue, 19 Mar 2019 14:10:59 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140083.outbound.protection.outlook.com [40.107.14.83]) by dpdk.org (Postfix) with ESMTP id E2F89201 for ; Tue, 19 Mar 2019 14:10:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PwKfJhlW87oHPPh+EUyObs6MOEt6CJE7tiYZPhDJCTw=; b=IcvMrCHVfforbXRkFBCyt8PqeIoPgwogIp624JTpK+z4K8Vpvy3KClr39TAaDUjFCr3wdYXF3Dz3aaqNTUirQqExSOoTxy1lrZxffCVhDI4RsPayhNU3E6fXnHsRjbQRZ8v3EXbMShLuTqOwHAGTm4D/L6RXJfvszQ5RSVMQeN4= Received: from VI1PR04MB4688.eurprd04.prod.outlook.com (20.177.56.80) by VI1PR04MB5678.eurprd04.prod.outlook.com (20.178.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.13; Tue, 19 Mar 2019 13:10:55 +0000 Received: from VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::f198:d57:e38d:30]) by VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::f198:d57:e38d:30%4]) with mapi id 15.20.1709.015; Tue, 19 Mar 2019 13:10:55 +0000 From: Shreyansh Jain To: "dev@dpdk.org" CC: Shreyansh Jain Thread-Topic: [PATCH] net/dpaa2: accept packets with checksum error Thread-Index: AQHU3lUvhwWqN2+1EkOKVh9uPSP9bQ== Date: Tue, 19 Mar 2019 13:10:55 +0000 Message-ID: <20190319130947.10302-1-shreyansh.jain@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [92.120.0.8] x-mailer: git-send-email 2.17.1 x-clientproxiedby: BM1PR0101CA0030.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::16) To VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:71::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 40333d23-5620-4ec9-4d4b-08d6ac6c51e9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB5678; x-ms-traffictypediagnostic: VI1PR04MB5678: x-microsoft-antispam-prvs: x-forefront-prvs: 0981815F2F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(39860400002)(366004)(396003)(346002)(189003)(199004)(6486002)(86362001)(81166006)(105586002)(6916009)(2906002)(4744005)(6512007)(1076003)(53936002)(106356001)(8676002)(14454004)(81156014)(1730700003)(478600001)(486006)(44832011)(52116002)(66066001)(2351001)(99286004)(5660300002)(5640700003)(97736004)(2616005)(25786009)(256004)(386003)(7736002)(305945005)(186003)(36756003)(6436002)(4326008)(2501003)(6506007)(316002)(6116002)(71200400001)(26005)(71190400001)(102836004)(476003)(68736007)(50226002)(8936002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5678; H:VI1PR04MB4688.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 1nZq+y1reuodMC/zHNeiXe6rMH6PxqKtPMfFUIKxXAUDYHxiurvto7bDua69Yz/fujZn06y7QKLWzV48CxNSjoDqiSKLF4FHiFjbh/aPc1Ep4vPH+piU5w8d0zAHEJLTkoRYPzEddx/Nc2Wg3DwutMvy6A1z8JnOAppUwtkIAtmQthD53b2B//yllq8esSrQMvPQhopnZ/TYUPwqFM5+0pAP/hmB8GTeFlNy1saG98sF6wwpjmlhW8uuw0hgENxpd8mVr1b+2QwJCOW3qoAstN3dsdQl8JfYiK0MaoJVirQFvXgw6CNBY0RlHngnUqxWPkYZKRfRdgOn4oV7QF0DV5gu5ZibkBxvs/j1vDlBXvS9XMZ96jPqqLrDb4T/n2eMFdsl2dv2coZvjoLOwKYQasH3PyrOYrk+a83YiNMKSWA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40333d23-5620-4ec9-4d4b-08d6ac6c51e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2019 13:10:55.4896 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5678 Subject: [dpdk-dev] [PATCH] net/dpaa2: accept packets with checksum error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190319131055.xlF-zHJ1tkHAVMtqaJ1fRAQRh_QyxzRB55cK7zQSfC8@z> Until now, DPAA2 driver was configured to drop any packet which was marked as malformed by hardware - which included those with wrong checksum. With this patch, that configuration has been removed - hereafter, all packets arriving on a DPMAC link would be forwarded to a DPNI and further processing would be done as configured for a standard packet path. Signed-off-by: Shreyansh Jain --- drivers/net/dpaa2/dpaa2_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_eth= dev.c index a8f0e3002..c92edecf3 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -879,6 +879,7 @@ dpaa2_dev_start(struct rte_eth_dev *dev) =20 /*checksum errors, send them to normal path and set it in annotation */ err_cfg.errors =3D DPNI_ERROR_L3CE | DPNI_ERROR_L4CE; + err_cfg.errors |=3D DPNI_ERROR_PHE; =20 err_cfg.error_action =3D DPNI_ERROR_ACTION_CONTINUE; err_cfg.set_frame_annotation =3D true; --=20 2.17.1