DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/dpaa2: accept packets with checksum error
@ 2019-03-19 13:10 Shreyansh Jain
  2019-03-19 13:10 ` Shreyansh Jain
  2019-03-21 17:52 ` Ferruh Yigit
  0 siblings, 2 replies; 4+ messages in thread
From: Shreyansh Jain @ 2019-03-19 13:10 UTC (permalink / raw)
  To: dev; +Cc: Shreyansh Jain

Until now, DPAA2 driver was configured to drop any packet which
was marked as malformed by hardware - which included those with
wrong checksum.
With this patch, that configuration has been removed - hereafter,
all packets arriving on a DPMAC link would be forwarded to a DPNI
and further processing would be done as configured for a standard
packet path.

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 drivers/net/dpaa2/dpaa2_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index a8f0e3002..c92edecf3 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -879,6 +879,7 @@ dpaa2_dev_start(struct rte_eth_dev *dev)
 
 	/*checksum errors, send them to normal path and set it in annotation */
 	err_cfg.errors = DPNI_ERROR_L3CE | DPNI_ERROR_L4CE;
+	err_cfg.errors |= DPNI_ERROR_PHE;
 
 	err_cfg.error_action = DPNI_ERROR_ACTION_CONTINUE;
 	err_cfg.set_frame_annotation = true;
-- 
2.17.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH] net/dpaa2: accept packets with checksum error
  2019-03-19 13:10 [dpdk-dev] [PATCH] net/dpaa2: accept packets with checksum error Shreyansh Jain
@ 2019-03-19 13:10 ` Shreyansh Jain
  2019-03-21 17:52 ` Ferruh Yigit
  1 sibling, 0 replies; 4+ messages in thread
From: Shreyansh Jain @ 2019-03-19 13:10 UTC (permalink / raw)
  To: dev; +Cc: Shreyansh Jain

Until now, DPAA2 driver was configured to drop any packet which
was marked as malformed by hardware - which included those with
wrong checksum.
With this patch, that configuration has been removed - hereafter,
all packets arriving on a DPMAC link would be forwarded to a DPNI
and further processing would be done as configured for a standard
packet path.

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 drivers/net/dpaa2/dpaa2_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index a8f0e3002..c92edecf3 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -879,6 +879,7 @@ dpaa2_dev_start(struct rte_eth_dev *dev)
 
 	/*checksum errors, send them to normal path and set it in annotation */
 	err_cfg.errors = DPNI_ERROR_L3CE | DPNI_ERROR_L4CE;
+	err_cfg.errors |= DPNI_ERROR_PHE;
 
 	err_cfg.error_action = DPNI_ERROR_ACTION_CONTINUE;
 	err_cfg.set_frame_annotation = true;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/dpaa2: accept packets with checksum error
  2019-03-19 13:10 [dpdk-dev] [PATCH] net/dpaa2: accept packets with checksum error Shreyansh Jain
  2019-03-19 13:10 ` Shreyansh Jain
@ 2019-03-21 17:52 ` Ferruh Yigit
  2019-03-21 17:52   ` Ferruh Yigit
  1 sibling, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2019-03-21 17:52 UTC (permalink / raw)
  To: Shreyansh Jain, dev

On 3/19/2019 1:10 PM, Shreyansh Jain wrote:
> Until now, DPAA2 driver was configured to drop any packet which
> was marked as malformed by hardware - which included those with
> wrong checksum.
> With this patch, that configuration has been removed - hereafter,
> all packets arriving on a DPMAC link would be forwarded to a DPNI
> and further processing would be done as configured for a standard
> packet path.
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/dpaa2: accept packets with checksum error
  2019-03-21 17:52 ` Ferruh Yigit
@ 2019-03-21 17:52   ` Ferruh Yigit
  0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2019-03-21 17:52 UTC (permalink / raw)
  To: Shreyansh Jain, dev

On 3/19/2019 1:10 PM, Shreyansh Jain wrote:
> Until now, DPAA2 driver was configured to drop any packet which
> was marked as malformed by hardware - which included those with
> wrong checksum.
> With this patch, that configuration has been removed - hereafter,
> all packets arriving on a DPMAC link would be forwarded to a DPNI
> and further processing would be done as configured for a standard
> packet path.
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-21 17:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 13:10 [dpdk-dev] [PATCH] net/dpaa2: accept packets with checksum error Shreyansh Jain
2019-03-19 13:10 ` Shreyansh Jain
2019-03-21 17:52 ` Ferruh Yigit
2019-03-21 17:52   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).