[dpdk-dev] [PATCH v2 0/3] crypotodev: add result field to modular operations

[dpdk-dev] [PATCH v2 0/3] crypotodev: add result field to modular operations

[Arek Kusztal]

This patchset adds result field to modular exponentiation and modular
inverse operations

This patchset depends on following patches:

[1] - "[v3] cryptodev: rework mod exp and mod inv comments"
(http://patchwork.dpdk.org/patch/50139/)
[2] - "openssl: fix bad reference of modinv"
(http://patchwork.dpdk.org/patch/50131/)

v2:
- fix checkpatch issue

Arek Kusztal (3):
  cryptodev: add result field to mod exp and inverse operations
  openssl: add result field to mod exp and mod inv operations
  test: add result field to mod exp and mod inv

 drivers/crypto/openssl/rte_openssl_pmd.c |  4 ++--
 lib/librte_cryptodev/rte_crypto_asym.h   | 10 ++++++++++
 test/test/test_cryptodev_asym.c          |  6 ++++++
 test/test/test_cryptodev_asym_util.h     |  8 ++++----
 4 files changed, 22 insertions(+), 6 deletions(-)

-- 
2.1.0

[dpdk-dev] [PATCH v2 1/3] cryptodev: add result field to mod exp and inverse operations

[Arek Kusztal]

This commit adds result field to be used when modular exponentiation or
modular multiplicative inverse operation is used

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 lib/librte_cryptodev/rte_crypto_asym.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h
index 0a50cd5..991263f 100644
--- a/lib/librte_cryptodev/rte_crypto_asym.h
+++ b/lib/librte_cryptodev/rte_crypto_asym.h
@@ -339,6 +339,16 @@ struct rte_crypto_mod_op_param {
 	 * be relatively prime to modulus in corresponding Modular
 	 * Multiplicative Inverse rte_crypto_modinv_xform
 	 */
+
+	rte_crypto_param result;
+	/**<
+	 * Pointer to the result of modular exponentiation/multiplicative inverse
+	 * data in octet-string network byte order format.
+	 *
+	 * This field shall be big enough to hold the result of Modular
+	 * Exponentiation or Modular Multplicative Inverse
+	 * (bigger or equal to length of modulus)
+	 */
 };
 
 /**
-- 
2.1.0

Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: add result field to mod exp and inverse operations

[Shally Verma]

>-----Original Message-----
>From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>Sent: 08 February 2019 16:44
>To: dev@dpdk.org
>Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; shally.verma@caviumnetworks.com; Arek Kusztal <arkadiuszx.kusztal@intel.com>
>Subject: [PATCH v2 1/3] cryptodev: add result field to mod exp and inverse operations
>
>External Email
>
>This commit adds result field to be used when modular exponentiation or
>modular multiplicative inverse operation is used
>
>Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>---
Acked-by: Shally Verma <shallyv@marvell.com>

> lib/librte_cryptodev/rte_crypto_asym.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h
>index 0a50cd5..991263f 100644
>--- a/lib/librte_cryptodev/rte_crypto_asym.h
>+++ b/lib/librte_cryptodev/rte_crypto_asym.h
>@@ -339,6 +339,16 @@ struct rte_crypto_mod_op_param {
>         * be relatively prime to modulus in corresponding Modular
>         * Multiplicative Inverse rte_crypto_modinv_xform
>         */
>+
>+       rte_crypto_param result;
>+       /**<
>+        * Pointer to the result of modular exponentiation/multiplicative inverse
>+        * data in octet-string network byte order format.
>+        *
>+        * This field shall be big enough to hold the result of Modular
>+        * Exponentiation or Modular Multplicative Inverse
>+        * (bigger or equal to length of modulus)
>+        */
> };
>
> /**
>--
>2.1.0

Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: add result field to mod exp and inverse operations

[Akhil Goyal]

On 2/12/2019 4:25 PM, Shally Verma wrote:
>
>> -----Original Message-----
>> From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>> Sent: 08 February 2019 16:44
>> To: dev@dpdk.org
>> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; shally.verma@caviumnetworks.com; Arek Kusztal <arkadiuszx.kusztal@intel.com>
>> Subject: [PATCH v2 1/3] cryptodev: add result field to mod exp and inverse operations
>>
>> External Email
>>
>> This commit adds result field to be used when modular exponentiation or
>> modular multiplicative inverse operation is used
>>
>> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>> ---
> Acked-by: Shally Verma <shallyv@marvell.com>
>
>> lib/librte_cryptodev/rte_crypto_asym.h | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h
>> index 0a50cd5..991263f 100644
>> --- a/lib/librte_cryptodev/rte_crypto_asym.h
>> +++ b/lib/librte_cryptodev/rte_crypto_asym.h
>> @@ -339,6 +339,16 @@ struct rte_crypto_mod_op_param {
>>          * be relatively prime to modulus in corresponding Modular
>>          * Multiplicative Inverse rte_crypto_modinv_xform
>>          */
>> +
>> +       rte_crypto_param result;
ABI breakage??
Do we have a deprecation notice?
>> +       /**<
>> +        * Pointer to the result of modular exponentiation/multiplicative inverse
>> +        * data in octet-string network byte order format.
>> +        *
>> +        * This field shall be big enough to hold the result of Modular
>> +        * Exponentiation or Modular Multplicative Inverse
>> +        * (bigger or equal to length of modulus)
>> +        */
>> };
>>
>> /**
>> --
>> 2.1.0

Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: add result field to mod exp and inverse operations

[Kusztal, ArkadiuszX]

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Thursday, February 28, 2019 10:59 AM
> To: Shally Verma <shallyv@marvell.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>;
> shally.verma@caviumnetworks.com
> Subject: Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: add result field to mod
> exp and inverse operations
> 
> 
> 
> On 2/12/2019 4:25 PM, Shally Verma wrote:
> >
> >> -----Original Message-----
> >> From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> >> Sent: 08 February 2019 16:44
> >> To: dev@dpdk.org
> >> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com;
> >> shally.verma@caviumnetworks.com; Arek Kusztal
> >> <arkadiuszx.kusztal@intel.com>
> >> Subject: [PATCH v2 1/3] cryptodev: add result field to mod exp and
> >> inverse operations
> >>
> >> External Email
> >>
> >> This commit adds result field to be used when modular exponentiation
> >> or modular multiplicative inverse operation is used
> >>
> >> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> >> ---
> > Acked-by: Shally Verma <shallyv@marvell.com>
> >
> >> lib/librte_cryptodev/rte_crypto_asym.h | 10 ++++++++++
> >> 1 file changed, 10 insertions(+)
> >>
> >> diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
> >> b/lib/librte_cryptodev/rte_crypto_asym.h
> >> index 0a50cd5..991263f 100644
> >> --- a/lib/librte_cryptodev/rte_crypto_asym.h
> >> +++ b/lib/librte_cryptodev/rte_crypto_asym.h
> >> @@ -339,6 +339,16 @@ struct rte_crypto_mod_op_param {
> >>          * be relatively prime to modulus in corresponding Modular
> >>          * Multiplicative Inverse rte_crypto_modinv_xform
> >>          */
> >> +
> >> +       rte_crypto_param result;
> ABI breakage??
> Do we have a deprecation notice?
Is not asymmetric crypto API still experimental? Do we have then add deprecation notice?

> >> +       /**<
> >> +        * Pointer to the result of modular exponentiation/multiplicative
> inverse
> >> +        * data in octet-string network byte order format.
> >> +        *
> >> +        * This field shall be big enough to hold the result of Modular
> >> +        * Exponentiation or Modular Multplicative Inverse
> >> +        * (bigger or equal to length of modulus)
> >> +        */
> >> };
> >>
> >> /**
> >> --
> >> 2.1.0

Thanks,
Arek

Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: add result field to mod exp and inverse operations

[Akhil Goyal]

Hi Arek,

On 2/28/2019 4:14 PM, Kusztal, ArkadiuszX wrote:
> Hi Akhil,
>
>> -----Original Message-----
>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>> Sent: Thursday, February 28, 2019 10:59 AM
>> To: Shally Verma <shallyv@marvell.com>; Kusztal, ArkadiuszX
>> <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
>> Cc: Trahe, Fiona <fiona.trahe@intel.com>;
>> shally.verma@caviumnetworks.com
>> Subject: Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: add result field to mod
>> exp and inverse operations
>>
>>
>>
>> On 2/12/2019 4:25 PM, Shally Verma wrote:
>>>> -----Original Message-----
>>>> From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>>>> Sent: 08 February 2019 16:44
>>>> To: dev@dpdk.org
>>>> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com;
>>>> shally.verma@caviumnetworks.com; Arek Kusztal
>>>> <arkadiuszx.kusztal@intel.com>
>>>> Subject: [PATCH v2 1/3] cryptodev: add result field to mod exp and
>>>> inverse operations
>>>>
>>>> External Email
>>>>
>>>> This commit adds result field to be used when modular exponentiation
>>>> or modular multiplicative inverse operation is used
>>>>
>>>> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>>>> ---
>>> Acked-by: Shally Verma <shallyv@marvell.com>
>>>
>>>> lib/librte_cryptodev/rte_crypto_asym.h | 10 ++++++++++
>>>> 1 file changed, 10 insertions(+)
>>>>
>>>> diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
>>>> b/lib/librte_cryptodev/rte_crypto_asym.h
>>>> index 0a50cd5..991263f 100644
>>>> --- a/lib/librte_cryptodev/rte_crypto_asym.h
>>>> +++ b/lib/librte_cryptodev/rte_crypto_asym.h
>>>> @@ -339,6 +339,16 @@ struct rte_crypto_mod_op_param {
>>>>           * be relatively prime to modulus in corresponding Modular
>>>>           * Multiplicative Inverse rte_crypto_modinv_xform
>>>>           */
>>>> +
>>>> +       rte_crypto_param result;
>> ABI breakage??
>> Do we have a deprecation notice?
> Is not asymmetric crypto API still experimental? Do we have then add deprecation notice?
sorry I missed that. Actually I did not see anything tagged as 
EXPERIMENTAL in rte_crypto_asym.h. Probably it should be mentioned at 
the top of the file as it is mentioned in other files which are 
experimental.
>
>>>> +       /**<
>>>> +        * Pointer to the result of modular exponentiation/multiplicative
>> inverse
>>>> +        * data in octet-string network byte order format.
>>>> +        *
>>>> +        * This field shall be big enough to hold the result of Modular
>>>> +        * Exponentiation or Modular Multplicative Inverse
>>>> +        * (bigger or equal to length of modulus)
>>>> +        */
>>>> };
>>>>
>>>> /**
>>>> --
>>>> 2.1.0
> Thanks,
> Arek

[dpdk-dev] [PATCH v2 2/3] openssl: add result field to mod exp and mod inv operations

[Arek Kusztal]

This patch adds result field to modular exponentiation and modular
multiplicative inverse operations in openssl pmd functions

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 drivers/crypto/openssl/rte_openssl_pmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
index 0230050..5096ca1 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -1790,7 +1790,7 @@ process_openssl_modinv_op(struct rte_crypto_op *cop,
 
 	if (BN_mod_inverse(res, base, sess->u.m.modulus, sess->u.m.ctx)) {
 		cop->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
-		op->modinv.base.length = BN_bn2bin(res, op->modinv.base.data);
+		op->modinv.result.length = BN_bn2bin(res, op->modinv.result.data);
 	} else {
 		cop->status = RTE_CRYPTO_OP_STATUS_ERROR;
 	}
@@ -1819,7 +1819,7 @@ process_openssl_modexp_op(struct rte_crypto_op *cop,
 
 	if (BN_mod_exp(res, base, sess->u.e.exp,
 				sess->u.e.mod, sess->u.e.ctx)) {
-		op->modex.base.length = BN_bn2bin(res, op->modex.base.data);
+		op->modex.result.length = BN_bn2bin(res, op->modex.result.data);
 		cop->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
 	} else {
 		cop->status = RTE_CRYPTO_OP_STATUS_ERROR;
-- 
2.1.0

[dpdk-dev] [PATCH v2 3/3] test: add result field to mod exp and mod inv

[Arek Kusztal]

This patch adds result field to modular exponentiation and
modular multiplicative inverse tests

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 test/test/test_cryptodev_asym.c      | 6 ++++++
 test/test/test_cryptodev_asym_util.h | 8 ++++----
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/test/test/test_cryptodev_asym.c b/test/test/test_cryptodev_asym.c
index 0f6fc57..a779e8f 100644
--- a/test/test/test_cryptodev_asym.c
+++ b/test/test/test_cryptodev_asym.c
@@ -940,6 +940,7 @@ test_mod_inv(void)
 	const struct rte_cryptodev_asymmetric_xform_capability *capability;
 	uint8_t input[TEST_DATA_SIZE] = {0};
 	int ret = 0;
+	uint8_t result[sizeof(mod_p)] = { 0 };
 
 	if (rte_cryptodev_asym_get_xform_enum(
 		&modinv_xform.xform_type, "modinv") < 0) {
@@ -993,6 +994,8 @@ test_mod_inv(void)
 	memcpy(input, base, sizeof(base));
 	asym_op->modinv.base.data = input;
 	asym_op->modinv.base.length = sizeof(base);
+	asym_op->modinv.result.data = result;
+	asym_op->modinv.result.length = sizeof(result);
 
 	/* attach asymmetric crypto session to crypto operations */
 	rte_crypto_op_attach_asym_session(op, sess);
@@ -1055,6 +1058,7 @@ test_mod_exp(void)
 	const struct rte_cryptodev_asymmetric_xform_capability *capability;
 	uint8_t input[TEST_DATA_SIZE] = {0};
 	int ret = 0;
+	uint8_t result[sizeof(mod_p)] = { 0 };
 
 	if (rte_cryptodev_asym_get_xform_enum(&modex_xform.xform_type,
 		"modexp")
@@ -1109,6 +1113,8 @@ test_mod_exp(void)
 	memcpy(input, base, sizeof(base));
 	asym_op->modex.base.data = input;
 	asym_op->modex.base.length = sizeof(base);
+	asym_op->modex.result.data = result;
+	asym_op->modex.result.length = sizeof(result);
 	/* attach asymmetric crypto session to crypto operations */
 	rte_crypto_op_attach_asym_session(op, sess);
 
diff --git a/test/test/test_cryptodev_asym_util.h b/test/test/test_cryptodev_asym_util.h
index dff0c2a..b3d9fb4 100644
--- a/test/test/test_cryptodev_asym_util.h
+++ b/test/test/test_cryptodev_asym_util.h
@@ -20,8 +20,8 @@ static inline int rsa_verify(struct rsa_test_data *rsa_param,
 static inline int verify_modinv(uint8_t *mod_inv,
 		struct rte_crypto_op *result_op)
 {
-	if (memcmp(mod_inv, result_op->asym->modinv.base.data,
-				result_op->asym->modinv.base.length))
+	if (memcmp(mod_inv, result_op->asym->modinv.result.data,
+				result_op->asym->modinv.result.length))
 		return -1;
 	return 0;
 }
@@ -29,8 +29,8 @@ static inline int verify_modinv(uint8_t *mod_inv,
 static inline int verify_modexp(uint8_t *mod_exp,
 		struct rte_crypto_op *result_op)
 {
-	if (memcmp(mod_exp, result_op->asym->modex.base.data,
-				result_op->asym->modex.base.length))
+	if (memcmp(mod_exp, result_op->asym->modex.result.data,
+				result_op->asym->modex.result.length))
 		return -1;
 	return 0;
 }
-- 
2.1.0

Re: [dpdk-dev] [PATCH v2 3/3] test: add result field to mod exp and mod inv

[Shally Verma]

>-----Original Message-----
>From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>Sent: 08 February 2019 16:44
>To: dev@dpdk.org
>Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; shally.verma@caviumnetworks.com; Arek Kusztal <arkadiuszx.kusztal@intel.com>
>Subject: [PATCH v2 3/3] test: add result field to mod exp and mod inv
>
>External Email
>
>This patch adds result field to modular exponentiation and
>modular multiplicative inverse tests
>
>Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>---
Acked-by: Shally Verma <shallyv@marvell.com>

Thanks
Shally

Re: [dpdk-dev] [PATCH v2 0/3] crypotodev: add result field to modular operations

[Trahe, Fiona]

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Friday, February 8, 2019 11:14 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; shally.verma@caviumnetworks.com;
> Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH v2 0/3] crypotodev: add result field to modular operations
> 
> This patchset adds result field to modular exponentiation and modular
> inverse operations
> 
> This patchset depends on following patches:
> 
> [1] - "[v3] cryptodev: rework mod exp and mod inv comments"
> (http://patchwork.dpdk.org/patch/50139/)
> [2] - "openssl: fix bad reference of modinv"
> (http://patchwork.dpdk.org/patch/50131/)
> 
> v2:
> - fix checkpatch issue
> 
> Arek Kusztal (3):
>   cryptodev: add result field to mod exp and inverse operations
>   openssl: add result field to mod exp and mod inv operations
>   test: add result field to mod exp and mod inv
Series-acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH v2 0/3] crypotodev: add result field to modular operations

[Akhil Goyal]

On 2/8/2019 4:43 PM, Arek Kusztal wrote:
> This patchset adds result field to modular exponentiation and modular
> inverse operations
>
> This patchset depends on following patches:
>
> [1] - "[v3] cryptodev: rework mod exp and mod inv comments"
> (http://patchwork.dpdk.org/patch/50139/)
> [2] - "openssl: fix bad reference of modinv"
> (http://patchwork.dpdk.org/patch/50131/)
>
> v2:
> - fix checkpatch issue
>
> Arek Kusztal (3):
>    cryptodev: add result field to mod exp and inverse operations
>    openssl: add result field to mod exp and mod inv operations
>    test: add result field to mod exp and mod inv
>
>   drivers/crypto/openssl/rte_openssl_pmd.c |  4 ++--
>   lib/librte_cryptodev/rte_crypto_asym.h   | 10 ++++++++++
>   test/test/test_cryptodev_asym.c          |  6 ++++++
>   test/test/test_cryptodev_asym_util.h     |  8 ++++----
>   4 files changed, 22 insertions(+), 6 deletions(-)
series applied to dpdk-next-crypto

Thanks.

Re: [dpdk-dev] [PATCH v2 0/3] crypotodev: add result field to modular operations

[Akhil Goyal]

On 2/8/2019 4:43 PM, Arek Kusztal wrote:
> This patchset adds result field to modular exponentiation and modular
> inverse operations
>
> This patchset depends on following patches:
>
> [1] - "[v3] cryptodev: rework mod exp and mod inv comments"
> (http://patchwork.dpdk.org/patch/50139/)
> [2] - "openssl: fix bad reference of modinv"
> (http://patchwork.dpdk.org/patch/50131/)
>
> v2:
> - fix checkpatch issue
>
> Arek Kusztal (3):
>    cryptodev: add result field to mod exp and inverse operations
>    openssl: add result field to mod exp and mod inv operations
>    test: add result field to mod exp and mod inv
>
>   drivers/crypto/openssl/rte_openssl_pmd.c |  4 ++--
>   lib/librte_cryptodev/rte_crypto_asym.h   | 10 ++++++++++
>   test/test/test_cryptodev_asym.c          |  6 ++++++
>   test/test/test_cryptodev_asym_util.h     |  8 ++++----
>   4 files changed, 22 insertions(+), 6 deletions(-)
series applied to dpdk-next-crypto

Thanks.