* [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode
@ 2019-03-05 14:40 Fan Zhang
2019-03-06 10:08 ` Ananyev, Konstantin
2019-03-19 13:45 ` Akhil Goyal
0 siblings, 2 replies; 6+ messages in thread
From: Fan Zhang @ 2019-03-05 14:40 UTC (permalink / raw)
To: dev; +Cc: akhil.goyal, roy.fan.zhang, konstantin.ananyev, stable
This patch fixes the incorrect block size for AES-CTR in
legacy mode. Originally, wrong block size will cause
esp_inbound() drop AES-CTR encrypted packets if the payload
sizes not equal to multiple times of 16.
Fixes: 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
Cc: stable@dpdk.org
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
examples/ipsec-secgw/sa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index 414fcd26c..93e3620bc 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] = {
.keyword = "aes-128-ctr",
.algo = RTE_CRYPTO_CIPHER_AES_CTR,
.iv_len = 8,
- .block_size = 16, /* XXX AESNI MB limition, should be 4 */
+ .block_size = 4,
.key_len = 20
},
{
--
2.14.5
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode
2019-03-05 14:40 [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode Fan Zhang
@ 2019-03-06 10:08 ` Ananyev, Konstantin
2019-03-19 13:45 ` Akhil Goyal
1 sibling, 0 replies; 6+ messages in thread
From: Ananyev, Konstantin @ 2019-03-06 10:08 UTC (permalink / raw)
To: Zhang, Roy Fan, dev; +Cc: akhil.goyal, stable
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Tuesday, March 5, 2019 2:41 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode
>
> This patch fixes the incorrect block size for AES-CTR in
> legacy mode. Originally, wrong block size will cause
> esp_inbound() drop AES-CTR encrypted packets if the payload
> sizes not equal to multiple times of 16.
>
> Fixes: 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> examples/ipsec-secgw/sa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
> index 414fcd26c..93e3620bc 100644
> --- a/examples/ipsec-secgw/sa.c
> +++ b/examples/ipsec-secgw/sa.c
> @@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] = {
> .keyword = "aes-128-ctr",
> .algo = RTE_CRYPTO_CIPHER_AES_CTR,
> .iv_len = 8,
> - .block_size = 16, /* XXX AESNI MB limition, should be 4 */
> + .block_size = 4,
> .key_len = 20
> },
> {
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.14.5
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode
2019-03-05 14:40 [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode Fan Zhang
2019-03-06 10:08 ` Ananyev, Konstantin
@ 2019-03-19 13:45 ` Akhil Goyal
2019-03-19 13:45 ` Akhil Goyal
2019-03-19 14:05 ` Akhil Goyal
1 sibling, 2 replies; 6+ messages in thread
From: Akhil Goyal @ 2019-03-19 13:45 UTC (permalink / raw)
To: Fan Zhang, dev; +Cc: konstantin.ananyev, stable
On 3/5/2019 8:10 PM, Fan Zhang wrote:
> This patch fixes the incorrect block size for AES-CTR in
> legacy mode. Originally, wrong block size will cause
> esp_inbound() drop AES-CTR encrypted packets if the payload
> sizes not equal to multiple times of 16.
>
> Fixes: 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> examples/ipsec-secgw/sa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
> index 414fcd26c..93e3620bc 100644
> --- a/examples/ipsec-secgw/sa.c
> +++ b/examples/ipsec-secgw/sa.c
> @@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] = {
> .keyword = "aes-128-ctr",
> .algo = RTE_CRYPTO_CIPHER_AES_CTR,
> .iv_len = 8,
> - .block_size = 16, /* XXX AESNI MB limition, should be 4 */
> + .block_size = 4,
> .key_len = 20
> },
> {
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Title should be examples/ipsec-secgw:...
Will correct it while merging
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode
2019-03-19 13:45 ` Akhil Goyal
@ 2019-03-19 13:45 ` Akhil Goyal
2019-03-19 14:05 ` Akhil Goyal
1 sibling, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2019-03-19 13:45 UTC (permalink / raw)
To: Fan Zhang, dev; +Cc: konstantin.ananyev, stable
On 3/5/2019 8:10 PM, Fan Zhang wrote:
> This patch fixes the incorrect block size for AES-CTR in
> legacy mode. Originally, wrong block size will cause
> esp_inbound() drop AES-CTR encrypted packets if the payload
> sizes not equal to multiple times of 16.
>
> Fixes: 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> examples/ipsec-secgw/sa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
> index 414fcd26c..93e3620bc 100644
> --- a/examples/ipsec-secgw/sa.c
> +++ b/examples/ipsec-secgw/sa.c
> @@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] = {
> .keyword = "aes-128-ctr",
> .algo = RTE_CRYPTO_CIPHER_AES_CTR,
> .iv_len = 8,
> - .block_size = 16, /* XXX AESNI MB limition, should be 4 */
> + .block_size = 4,
> .key_len = 20
> },
> {
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Title should be examples/ipsec-secgw:...
Will correct it while merging
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode
2019-03-19 13:45 ` Akhil Goyal
2019-03-19 13:45 ` Akhil Goyal
@ 2019-03-19 14:05 ` Akhil Goyal
2019-03-19 14:05 ` Akhil Goyal
1 sibling, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2019-03-19 14:05 UTC (permalink / raw)
To: Fan Zhang, dev; +Cc: konstantin.ananyev, stable
On 3/19/2019 7:15 PM, Akhil Goyal wrote:
>
> On 3/5/2019 8:10 PM, Fan Zhang wrote:
>> This patch fixes the incorrect block size for AES-CTR in
>> legacy mode. Originally, wrong block size will cause
>> esp_inbound() drop AES-CTR encrypted packets if the payload
>> sizes not equal to multiple times of 16.
>>
>> Fixes: 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>> ---
>> examples/ipsec-secgw/sa.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
>> index 414fcd26c..93e3620bc 100644
>> --- a/examples/ipsec-secgw/sa.c
>> +++ b/examples/ipsec-secgw/sa.c
>> @@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] = {
>> .keyword = "aes-128-ctr",
>> .algo = RTE_CRYPTO_CIPHER_AES_CTR,
>> .iv_len = 8,
>> - .block_size = 16, /* XXX AESNI MB limition, should be 4 */
>> + .block_size = 4,
>> .key_len = 20
>> },
>> {
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>
> Title should be examples/ipsec-secgw:...
> Will correct it while merging
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode
2019-03-19 14:05 ` Akhil Goyal
@ 2019-03-19 14:05 ` Akhil Goyal
0 siblings, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2019-03-19 14:05 UTC (permalink / raw)
To: Fan Zhang, dev; +Cc: konstantin.ananyev, stable
On 3/19/2019 7:15 PM, Akhil Goyal wrote:
>
> On 3/5/2019 8:10 PM, Fan Zhang wrote:
>> This patch fixes the incorrect block size for AES-CTR in
>> legacy mode. Originally, wrong block size will cause
>> esp_inbound() drop AES-CTR encrypted packets if the payload
>> sizes not equal to multiple times of 16.
>>
>> Fixes: 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>> ---
>> examples/ipsec-secgw/sa.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
>> index 414fcd26c..93e3620bc 100644
>> --- a/examples/ipsec-secgw/sa.c
>> +++ b/examples/ipsec-secgw/sa.c
>> @@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] = {
>> .keyword = "aes-128-ctr",
>> .algo = RTE_CRYPTO_CIPHER_AES_CTR,
>> .iv_len = 8,
>> - .block_size = 16, /* XXX AESNI MB limition, should be 4 */
>> + .block_size = 4,
>> .key_len = 20
>> },
>> {
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>
> Title should be examples/ipsec-secgw:...
> Will correct it while merging
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-19 14:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-05 14:40 [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode Fan Zhang
2019-03-06 10:08 ` Ananyev, Konstantin
2019-03-19 13:45 ` Akhil Goyal
2019-03-19 13:45 ` Akhil Goyal
2019-03-19 14:05 ` Akhil Goyal
2019-03-19 14:05 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).