From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 6EDC62C39; Wed, 20 Mar 2019 05:57:06 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 21:57:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,247,1549958400"; d="scan'208";a="153947471" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by fmsmga004.fm.intel.com with ESMTP; 19 Mar 2019 21:57:04 -0700 Date: Wed, 20 Mar 2019 12:56:49 +0800 From: Tiwei Bie To: Jiayu Hu Cc: dev@dpdk.org, maxime.coquelin@redhat.com, yinan.wang@intel.com, stable@dpdk.org Message-ID: <20190320045645.GB26570@dpdk-tbie.sh.intel.com> References: <1550823230-16809-1-git-send-email-jiayu.hu@intel.com> <1552804712-9973-1-git-send-email-jiayu.hu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1552804712-9973-1-git-send-email-jiayu.hu@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix interrupt suppression for the split ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 04:57:07 -0000 On Sun, Mar 17, 2019 at 02:38:32PM +0800, Jiayu Hu wrote: > The VIRTIO_RING_F_EVENT_IDX feature of split ring might > be broken, as the value of signalled_used is invalid > after live migration, start up and virtio driver reload. > This patch fixes it by using signalled_used_valid. > > In addition, this patch makes the VIRTIO_RING_F_EVENT_IDX > implementation of split ring match kernel backend to suppress > more interrupts. > > Fixes: e37ff954405a ("vhost: support virtqueue interrupt/notification suppression") > Cc: stable@dpdk.org > > Signed-off-by: Jiayu Hu > --- > change in v2: > - fix virtio-net driver reload > > lib/librte_vhost/vhost.h | 12 ++++++++---- > lib/librte_vhost/vhost_user.c | 2 ++ > 2 files changed, 10 insertions(+), 4 deletions(-) Reviewed-by: Tiwei Bie From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C9D5CA00E6 for ; Wed, 20 Mar 2019 05:57:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0755D2C60; Wed, 20 Mar 2019 05:57:09 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 6EDC62C39; Wed, 20 Mar 2019 05:57:06 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 21:57:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,247,1549958400"; d="scan'208";a="153947471" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by fmsmga004.fm.intel.com with ESMTP; 19 Mar 2019 21:57:04 -0700 Date: Wed, 20 Mar 2019 12:56:49 +0800 From: Tiwei Bie To: Jiayu Hu Cc: dev@dpdk.org, maxime.coquelin@redhat.com, yinan.wang@intel.com, stable@dpdk.org Message-ID: <20190320045645.GB26570@dpdk-tbie.sh.intel.com> References: <1550823230-16809-1-git-send-email-jiayu.hu@intel.com> <1552804712-9973-1-git-send-email-jiayu.hu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1552804712-9973-1-git-send-email-jiayu.hu@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix interrupt suppression for the split ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320045649.r0Ci5GaYDZALO51hpiZUCVYhcrT-qLth1nW6qZrb0BE@z> On Sun, Mar 17, 2019 at 02:38:32PM +0800, Jiayu Hu wrote: > The VIRTIO_RING_F_EVENT_IDX feature of split ring might > be broken, as the value of signalled_used is invalid > after live migration, start up and virtio driver reload. > This patch fixes it by using signalled_used_valid. > > In addition, this patch makes the VIRTIO_RING_F_EVENT_IDX > implementation of split ring match kernel backend to suppress > more interrupts. > > Fixes: e37ff954405a ("vhost: support virtqueue interrupt/notification suppression") > Cc: stable@dpdk.org > > Signed-off-by: Jiayu Hu > --- > change in v2: > - fix virtio-net driver reload > > lib/librte_vhost/vhost.h | 12 ++++++++---- > lib/librte_vhost/vhost_user.c | 2 ++ > 2 files changed, 10 insertions(+), 4 deletions(-) Reviewed-by: Tiwei Bie