From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Pei, Andy" <andy.pei@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] raw/ifpga: modify log output
Date: Wed, 20 Mar 2019 08:16:05 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73A61B143@SHSMSX104.ccr.corp.intel.com> (raw)
Message-ID: <20190320081605.TGmkaoyxgY9Ei1C56IYAdV445kdwNWABsXRNMDCuzSE@z> (raw)
In-Reply-To: <1553069009-64692-1-git-send-email-andy.pei@intel.com>
> -----Original Message-----
> From: Pei, Andy
> Sent: Wednesday, March 20, 2019 16:03
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v2] raw/ifpga: modify log output
>
> print function name in ifpga log and a new line goes after every IFPGA log.
>
> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> Cc: rosen.xu@intel.com
> Cc: andy.pei@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
> b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
> index c7759b8..234ce36 100644
> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
> @@ -8,8 +8,8 @@
> extern int ifpga_rawdev_logtype;
>
> #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \
> - rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \
> - ##args)
> + rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \
> + __func__, ##args)
>
> #define IFPGA_RAWDEV_PMD_FUNC_TRACE()
> IFPGA_RAWDEV_PMD_LOG(DEBUG, ">>")
>
> --
> 1.8.3.1
Reviewed-by: Rosen Xu <rosen.xu@intel.com>
next prev parent reply other threads:[~2019-03-20 8:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 9:47 [dpdk-dev] [PATCH] " Andy Pei
2019-03-14 9:47 ` Andy Pei
2019-03-19 3:09 ` Xu, Rosen
2019-03-19 3:09 ` Xu, Rosen
2019-03-19 7:56 ` Pei, Andy
2019-03-19 7:56 ` Pei, Andy
2019-03-19 10:40 ` Xu, Rosen
2019-03-19 10:40 ` Xu, Rosen
2019-03-20 7:36 ` Pei, Andy
2019-03-20 7:36 ` Pei, Andy
[not found] ` <1553069009-64692-1-git-send-email-andy.pei@intel.com>
2019-03-20 8:16 ` Xu, Rosen [this message]
2019-03-20 8:16 ` [dpdk-dev] [PATCH v2] " Xu, Rosen
2019-03-20 11:11 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-20 11:11 ` Ferruh Yigit
2019-03-27 1:32 [dpdk-dev] " Andy Pei
2019-03-27 1:32 ` Andy Pei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D73A61B143@SHSMSX104.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=andy.pei@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).