From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id C4B74A00E6
for <public@inbox.dpdk.org>; Wed, 20 Mar 2019 13:21:03 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id AAF365B12;
Wed, 20 Mar 2019 13:21:02 +0100 (CET)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id E4FE85A6E;
Wed, 20 Mar 2019 13:21:01 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
[10.5.11.13])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 2B0162D7E0;
Wed, 20 Mar 2019 12:21:01 +0000 (UTC)
Received: from [10.36.116.76] (ovpn-116-76.ams2.redhat.com [10.36.116.76])
by smtp.corp.redhat.com (Postfix) with ESMTP id CAC1E60A9E;
Wed, 20 Mar 2019 12:20:59 +0000 (UTC)
To: Wei Zhao <wei.zhao1@intel.com>, dev@dpdk.org
Cc: yuan.peng@intel.com, stable@dpdk.org, qi.z.zhang@intel.com
References: <1553052676-7961-1-git-send-email-wei.zhao1@intel.com>
From: Kevin Traynor <ktraynor@redhat.com>
Message-ID: <26b0ab4f-3bae-7ce4-89d0-4c1e49500440@redhat.com>
Date: Wed, 20 Mar 2019 12:20:58 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <1553052676-7961-1-git-send-email-wei.zhao1@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.30]); Wed, 20 Mar 2019 12:21:01 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect
RSS key
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190320122058.9mUKXp9gSP_tOZa1pOFisBOdUyeGPrq1SqqIxxl1Vfo@z>
On 20/03/2019 03:31, Wei Zhao wrote:
> There need a warning info when no perfect RSS key is config,
It is mixing info and warning levels in the description and log. Better
to be consistent and use one (I think info).
> so i40e will use default key.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index dca61f0..9235b08 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
> rss_conf.rss_key = (uint8_t *)rss_key_default;
> rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> sizeof(uint32_t);
> + PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so use default configuration\n");
It's an info log, so remove "Warning!" and the message can be a little
clearer so user doesn't interpret as an instruction. Suggest "No RSS key
config for i40e provided, using default"
> }
>
> i40e_hw_rss_hash_set(pf, &rss_conf);
>